Changeset 237598 in webkit

Timestamp:

Oct 30, 2018, 12:58:51 PM (7 years ago)

Author:

ajuma@chromium.org

Message:

Calling window.open("", "_self") allows working around restrictions on window.close()
​https://bugs.webkit.org/show_bug.cgi?id=191073

Reviewed by Chris Dumez.

Source/WebCore:

Do not treat a re-used frame in DOMWindow::createWindow as having been opened by DOM.

Test: fast/dom/Window/window-open-self-disallow-close.html

• page/DOMWindow.cpp:

(WebCore::DOMWindow::createWindow):

LayoutTests:

• fast/dom/Window/window-open-self-disallow-close-expected.txt: Added.
• fast/dom/Window/window-open-self-disallow-close.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/Window/window-open-self-disallow-close-expected.txt (added)
• LayoutTests/fast/dom/Window/window-open-self-disallow-close.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/DOMWindow.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-10-30  Ali Juma  <ajuma@chromium.org>
+
+        Calling window.open("", "_self") allows working around restrictions on window.close()
+        https://bugs.webkit.org/show_bug.cgi?id=191073
+
+        Reviewed by Chris Dumez.
+
+        * fast/dom/Window/window-open-self-disallow-close-expected.txt: Added.
+        * fast/dom/Window/window-open-self-disallow-close.html: Added.
+
 2018-10-30  Andy Estes  <aestes@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-10-30  Ali Juma  <ajuma@chromium.org>
+
+        Calling window.open("", "_self") allows working around restrictions on window.close()
+        https://bugs.webkit.org/show_bug.cgi?id=191073
+
+        Reviewed by Chris Dumez.
+
+        Do not treat a re-used frame in DOMWindow::createWindow as having been opened by DOM.
+
+        Test: fast/dom/Window/window-open-self-disallow-close.html
+
+        * page/DOMWindow.cpp:
+        (WebCore::DOMWindow::createWindow):
+
 2018-10-30  Andy Estes  <aestes@apple.com>
 

trunk/Source/WebCore/page/DOMWindow.cpp

@@ -2242 +2242 @@
         newFrame->page()->setOpenedViaWindowOpenWithOpener();
     }
-    newFrame->page()->setOpenedByDOM();
+    if (created)
+        newFrame->page()->setOpenedByDOM();
 
     if (newFrame->document()->domWindow()->isInsecureScriptAccess(activeWindow, completedURL))