Changeset 237917 in webkit

Timestamp:

Nov 6, 2018 11:32:45 PM (6 years ago)

Author:

commit-queue@webkit.org

Message:

ServiceWorker Inspector: Uncaught Exception: null is not an object (evaluating 'resource.target.addResource')
​https://bugs.webkit.org/show_bug.cgi?id=191339

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-11-06
Reviewed by Matt Baker.

• workers/service/ServiceWorkerJob.cpp:

(WebCore::ServiceWorkerJob::fetchScriptWithContext):
Use the Service Worker's identifier, not this static but otherwise unknown identifier.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• workers/service/ServiceWorkerJob.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-11-06  Joseph Pecoraro  <pecoraro@apple.com>
+
+        ServiceWorker Inspector: Uncaught Exception: null is not an object (evaluating 'resource.target.addResource')
+        https://bugs.webkit.org/show_bug.cgi?id=191339
+
+        Reviewed by Matt Baker.
+
+        * workers/service/ServiceWorkerJob.cpp:
+        (WebCore::ServiceWorkerJob::fetchScriptWithContext):
+        Use the Service Worker's identifier, not this static but otherwise unknown identifier.
+
 2018-11-06  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/workers/service/ServiceWorkerJob.cpp

@@ -96 +96 @@
 
     ResourceRequest request { m_jobData.scriptURL };
-    request.setInitiatorIdentifier("serviceWorkerScriptLoad:");
+    request.setInitiatorIdentifier(context.resourceRequestIdentifier());
     request.addHTTPHeaderField("Service-Worker"_s, "script"_s);