Changeset 238002 in webkit
- Timestamp:
- Nov 8, 2018 2:18:15 PM (5 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 15 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r238001 r238002 1 2018-11-07 Myles C. Maxfield <mmaxfield@apple.com> 2 3 Unprefix text-decoration CSS3 properties 4 https://bugs.webkit.org/show_bug.cgi?id=127193 5 6 Reviewed by Dean Jackson. 7 8 * fast/css3-text/css3-text-decoration/unprefix-expected.html: Added. 9 * fast/css3-text/css3-text-decoration/unprefix.html: Added. 10 1 11 2018-11-08 Timothy Hatcher <timothy@apple.com> 2 12 -
trunk/LayoutTests/imported/blink/fast/css3-text/css3-text-decoration/text-decoration-line-recalc-expected.html
r190629 r238002 3 3 div { 4 4 font-size: 50px; 5 text-decoration: overline solid green;5 text-decoration: overline; 6 6 } 7 7 </style> -
trunk/LayoutTests/imported/blink/fast/css3-text/css3-text-decoration/text-decoration-line-recalc.html
r190629 r238002 3 3 div { 4 4 font-size: 50px; 5 text-decoration: underline solid green;5 text-decoration: underline; 6 6 } 7 7 </style> -
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-line-recalc-expected.html
r232903 r238002 3 3 div { 4 4 font-size: 50px; 5 text-decoration: overline solid green;5 text-decoration: overline; 6 6 } 7 7 </style> -
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-line-recalc.html
r232903 r238002 5 5 div { 6 6 font-size: 50px; 7 text-decoration: underline solid green;7 text-decoration: underline; 8 8 } 9 9 </style> -
trunk/LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries-expected.txt
r232903 r238002 78 78 PASS subtest_77 79 79 PASS subtest_78 80 FAIL subtest_79 assert_true: expected true got false 80 PASS subtest_79 81 81 PASS subtest_80 82 82 PASS subtest_81 83 FAIL subtest_82 assert_true: expected true got false 83 PASS subtest_82 84 84 PASS subtest_83 85 FAIL subtest_84 assert_true: expected true got false 86 FAIL subtest_85 assert_true: expected true got false 87 FAIL subtest_86 assert_true: expected true got false 85 PASS subtest_84 86 PASS subtest_85 87 PASS subtest_86 88 88 PASS subtest_87 89 89 PASS subtest_88 90 FAIL subtest_89 assert_true: expected true got false 91 FAIL subtest_90 assert_true: expected true got false 90 PASS subtest_89 91 PASS subtest_90 92 92 PASS subtest_91 93 FAIL subtest_92 assert_true: expected true got false 93 PASS subtest_92 94 94 PASS subtest_93 95 95 PASS subtest_94 96 FAIL subtest_95 assert_true: expected true got false 96 PASS subtest_95 97 97 PASS subtest_96 98 FAIL subtest_97 assert_true: expected true got false 99 FAIL subtest_98 assert_true: expected true got false 100 FAIL subtest_99 assert_true: expected true got false 98 PASS subtest_97 99 PASS subtest_98 100 PASS subtest_99 101 101 PASS subtest_100 102 102 PASS subtest_101 103 FAIL subtest_102 assert_true: expected true got false 104 FAIL subtest_103 assert_true: expected true got false 103 PASS subtest_102 104 PASS subtest_103 105 105 PASS subtest_104 106 FAIL subtest_105 assert_true: expected true got false 106 PASS subtest_105 107 107 PASS subtest_106 108 108 PASS subtest_107 109 FAIL subtest_108 assert_true: expected true got false 109 PASS subtest_108 110 110 PASS subtest_109 111 FAIL subtest_110 assert_true: expected true got false 112 FAIL subtest_111 assert_true: expected true got false 113 FAIL subtest_112 assert_true: expected true got false 111 PASS subtest_110 112 PASS subtest_111 113 PASS subtest_112 114 114 PASS subtest_113 115 115 PASS subtest_114 116 FAIL subtest_115 assert_true: expected true got false 117 FAIL subtest_116 assert_true: expected true got false 116 PASS subtest_115 117 PASS subtest_116 118 118 PASS subtest_117 119 FAIL subtest_118 assert_true: expected true got false 119 PASS subtest_118 120 120 PASS subtest_119 121 121 PASS subtest_120 122 FAIL subtest_121 assert_true: expected true got false 122 PASS subtest_121 123 123 PASS subtest_122 124 FAIL subtest_123 assert_true: expected true got false 125 FAIL subtest_124 assert_true: expected true got false 126 FAIL subtest_125 assert_true: expected true got false 124 PASS subtest_123 125 PASS subtest_124 126 PASS subtest_125 127 127 PASS subtest_126 128 128 PASS subtest_127 129 FAIL subtest_128 assert_true: expected true got false 130 FAIL subtest_129 assert_true: expected true got false 129 PASS subtest_128 130 PASS subtest_129 131 131 PASS subtest_130 132 FAIL subtest_131 assert_true: expected true got false 132 PASS subtest_131 133 133 PASS subtest_132 134 134 PASS subtest_133 135 135 PASS subtest_134 136 FAIL subtest_135 assert_true: expected true got false 137 FAIL subtest_136 assert_true: expected true got false 136 PASS subtest_135 137 PASS subtest_136 138 138 PASS subtest_137 139 FAIL subtest_138 assert_true: expected true got false 140 FAIL subtest_139 assert_true: expected true got false 141 FAIL subtest_140 assert_true: expected true got false 139 PASS subtest_138 140 PASS subtest_139 141 PASS subtest_140 142 142 PASS subtest_141 143 143 PASS subtest_142 … … 149 149 PASS subtest_148 150 150 PASS subtest_149 151 FAIL subtest_150 assert_true: expected true got false 152 FAIL subtest_151 assert_true: expected true got false 151 PASS subtest_150 152 PASS subtest_151 153 153 PASS subtest_152 154 FAIL subtest_153 assert_true: expected true got false 155 FAIL subtest_154 assert_true: expected true got false 154 PASS subtest_153 155 PASS subtest_154 156 156 PASS subtest_155 157 FAIL subtest_156 assert_true: expected true got false 158 FAIL subtest_157 assert_true: expected true got false 159 FAIL subtest_158 assert_true: expected true got false 157 PASS subtest_156 158 PASS subtest_157 159 PASS subtest_158 160 160 PASS subtest_159 161 161 PASS subtest_160 162 162 PASS subtest_161 163 163 PASS subtest_162 164 FAIL subtest_163 assert_true: expected true got false 165 FAIL subtest_164 assert_true: expected true got false 166 FAIL subtest_165 assert_true: expected true got false 164 PASS subtest_163 165 PASS subtest_164 166 PASS subtest_165 167 167 PASS subtest_166 168 168 PASS subtest_167 169 169 PASS subtest_168 170 170 PASS subtest_169 171 FAIL subtest_170 assert_true: expected true got false 172 FAIL subtest_171 assert_true: expected true got false 173 FAIL subtest_172 assert_true: expected true got false 174 FAIL subtest_173 assert_true: expected true got false 171 PASS subtest_170 172 PASS subtest_171 173 PASS subtest_172 174 PASS subtest_173 175 175 PASS subtest_174 176 176 PASS subtest_175 177 177 PASS subtest_176 178 FAIL subtest_177 assert_true: expected true got false 178 PASS subtest_177 179 179 PASS subtest_178 180 180 PASS subtest_179 181 FAIL subtest_180 assert_true: expected true got false 182 FAIL subtest_181 assert_true: expected true got false 181 PASS subtest_180 182 PASS subtest_181 183 183 PASS subtest_182 184 FAIL subtest_183 assert_true: expected true got false 185 FAIL subtest_184 assert_true: expected true got false 184 PASS subtest_183 185 PASS subtest_184 186 186 PASS subtest_185 187 187 PASS subtest_186 188 FAIL subtest_187 assert_true: expected true got false 189 FAIL subtest_188 assert_true: expected true got false 190 FAIL subtest_189 assert_true: expected true got false 188 PASS subtest_187 189 PASS subtest_188 190 PASS subtest_189 191 191 PASS subtest_190 192 FAIL subtest_191 assert_true: expected true got false 192 PASS subtest_191 193 193 PASS subtest_192 194 FAIL subtest_193 assert_true: expected true got false 194 PASS subtest_193 195 195 PASS subtest_194 196 FAIL subtest_195 assert_true: expected true got false 197 FAIL subtest_196 assert_true: expected true got false 198 FAIL subtest_197 assert_true: expected true got false 196 PASS subtest_195 197 PASS subtest_196 198 PASS subtest_197 199 199 PASS subtest_198 200 FAIL subtest_199 assert_true: expected true got false 200 PASS subtest_199 201 201 PASS subtest_200 202 202 PASS subtest_201 … … 230 230 PASS subtest_229 231 231 PASS subtest_230 232 FAIL monochrome_and_color assert_not_equals: should be either monochrome or color got disallowed value false 232 PASS monochrome_and_color 233 233 PASS find_depth 234 FAIL subtest_231 assert_true: expected true got false 234 PASS subtest_231 235 235 PASS subtest_232 236 236 PASS subtest_233 237 FAIL subtest_234 assert_true: expected true got false 237 PASS subtest_234 238 238 PASS subtest_235 239 FAIL subtest_236 assert_true: expected true got false 239 PASS subtest_236 240 240 PASS subtest_237 241 241 PASS subtest_238 242 242 PASS subtest_239 243 FAIL subtest_240 assert_true: expected true got false 243 PASS subtest_240 244 244 PASS subtest_241 245 245 PASS subtest_242 246 246 PASS subtest_243 247 FAIL subtest_244 assert_true: expected true got false 247 PASS subtest_244 248 248 PASS subtest_245 249 FAIL subtest_246 assert_true: expected true got false 249 PASS subtest_246 250 250 PASS subtest_247 251 251 PASS subtest_248 … … 266 266 PASS subtest_263 267 267 PASS subtest_264 268 FAIL subtest_265 assert_true: expected true got false 268 PASS subtest_265 269 269 PASS subtest_266 270 FAIL subtest_267 assert_true: expected true got false 270 PASS subtest_267 271 271 PASS subtest_268 272 FAIL subtest_269 assert_true: expected true got false 273 FAIL subtest_270 assert_true: expected true got false 274 FAIL subtest_271 assert_true: expected true got false 272 PASS subtest_269 273 PASS subtest_270 274 PASS subtest_271 275 275 PASS subtest_272 276 276 PASS subtest_273 … … 319 319 PASS subtest_315 320 320 FAIL subtest_316 assert_true: expected true got false 321 PASS subtest_317 322 FAIL subtest_318 assert_true: expected true got false 321 FAIL subtest_317 assert_false: expected false got true 322 PASS subtest_318 323 323 PASS subtest_319 324 324 FAIL subtest_320 assert_true: expected true got false 325 325 FAIL subtest_321 assert_true: expected true got false 326 326 PASS subtest_322 327 FAIL subtest_323 assert_true: expected true got false 327 PASS subtest_323 328 328 FAIL subtest_324 assert_true: expected true got false 329 329 FAIL subtest_325 assert_true: expected true got false … … 349 349 PASS subtest_345 350 350 PASS subtest_346 351 FAIL subtest_347 assert_true: expected true got false 351 PASS subtest_347 352 352 PASS subtest_348 353 353 PASS subtest_349 … … 358 358 PASS subtest_354 359 359 PASS subtest_355 360 FAIL subtest_356 assert_true: expected true got false 360 PASS subtest_356 361 361 PASS subtest_357 362 362 FAIL subtest_358 assert_true: expected true got false 363 363 PASS subtest_359 364 364 PASS subtest_360 365 FAIL subtest_361 assert_true: expected true got false 365 PASS subtest_361 366 366 PASS subtest_362 367 FAIL subtest_363 assert_true: expected true got false 368 FAIL subtest_364 assert_true: expected true got false 369 FAIL subtest_365 assert_true: expected true got false 370 FAIL subtest_366 assert_true: expected true got false 371 FAIL subtest_367 assert_true: expected true got false 367 PASS subtest_363 368 PASS subtest_364 369 PASS subtest_365 370 PASS subtest_366 371 PASS subtest_367 372 372 PASS subtest_368 373 FAIL subtest_369 assert_true: expected true got false 374 FAIL subtest_370 assert_true: expected true got false 373 PASS subtest_369 374 PASS subtest_370 375 375 PASS subtest_371 376 376 PASS subtest_372 377 FAIL subtest_373 assert_true: expected true got false 378 FAIL subtest_374 assert_true: expected true got false 377 PASS subtest_373 378 PASS subtest_374 379 379 PASS subtest_375 380 380 PASS subtest_376 -
trunk/Source/WebCore/ChangeLog
r238001 r238002 1 2018-11-07 Myles C. Maxfield <mmaxfield@apple.com> 2 3 Unprefix text-decoration CSS3 properties 4 https://bugs.webkit.org/show_bug.cgi?id=127193 5 6 Reviewed by Dean Jackson. 7 8 The properties are stable, and there is interop. 9 10 Test: fast/css3-text/css3-text-decoration/unprefix.html 11 12 * css/CSSComputedStyleDeclaration.cpp: 13 (WebCore::ComputedStyleExtractor::valueForPropertyinStyle): 14 * css/CSSProperties.json: 15 * css/StyleResolver.cpp: 16 (WebCore::shouldApplyPropertyInParseOrder): 17 (WebCore::isValidVisitedLinkProperty): 18 * css/parser/CSSParserFastPaths.cpp: 19 (WebCore::isColorPropertyID): 20 (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue): 21 (WebCore::CSSParserFastPaths::isKeywordPropertyID): 22 * css/parser/CSSPropertyParser.cpp: 23 (WebCore::CSSPropertyParser::parseSingleValue): 24 * editing/cocoa/DataDetection.mm: 25 (WebCore::DataDetection::detectContentInRange): 26 * rendering/TextDecorationPainter.cpp: 27 (WebCore::decorationColor): 28 * rendering/style/RenderStyle.cpp: 29 (WebCore::RenderStyle::colorIncludingFallback const): 30 (WebCore::RenderStyle::visitedDependentColor const): 31 1 32 2018-11-08 Timothy Hatcher <timothy@apple.com> 2 33 -
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
r238001 r238002 212 212 CSSPropertyWebkitTextJustify, 213 213 #endif // CSS3_TEXT 214 CSSProperty WebkitTextDecorationLine,215 CSSProperty WebkitTextDecorationStyle,216 CSSProperty WebkitTextDecorationColor,217 CSSProperty WebkitTextDecorationSkip,214 CSSPropertyTextDecorationLine, 215 CSSPropertyTextDecorationStyle, 216 CSSPropertyTextDecorationColor, 217 CSSPropertyTextDecorationSkip, 218 218 CSSPropertyTextUnderlinePosition, 219 219 CSSPropertyTextIndent, … … 3345 3345 case CSSPropertyWebkitTextDecoration: 3346 3346 return getCSSPropertyValuesForShorthandProperties(webkitTextDecorationShorthand()); 3347 case CSSProperty WebkitTextDecorationLine:3347 case CSSPropertyTextDecorationLine: 3348 3348 return renderTextDecorationFlagsToCSSValue(style.textDecoration()); 3349 case CSSProperty WebkitTextDecorationStyle:3349 case CSSPropertyTextDecorationStyle: 3350 3350 return renderTextDecorationStyleFlagsToCSSValue(style.textDecorationStyle()); 3351 case CSSProperty WebkitTextDecorationColor:3351 case CSSPropertyTextDecorationColor: 3352 3352 return currentColorOrValidColor(&style, style.textDecorationColor()); 3353 case CSSProperty WebkitTextDecorationSkip:3353 case CSSPropertyTextDecorationSkip: 3354 3354 return renderTextDecorationSkipFlagsToCSSValue(style.textDecorationSkip()); 3355 3355 case CSSPropertyTextUnderlinePosition: -
trunk/Source/WebCore/css/CSSProperties.json
r238001 r238002 5875 5875 "codegen-properties": { 5876 5876 "longhands": [ 5877 " -webkit-text-decoration-line",5878 " -webkit-text-decoration-style",5879 " -webkit-text-decoration-color"5877 "text-decoration-line", 5878 "text-decoration-style", 5879 "text-decoration-color" 5880 5880 ] 5881 5881 }, … … 5888 5888 } 5889 5889 }, 5890 " -webkit-text-decoration-line": {5890 "text-decoration-line": { 5891 5891 "codegen-properties": { 5892 5892 "name-for-methods": "TextDecoration", 5893 "converter": "TextDecoration" 5893 "converter": "TextDecoration", 5894 "aliases": [ 5895 "-webkit-text-decoration-line" 5896 ] 5894 5897 }, 5895 5898 "status": { … … 5901 5904 } 5902 5905 }, 5903 "-webkit-text-decoration-style": { 5906 "text-decoration-style": { 5907 "codegen-properties": { 5908 "aliases": [ 5909 "-webkit-text-decoration-style" 5910 ] 5911 }, 5904 5912 "values": [ 5905 5913 "solid", … … 5917 5925 } 5918 5926 }, 5919 " -webkit-text-decoration-color": {5927 "text-decoration-color": { 5920 5928 "codegen-properties": { 5921 5929 "initial": "invalidColor", 5922 "visited-link-color-support": true 5930 "visited-link-color-support": true, 5931 "aliases": [ 5932 "-webkit-text-decoration-color" 5933 ] 5923 5934 }, 5924 5935 "status": { … … 5930 5941 } 5931 5942 }, 5932 "-webkit-text-decoration-skip": { 5933 "inherited": true, 5934 "codegen-properties": { 5935 "converter": "TextDecorationSkip" 5943 "text-decoration-skip": { 5944 "inherited": true, 5945 "codegen-properties": { 5946 "converter": "TextDecorationSkip", 5947 "aliases": [ 5948 "-webkit-text-decoration-skip" 5949 ] 5936 5950 }, 5937 5951 "status": { -
trunk/Source/WebCore/css/StyleResolver.cpp
r238001 r238002 1172 1172 case CSSPropertyBoxShadow: 1173 1173 case CSSPropertyWebkitTextDecoration: 1174 case CSSProperty WebkitTextDecorationLine:1175 case CSSProperty WebkitTextDecorationStyle:1176 case CSSProperty WebkitTextDecorationColor:1177 case CSSProperty WebkitTextDecorationSkip:1174 case CSSPropertyTextDecorationLine: 1175 case CSSPropertyTextDecorationStyle: 1176 case CSSPropertyTextDecorationColor: 1177 case CSSPropertyTextDecorationSkip: 1178 1178 case CSSPropertyTextUnderlinePosition: 1179 1179 case CSSPropertyTextUnderlineOffset: … … 1464 1464 case CSSPropertyOutlineColor: 1465 1465 case CSSPropertyColumnRuleColor: 1466 case CSSProperty WebkitTextDecorationColor:1466 case CSSPropertyTextDecorationColor: 1467 1467 case CSSPropertyWebkitTextEmphasisColor: 1468 1468 case CSSPropertyWebkitTextFillColor: -
trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp
r237266 r238002 199 199 case CSSPropertyWebkitTextFillColor: 200 200 case CSSPropertyWebkitTextStrokeColor: 201 case CSSProperty WebkitTextDecorationColor:201 case CSSPropertyTextDecorationColor: 202 202 return true; 203 203 default: … … 646 646 // case CSSPropertyTextCombineUpright: 647 647 // return valueID == CSSValueNone || valueID == CSSValueAll; 648 case CSSProperty WebkitTextDecorationStyle:648 case CSSPropertyTextDecorationStyle: 649 649 // solid | double | dotted | dashed | wavy 650 650 return valueID == CSSValueSolid || valueID == CSSValueDouble || valueID == CSSValueDotted || valueID == CSSValueDashed || valueID == CSSValueWavy; … … 890 890 case CSSPropertyWebkitRubyPosition: 891 891 case CSSPropertyWebkitTextCombine: 892 case CSSProperty WebkitTextDecorationStyle:892 case CSSPropertyTextDecorationStyle: 893 893 case CSSPropertyWebkitTextOrientation: 894 894 case CSSPropertyWebkitTextSecurity: -
trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp
r238001 r238002 4069 4069 case CSSPropertyWidows: 4070 4070 return consumePositiveInteger(m_range); 4071 case CSSProperty WebkitTextDecorationColor:4071 case CSSPropertyTextDecorationColor: 4072 4072 return consumeColor(m_range, m_context.mode); 4073 case CSSProperty WebkitTextDecorationSkip:4073 case CSSPropertyTextDecorationSkip: 4074 4074 return consumeTextDecorationSkip(m_range); 4075 4075 case CSSPropertyWebkitTextStrokeWidth: … … 4136 4136 case CSSPropertyTextDecoration: 4137 4137 case CSSPropertyWebkitTextDecorationsInEffect: 4138 case CSSProperty WebkitTextDecorationLine:4138 case CSSPropertyTextDecorationLine: 4139 4139 return consumeTextDecorationLine(m_range); 4140 4140 case CSSPropertyWebkitTextEmphasisStyle: -
trunk/Source/WebCore/editing/cocoa/DataDetection.mm
r237266 r238002 617 617 618 618 anchorElement->setInlineStyleProperty(CSSPropertyColor, textColor.cssText()); 619 anchorElement->setInlineStyleProperty(CSSProperty WebkitTextDecorationColor, underlineColor.cssText());619 anchorElement->setInlineStyleProperty(CSSPropertyTextDecorationColor, underlineColor.cssText()); 620 620 } 621 621 } -
trunk/Source/WebCore/rendering/TextDecorationPainter.cpp
r237903 r238002 316 316 { 317 317 // Check for text decoration color first. 318 Color result = style.visitedDependentColorWithColorFilter(CSSProperty WebkitTextDecorationColor);318 Color result = style.visitedDependentColorWithColorFilter(CSSPropertyTextDecorationColor); 319 319 if (result.isValid()) 320 320 return result; -
trunk/Source/WebCore/rendering/style/RenderStyle.cpp
r237903 r238002 1848 1848 result = visitedLink ? visitedLinkColumnRuleColor() : columnRuleColor(); 1849 1849 break; 1850 case CSSProperty WebkitTextDecorationColor:1850 case CSSPropertyTextDecorationColor: 1851 1851 // Text decoration color fallback is handled in RenderObject::decorationColor. 1852 1852 return visitedLink ? visitedLinkTextDecorationColor() : textDecorationColor(); … … 1886 1886 1887 1887 // Text decoration color validity is preserved (checked in RenderObject::decorationColor). 1888 if (colorProperty == CSSProperty WebkitTextDecorationColor)1888 if (colorProperty == CSSPropertyTextDecorationColor) 1889 1889 return visitedColor; 1890 1890
Note: See TracChangeset
for help on using the changeset viewer.