Changeset 238157 in webkit


Ignore:
Timestamp:
Nov 13, 2018 7:42:44 PM (5 years ago)
Author:
Chris Dumez
Message:

Several Service Worker API tests are failing when enabling PSON
​https://bugs.webkit.org/show_bug.cgi?id=191619

Reviewed by Youenn Fablet.

Update tests to use _webProcessCountIgnoringPrewarmed instead of _webProcessCount so that they are
not impacted by process prewarming.

  • TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r238146 r238157  
     12018-11-13  Chris Dumez  <cdumez@apple.com>
     2
     3        Several Service Worker API tests are failing when enabling PSON
     4        https://bugs.webkit.org/show_bug.cgi?id=191619
     5
     6        Reviewed by Youenn Fablet.
     7
     8        Update tests to use _webProcessCountIgnoringPrewarmed instead of _webProcessCount so that they are
     9        not impacted by process prewarming.
     10
     11        * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
     12
    1132018-11-13  Wenson Hsieh  <wenson_hsieh@apple.com>
    214

  • trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm

    r237060 r238157  
    10411041
    10421042    webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:newConfiguration.get()]);
    1043     EXPECT_EQ(1u, webView.get().configuration.processPool._webProcessCount);
     1043    EXPECT_EQ(1u, webView.get().configuration.processPool._webProcessCountIgnoringPrewarmed);
    10441044    request = [NSURLRequest requestWithURL:[NSURL URLWithString:@"sw://host/regularPageWithConnection.html"]];
    10451045    [webView loadRequest:request];
    … …  
    10481048
    10491049    // Make sure that loading the simple page did not start the service worker process.
    1050     EXPECT_EQ(1u, webView.get().configuration.processPool._webProcessCount);
     1050    EXPECT_EQ(1u, webView.get().configuration.processPool._webProcessCountIgnoringPrewarmed);
    10511051
    10521052    webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:newConfiguration.get()]);
    1053     EXPECT_EQ(2u, webView.get().configuration.processPool._webProcessCount);
     1053    EXPECT_EQ(2u, webView.get().configuration.processPool._webProcessCountIgnoringPrewarmed);
    10541054    request = [NSURLRequest requestWithURL:[NSURL URLWithString:@"sw://host/main.html"]];
    10551055    [webView loadRequest:request];
    … …  
    10581058
    10591059    // Make sure that loading this page did start the service worker process.
    1060     EXPECT_EQ(3u, webView.get().configuration.processPool._webProcessCount);
     1060    EXPECT_EQ(3u, webView.get().configuration.processPool._webProcessCountIgnoringPrewarmed);
    10611061
    10621062    [[configuration websiteDataStore] removeDataOfTypes:[WKWebsiteDataStore allWebsiteDataTypes] modifiedSince:[NSDate distantPast] completionHandler:^() {
    … …  
    11351135
    11361136    webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:newConfiguration.get()]);
    1137     EXPECT_EQ(1u, webView.get().configuration.processPool._webProcessCount);
     1137    EXPECT_EQ(1u, webView.get().configuration.processPool._webProcessCountIgnoringPrewarmed);
    11381138    request = [NSURLRequest requestWithURL:[NSURL URLWithString:@"sw://host/regularPageWithConnection.html"]];
    11391139    [webView loadRequest:request];
    … …  
    11421142
    11431143    // Make sure that loading the simple page did not start the service worker process.
    1144     EXPECT_EQ(1u, webView.get().configuration.processPool._webProcessCount);
     1144    EXPECT_EQ(1u, webView.get().configuration.processPool._webProcessCountIgnoringPrewarmed);
    11451145
    11461146    [[configuration websiteDataStore] removeDataOfTypes:[WKWebsiteDataStore allWebsiteDataTypes] modifiedSince:[NSDate distantPast] completionHandler:^() {
Note: See TracChangeset for help on using the changeset viewer.