Changeset 238223 in webkit

Timestamp:

Nov 15, 2018, 5:57:50 AM (7 years ago)

Author:

Antti Koivisto

Message:

REGRESSION(r238178): fast/forms/access-key-mutated.html and fast/forms/access-key-case-insensitive.html are timing out
​https://bugs.webkit.org/show_bug.cgi?id=191642

Reviewed by Zalan Bujtas.

Source/WebCore:

Invalidate access key map even when thorttling style recalcs.

• dom/Document.cpp:

(WebCore::Document::scheduleStyleRecalc):

LayoutTests:

• TestExpectations: Unskip
• platform/mac-wk2/TestExpectations: Unskip
• platform/mac-wk2/accessibility/mac/selection-notification-focus-change-expected.txt:

Rebase. Focus timings depends on layout timings.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/TestExpectations (modified) (1 diff)
• LayoutTests/platform/mac-wk2/TestExpectations (modified) (1 diff)
• LayoutTests/platform/mac-wk2/accessibility/mac/selection-notification-focus-change-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/Document.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-11-15  Antti Koivisto  <antti@apple.com>
+
+        REGRESSION(r238178): fast/forms/access-key-mutated.html and fast/forms/access-key-case-insensitive.html are timing out
+        https://bugs.webkit.org/show_bug.cgi?id=191642
+
+        Reviewed by Zalan Bujtas.
+
+        * TestExpectations: Unskip
+        * platform/mac-wk2/TestExpectations: Unskip
+        * platform/mac-wk2/accessibility/mac/selection-notification-focus-change-expected.txt:
+
+        Rebase. Focus timings depends on layout timings.
+
 2018-11-15  Antti Koivisto  <antti@apple.com>
 

trunk/LayoutTests/TestExpectations

@@ -2951 +2951 @@
 fast/mediacapturefromelement/CanvasCaptureMediaStream-framerate-0.html [ Skip ]
 fast/mediacapturefromelement/CanvasCaptureMediaStream-capture-out-of-DOM-element.html [ Skip ]
-
-webkit.org/b/191642 fast/forms/access-key-case-insensitive.html [ Skip ]
-webkit.org/b/191642 fast/forms/access-key-mutated.html [ Skip ]

trunk/LayoutTests/platform/mac-wk2/TestExpectations

@@ -908 +908 @@
 webkit.org/b/191644 [ Sierra ] fast/workers/worker-cloneport.html [ Pass Failure ]
 
-webkit.org/b/191642 accessibility/mac/selection-notification-focus-change.html [ Skip ]
-
 webkit.org/b/191658 [ Sierra Release ] fast/layers/no-clipping-overflow-hidden-added-after-transform.html [ Pass ImageOnlyFailure ]

trunk/LayoutTests/platform/mac-wk2/accessibility/mac/selection-notification-focus-change-expected.txt

@@ -8 +8 @@
 Received AXSelectedTextChanged
 PASS userInfo["AXTextSelectionChangedFocus"] is true
+Received AXFocusChanged
 Received AXSelectedTextChanged
 PASS userInfo["AXTextSelectionChangedFocus"] is true
-Received AXFocusChanged
 
 PASS accessibilityController.accessibleElementById("1").isFocusable is true

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-11-15  Antti Koivisto  <antti@apple.com>
+
+        REGRESSION(r238178): fast/forms/access-key-mutated.html and fast/forms/access-key-case-insensitive.html are timing out
+        https://bugs.webkit.org/show_bug.cgi?id=191642
+
+        Reviewed by Zalan Bujtas.
+
+        Invalidate access key map even when thorttling style recalcs.
+
+        * dom/Document.cpp:
+        (WebCore::Document::scheduleStyleRecalc):
+
 2018-11-15  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -1805 +1805 @@
     ASSERT(childNeedsStyleRecalc() || m_pendingStyleRecalcShouldForce);
 
+    // FIXME: Why on earth is this here? This is clearly misplaced.
+    invalidateAccessKeyMap();
+
     auto shouldThrottleStyleRecalc = [&] {
         if (m_pendingStyleRecalcShouldForce)
@@ -1818 +1821 @@
         return;
 
-    // FIXME: Why on earth is this here? This is clearly misplaced.
-    invalidateAccessKeyMap();
-    
     m_styleRecalcTimer.startOneShot(0_s);