Changeset 238338 in webkit

Timestamp:

Nov 16, 2018, 7:06:38 PM (7 years ago)

Author:

Joseph Pecoraro

Message:

Unreviewed follow-up to r238330.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):
Don't clear the pointer after invalidating since the pointer is
used later one. We don't mind it being used after invalidation
it will do the right thing, we'd rather have the WebInspectorProxy
lifetime match the WebPageProxy.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebPageProxy.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-11-16  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Unreviewed follow-up to r238330.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::close):
+        Don't clear the pointer after invalidating since the pointer is
+        used later one. We don't mind it being used after invalidation
+        it will do the right thing, we'd rather have the WebInspectorProxy
+        lifetime match the WebPageProxy.
+
 2018-11-16  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/UIProcess/WebPageProxy.cpp

@@ -942 +942 @@
 
     m_inspector->invalidate();
-    m_inspector = nullptr;
 
     m_backForwardList->pageClosed();