Changeset 238392 in webkit

Timestamp:

Nov 20, 2018 12:15:41 AM (5 years ago)

Author:

Fujii Hironori

Message:

REGRESSION(r238039) WebCore::JSDOMGlobalObject::createStructure is using JSC::Structure::create without including StructureInlines.h
​https://bugs.webkit.org/show_bug.cgi?id=191626
<rdar://problem/46161064>

Unreviewed adding comment for my change r238366.

• runtime/Structure.h: Added a comment for Structure::create.

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/Structure.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2018-11-20  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        REGRESSION(r238039) WebCore::JSDOMGlobalObject::createStructure is using JSC::Structure::create without including StructureInlines.h
+        https://bugs.webkit.org/show_bug.cgi?id=191626
+        <rdar://problem/46161064>
+
+        Unreviewed adding comment for my change r238366.
+
+        * runtime/Structure.h: Added a comment for Structure::create.
+
 2018-11-19  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/JavaScriptCore/runtime/Structure.h

@@ -829 +829 @@
 };
 
+// We deliberately put Structure::create here in Structure.h instead of StructureInlines.h, because
+// it is used everywhere. This is so we don't have to hunt down all the places where we would need
+// to #include StructureInlines.h otherwise.
 inline Structure* Structure::create(VM& vm, JSGlobalObject* globalObject, JSValue prototype, const TypeInfo& typeInfo, const ClassInfo* classInfo, IndexingType indexingType, unsigned inlineCapacity)
 {