Changeset 238435 in webkit

Timestamp:

Nov 21, 2018 6:57:14 PM (5 years ago)

Author:

yusukesuzuki@slowstart.org

Message:

[JSC] Use ProtoCallFrame::numberOfRegisters instead of raw number 4
​https://bugs.webkit.org/show_bug.cgi?id=191877

Reviewed by Sam Weinig.

Instead of hard-coding 4 into LowLevelInterpreter, use ProtoCallFrame::numberOfRegisters.

• interpreter/ProtoCallFrame.h:
• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• interpreter/ProtoCallFrame.h (modified) (1 diff)
• llint/LowLevelInterpreter32_64.asm (modified) (1 diff)
• llint/LowLevelInterpreter64.asm (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2018-11-21  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
+
+        [JSC] Use ProtoCallFrame::numberOfRegisters instead of raw number `4`
+        https://bugs.webkit.org/show_bug.cgi?id=191877
+
+        Reviewed by Sam Weinig.
+
+        Instead of hard-coding `4` into LowLevelInterpreter, use ProtoCallFrame::numberOfRegisters.
+
+        * interpreter/ProtoCallFrame.h:
+        * llint/LowLevelInterpreter32_64.asm:
+        * llint/LowLevelInterpreter64.asm:
+
 2018-11-21  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/JavaScriptCore/interpreter/ProtoCallFrame.h

@@ -36 +36 @@
     WTF_FORBID_HEAP_ALLOCATION;
 public:
+    // CodeBlock, Callee, ArgumentCount, and |this|.
+    static constexpr unsigned numberOfRegisters { 4 };
+
     Register codeBlockValue;
     Register calleeValue;

trunk/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm

@@ -215 +215 @@
 .stackHeightOK:
     move t3, sp
-    move 4, t3
+    move (constexpr ProtoCallFrame::numberOfRegisters), t3
 
 .copyHeaderLoop:

trunk/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm

@@ -202 +202 @@
 .stackHeightOK:
     move t3, sp
-    move 4, t3
+    move (constexpr ProtoCallFrame::numberOfRegisters), t3
 
 .copyHeaderLoop: