Changeset 238447 in webkit


Ignore:
Timestamp:
Nov 22, 2018 10:11:39 AM (5 years ago)
Author:
Simon Fraser
Message:

Extremely small monospace text size when SVG is included as an img
​https://bugs.webkit.org/show_bug.cgi?id=191834

Reviewed by Myles C. Maxfield.
Source/WebCore:

Give defaultFixedFontSize a reasonable default value in Settings, so that clients
who omit to set it (like SVGImages) don't get broken rendering.

Test: svg/text/monospace-text-size-in-img.html

  • page/Settings.yaml:

LayoutTests:

The test has an x offset in the text transform to work around a different bug
with text position (webkit.org/b/191871).

  • svg/text/monospace-text-size-in-img-expected.html: Added.
  • svg/text/monospace-text-size-in-img.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r238441 r238447  
     12018-11-22  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Extremely small monospace text size when SVG is included as an img
     4        https://bugs.webkit.org/show_bug.cgi?id=191834
     5
     6        Reviewed by Myles C. Maxfield.
     7       
     8        The test has an x offset in the text transform to work around a different bug
     9        with text position (webkit.org/b/191871).
     10
     11        * svg/text/monospace-text-size-in-img-expected.html: Added.
     12        * svg/text/monospace-text-size-in-img.html: Added.
     13
    1142018-11-22  Javier Fernandez  <jfernandez@igalia.com>
    215

  • trunk/Source/WebCore/ChangeLog

    r238441 r238447  
     12018-11-22  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Extremely small monospace text size when SVG is included as an img
     4        https://bugs.webkit.org/show_bug.cgi?id=191834
     5
     6        Reviewed by Myles C. Maxfield.
     7
     8        Give defaultFixedFontSize a reasonable default value in Settings, so that clients
     9        who omit to set it (like SVGImages) don't get broken rendering.
     10
     11        Test: svg/text/monospace-text-size-in-img.html
     12
     13        * page/Settings.yaml:
     14
    1152018-11-22  Javier Fernandez  <jfernandez@igalia.com>
    216

  • trunk/Source/WebCore/page/Settings.yaml

    r238108 r238447  
    7575defaultFixedFontSize:
    7676  type: int
    77   initial: 0
     77  initial: 13
    7878  onChange: setNeedsRecalcStyleInAllFrames
    7979
Note: See TracChangeset for help on using the changeset viewer.