Changeset 238450 in webkit


Ignore:
Timestamp:
Nov 22, 2018 12:32:52 PM (5 years ago)
Author:
commit-queue@webkit.org
Message:

Improve fast/scrolling/scrolling-tree-includes-frame.html
​https://bugs.webkit.org/show_bug.cgi?id=191912

These are small improvements to scrolling-tree-includes-frame.html:

  • Run doTest() after the iframe is loaded and use waitUntilDone/notifyDone for more reliable timing.
  • Use iframe@srcdoc instead of iframe@src and put the content of the iframe document in its own line.
  • Move the iframe style in a separate <style> tag and ensure the iframe is really positioned at (0,0)

with no extra margin/padding/border.

  • Remove unnecessary id="frame"

The test expectation is not changed.

Patch by Frederic Wang <​fwang@igalia.com> on 2018-11-22
Reviewed by Antonio Gomes.

  • fast/scrolling/scrolling-tree-includes-frame.html:
Location:
trunk/LayoutTests
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r238448 r238450  
     12018-11-22  Frederic Wang  <fwang@igalia.com>
     2
     3        Improve fast/scrolling/scrolling-tree-includes-frame.html
     4        https://bugs.webkit.org/show_bug.cgi?id=191912
     5
     6        These are small improvements to scrolling-tree-includes-frame.html:
     7        - Run doTest() after the iframe is loaded and use waitUntilDone/notifyDone for more reliable timing.
     8        - Use iframe@srcdoc instead of iframe@src and put the content of the iframe document in its own line.
     9        - Move the iframe style in a separate <style> tag and ensure the iframe is really positioned at (0,0)
     10        with no extra margin/padding/border.
     11        - Remove unnecessary id="frame"
     12        The test expectation is not changed.
     13
     14        Reviewed by Antonio Gomes.
     15
     16        * fast/scrolling/scrolling-tree-includes-frame.html:
     17
    1182018-11-22  Zalan Bujtas  <zalan@apple.com>
    219

  • trunk/LayoutTests/fast/scrolling/scrolling-tree-includes-frame.html

    r218534 r238450  
    44    <title>Check whether scrollable iframes are included in the scrolling tree when async frame scrolling is enabled</title>
    55    <script>
    6       if (window.testRunner)
     6      if (window.testRunner) {
    77          testRunner.dumpAsText();
     8          testRunner.waitUntilDone();
     9      }
    810      if (window.internals)
    911          window.internals.settings.setAsyncFrameScrollingEnabled(true);
    … …  
    1214          if (window.internals)
    1315              document.getElementById('scrollingTree').innerText = window.internals.scrollingStateTreeAsText() + "\n";
     16          if (window.testRunner)
     17              testRunner.notifyDone();
    1418      }
    15       window.addEventListener('load', doTest, false);
    1619    </script>
     20    <style>
     21      iframe {
     22          position: absolute;
     23          left: 0;
     24          top: 0;
     25          width: 100px;
     26          height: 200px;
     27          margin: 0;
     28          border: 0;
     29          padding: 0;
     30      }
     31    </style>
    1732  </head>
    1833  <body>
    19     <iframe id="frame" style="width: 100px; height: 200px; border: 1px solid black;" src="data:text/html,<div style='width: 300px; height: 400px; background: gray;'></div>"></iframe>
     34    <iframe onload="doTest()" srcdoc="
     35        <div style='width: 300px; height: 400px; background: gray;'></div>">
     36    </iframe>
    2037    <pre id="scrollingTree"></pre>
    2138  </body>
Note: See TracChangeset for help on using the changeset viewer.