Changeset 238529 in webkit

Timestamp:

Nov 26, 2018 4:21:37 PM (5 years ago)

Author:

aakash_jain@apple.com

Message:

[ews-app] Add methods to save patch to database
​https://bugs.webkit.org/show_bug.cgi?id=191928

Reviewed by Lucas Forschler.

• BuildSlaveSupport/ews-app/ews/models/patch.py:

(Patch.save_patch): Method to save the patch to database.
(Patch.save_patches): Method to save multiple patches to database.
(Patch.is_valid_patch_id): Checks if the patch id is valid.
(Patch.is_existing_patch_id): Checks if the patch id already exists in database.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-app/ews/models/patch.py (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-app/ews/models/patch.py

@@ -23 +23 @@
 from __future__ import unicode_literals
 
+import logging
+
 from django.db import models
+
+from ews.config import *
+
+_log = logging.getLogger(__name__)
 
 
 class Patch(models.Model):
-    patchid = models.IntegerField(primary_key=True)
-    bugid = models.IntegerField()
+    patch_id = models.IntegerField(primary_key=True)
+    bug_id = models.IntegerField()
     obsolete = models.BooleanField(default=False)
     created = models.DateTimeField(auto_now_add=True)
@@ -34 +40 @@
 
     def __str__(self):
-        return str(self.patchid)
+        return str(self.patch_id)
+
+    @classmethod
+    def save_patch(cls, patch_id, bug_id=-1, obsolete=False):
+        if not Patch.is_valid_patch_id(patch_id):
+            return ERR_INVALID_PATCH_ID
+
+        if Patch.is_existing_patch_id(patch_id):
+            _log.info("Patch id {} already exists in database. Skipped saving.".format(patch_id))
+            return ERR_EXISTING_PATCH
+        Patch(patch_id, bug_id, obsolete).save()
+        _log.info('Saved patch in database, id: {}'.format(patch_id))
+        return SUCCESS
+
+    @classmethod
+    def save_patches(cls, patch_id_list):
+        for patch_id in patch_id_list:
+            Patch.save_patch(patch_id)
+
+    @classmethod
+    def is_valid_patch_id(cls, patch_id):
+        if not patch_id or type(patch_id) != int or patch_id < 1:
+            _log.warn('Invalid patch id: {}'.format(patch_id))
+            return False
+        return True
+
+    @classmethod
+    def is_existing_patch_id(cls, patch_id):
+        return bool(Patch.objects.filter(patch_id=patch_id))

trunk/Tools/ChangeLog

@@ +1 @@
+2018-11-26  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] Add methods to save patch to database
+        https://bugs.webkit.org/show_bug.cgi?id=191928
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-app/ews/models/patch.py:
+        (Patch.save_patch): Method to save the patch to database.
+        (Patch.save_patches): Method to save multiple patches to database.
+        (Patch.is_valid_patch_id): Checks if the patch id is valid.
+        (Patch.is_existing_patch_id): Checks if the patch id already exists in database.
+
 2018-11-26  Alex Christensen  <achristensen@webkit.org>