Changeset 238598 in webkit


Ignore:
Timestamp:
Nov 27, 2018 6:16:25 PM (5 years ago)
Author:
jiewen_tan@apple.com
Message:

Unreviewed, test gardening

Add a time out parameter to the following test cases such that WebAuthN requests will timeout
themselves instead of letting the wpt wrapper or test runner kill them.

  • http/wpt/webauthn/public-key-credential-create-success-hid.https.html:
  • http/wpt/webauthn/public-key-credential-get-success-hid.https.html:
  • platform/mac-wk2/TestExpectations:
Location:
trunk/LayoutTests
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r238592 r238598  
     12018-11-27  Jiewen Tan  <jiewen_tan@apple.com>
     2
     3        Unreviewed, test gardening
     4
     5        Add a time out parameter to the following test cases such that WebAuthN requests will timeout
     6        themselves instead of letting the wpt wrapper or test runner kill them.
     7
     8        * http/wpt/webauthn/public-key-credential-create-success-hid.https.html:
     9        * http/wpt/webauthn/public-key-credential-get-success-hid.https.html:
     10        * platform/mac-wk2/TestExpectations:
     11
    1122018-11-27  Chris Dumez  <cdumez@apple.com>
    213

  • trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-hid.https.html

    r238166 r238598  
    4848                challenge: Base64URL.parse("MTIzNDU2"),
    4949                pubKeyCredParams: [{ type: "public-key", alg: -7 }],
     50                timeout: 10
    5051            }
    5152        };
    … …  
    9192                challenge: Base64URL.parse("MTIzNDU2"),
    9293                pubKeyCredParams: [{ type: "public-key", alg: -7 }],
    93                 authenticatorSelection: { requireResidentKey: false }
     94                authenticatorSelection: { requireResidentKey: false },
     95                timeout: 10
    9496            }
    9597        };
    … …  
    113115                challenge: Base64URL.parse("MTIzNDU2"),
    114116                pubKeyCredParams: [{ type: "public-key", alg: -7 }],
    115                 authenticatorSelection: { userVerification: "preferred" }
     117                authenticatorSelection: { userVerification: "preferred" },
     118                timeout: 10
    116119            }
    117120        };
    … …  
    135138                challenge: Base64URL.parse("MTIzNDU2"),
    136139                pubKeyCredParams: [{ type: "public-key", alg: -7 }],
    137                 authenticatorSelection: { userVerification: "discouraged" }
     140                authenticatorSelection: { userVerification: "discouraged" },
     141                timeout: 10
    138142            }
    139143        };
    … …  
    157161                challenge: Base64URL.parse("MTIzNDU2"),
    158162                pubKeyCredParams: [{ type: "public-key", alg: -7 }],
    159                 authenticatorSelection: { authenticatorAttachment: "cross-platform", requireResidentKey: false, userVerification: "preferred" }
     163                authenticatorSelection: { authenticatorAttachment: "cross-platform", requireResidentKey: false, userVerification: "preferred" },
     164                timeout: 10
    160165            }
    161166        };

  • trunk/LayoutTests/http/wpt/webauthn/public-key-credential-get-success-hid.https.html

    r238238 r238598  
    2828        const options = {
    2929            publicKey: {
    30                 challenge: Base64URL.parse("MTIzNDU2")
     30                challenge: Base64URL.parse("MTIzNDU2"),
     31                timeout: 10
    3132            }
    3233        };
    … …  
    4344                allowCredentials: [
    4445                    { type: "public-key", id: Base64URL.parse(testHidCredentialIdBase64), transports: ["usb"] }
    45                 ]
     46                ],
     47                timeout: 10
    4648            }
    4749        };
    … …  
    5658            publicKey: {
    5759                challenge: Base64URL.parse("MTIzNDU2"),
    58                 userVerification: "preferred"
     60                userVerification: "preferred",
     61                timeout: 10
    5962            }
    6063        };
    … …  
    6972            publicKey: {
    7073                challenge: Base64URL.parse("MTIzNDU2"),
    71                 userVerification: "discouraged"
     74                userVerification: "discouraged",
     75                timeout: 10
    7276            }
    7377        };
    … …  
    8589                    { type: "public-key", id: Base64URL.parse(testHidCredentialIdBase64), transports: ["usb"] }
    8690                ],
    87                 userVerification: "preferred"
     91                userVerification: "preferred",
     92                timeout: 10
    8893            }
    8994        };

  • trunk/LayoutTests/platform/mac-wk2/TestExpectations

    r238545 r238598  
    907907http/wpt/credential-management/credentialscontainer-store-basics.https.html [ Skip ]
    908908http/wpt/webauthn/idl.https.html [ Skip ]
    909 # Slow WebAuthN tests.
    910 http/wpt/webauthn/public-key-credential-get-success-hid.https.html [ Slow ]
    911909
    912910webkit.org/b/183878 media/modern-media-controls/tracks-panel/tracks-panel-up-click-over-media-does-not-dimiss-media-controls-when-media-is-playing.html [ Pass Timeout ]
Note: See TracChangeset for help on using the changeset viewer.