Changeset 238601 in webkit

Timestamp:

Nov 27, 2018 8:48:30 PM (5 years ago)

Author:

youenn@apple.com

Message:

Log WebRTC stats in inspector console only when setting is verbose
​https://bugs.webkit.org/show_bug.cgi?id=192014

Reviewed by Eric Carlson.

Add a WebRTCStats channel that is used by default to output WebRTC stats in console.
When WebRTC Debug logging is enabled, log WebRTC stats in WebRTC channel,
so that they appear as debug information in Web Inspector.

No change of JS behavior.
Covered by manually testing what is logged in inspector and console.

• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::OnStatsDelivered):

• platform/Logging.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp (modified) (1 diff)
• platform/Logging.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-11-27  Youenn Fablet  <youenn@apple.com>
+
+        Log WebRTC stats in inspector console only when setting is verbose
+        https://bugs.webkit.org/show_bug.cgi?id=192014
+
+        Reviewed by Eric Carlson.
+
+        Add a WebRTCStats channel that is used by default to output WebRTC stats in console.
+        When WebRTC Debug logging is enabled, log WebRTC stats in WebRTC channel,
+        so that they appear as debug information in Web Inspector.
+
+        No change of JS behavior.
+        Covered by manually testing what is logged in inspector and console.
+
+        * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
+        (WebCore::LibWebRTCMediaEndpoint::OnStatsDelivered):
+        * platform/Logging.h:
+
 2018-11-27  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp

@@ -855 +855 @@
         }
 
-        for (auto iterator = report->begin(); iterator != report->end(); ++iterator)
-            ALWAYS_LOG(Logger::LogSiteIdentifier("LibWebRTCMediaEndpoint", "OnStatsDelivered", logIdentifier()), RTCStatsLogger { *iterator });
+        for (auto iterator = report->begin(); iterator != report->end(); ++iterator) {
+            if (logger().willLog(logChannel(), WTFLogLevelDebug)) {
+                // Stats are very verbose, let's only display them in inspector console in verbose mode.
+                logger().debug(LogWebRTC,
+                    Logger::LogSiteIdentifier("LibWebRTCMediaEndpoint", "OnStatsDelivered", logIdentifier()),
+                    RTCStatsLogger { *iterator });
+            } else {
+                logger().logAlways(LogWebRTCStats,
+                    Logger::LogSiteIdentifier("LibWebRTCMediaEndpoint", "OnStatsDelivered", logIdentifier()),
+                    RTCStatsLogger { *iterator });
+            }
+        }
     });
 #else

trunk/Source/WebCore/platform/Logging.h

@@ -104 +104 @@
     M(WebMetal) \
     M(WebRTC) \
+    M(WebRTCStats) \
     M(WheelEventTestTriggers) \