Changeset 238612 in webkit
- Timestamp:
- Nov 28, 2018 8:50:40 AM (5 years ago)
- Location:
- trunk/Source/JavaScriptCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/JavaScriptCore/ChangeLog
r238597 r238612 1 2018-11-28 Keith Rollin <krollin@apple.com> 2 3 Remove Postprocess Headers dependencies 4 https://bugs.webkit.org/show_bug.cgi?id=192023 5 <rdar://problem/46283377> 6 7 Reviewed by Mark Lam. 8 9 JavaScriptCore's Xcode Postprocess Headers build phase used to have a 10 dependency on a specific handful of files. In r234227, the script used 11 in this phase (postprocess-headers.sh) was completely rewritten to 12 operate on *all* files in JSC's Public and Private headers directories 13 instead of just this handful. This rewrite makes the previous 14 dependency specification insufficient, leading to incorrect 15 incremental builds if the right files weren't touched. Address this by 16 removing the dependencies completely. This will cause 17 postprocess-headers.sh to always be executed, even when none of its 18 files are touch. Running this script all the time is OK, since it has 19 built-in protections against unnecessarily touching files that haven't 20 changed. 21 22 * JavaScriptCore.xcodeproj/project.pbxproj: 23 1 24 2018-11-27 Mark Lam <mark.lam@apple.com> 2 25 -
trunk/Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
r238439 r238612 10125 10125 ); 10126 10126 inputPaths = ( 10127 "$(TARGET_BUILD_DIR)/$(PUBLIC_HEADERS_FOLDER_PATH)/JSBase.h",10128 "$(TARGET_BUILD_DIR)/$(PUBLIC_HEADERS_FOLDER_PATH)/JSContext.h",10129 "$(TARGET_BUILD_DIR)/$(PUBLIC_HEADERS_FOLDER_PATH)/JSManagedValue.h",10130 "$(TARGET_BUILD_DIR)/$(PUBLIC_HEADERS_FOLDER_PATH)/JSValue.h",10131 "$(TARGET_BUILD_DIR)/$(PUBLIC_HEADERS_FOLDER_PATH)/JSVirtualMachine.h",10132 "$(TARGET_BUILD_DIR)/$(PUBLIC_HEADERS_FOLDER_PATH)/WebKitAvailability.h",10133 10127 ); 10134 10128 name = "Postprocess Headers";
Note: See TracChangeset
for help on using the changeset viewer.