Changeset 238784 in webkit


Ignore:
Timestamp:
Dec 1, 2018 1:09:08 PM (5 years ago)
Author:
Jonathan Bedard
Message:

Unreviewed, rolling out r238764.

Breaks existing layout tests

Reverted changeset:

"webkitpy: Support unicode in MeteredStream"
​https://bugs.webkit.org/show_bug.cgi?id=192260
​https://trac.webkit.org/changeset/238764

Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r238779 r238784  
     12018-12-01  Jonathan Bedard  <jbedard@apple.com>
     2
     3        Unreviewed, rolling out r238764.
     4
     5        Breaks existing layout tests
     6
     7        Reverted changeset:
     8
     9        "webkitpy: Support unicode in MeteredStream"
     10        https://bugs.webkit.org/show_bug.cgi?id=192260
     11        https://trac.webkit.org/changeset/238764
     12
    1132018-12-01  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
    214

  • trunk/Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py

    r238764 r238784  
    106106
    107107        if self._isatty and not self._verbose:
    108             msg = u'{}{}'.format(timestamp_string, txt)
     108            msg = '{}{}'.format(timestamp_string, txt)
    109109        else:
    110             msg = u'{}{}'.format(timestamp_string, self._ensure_newline(txt))
     110            msg = '{}{}'.format(timestamp_string, self._ensure_newline(txt))
    111111
    112112        self._stream.write(msg)

  • trunk/Tools/Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py

    r238764 r238784  
    109109        self.assertEqual(self.buflist, ['foo bar 2\n'])
    110110
    111     def test_unicode(self):
    112         self.logger.info(u'\u2713')
    113         self.assertEqual(self.buflist[-1][-2:], u'\u2713\n')
    114 
    115111
    116112class TtyTest(RegularTest):
Note: See TracChangeset for help on using the changeset viewer.