Changeset 238791 in webkit
- Timestamp:
- Dec 2, 2018 7:24:42 PM (5 years ago)
- Location:
- trunk
- Files:
-
- 19 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/JavaScriptCore/ChangeLog
r238790 r238791 1 2018-12-02 Zalan Bujtas <zalan@apple.com> 2 3 Add a runtime feature flag for LayoutFormattingContext. 4 https://bugs.webkit.org/show_bug.cgi?id=192280 5 6 Reviewed by Simon Fraser. 7 8 * Configurations/FeatureDefines.xcconfig: 9 1 10 2018-12-02 Caio Lima <ticaiolima@gmail.com> 2 11 -
trunk/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig
r238754 r238791 229 229 ENABLE_KEYBOARD_KEY_ATTRIBUTE = ENABLE_KEYBOARD_KEY_ATTRIBUTE; 230 230 231 ENABLE_LAYOUT_FORMATTING_CONTEXT = ;231 ENABLE_LAYOUT_FORMATTING_CONTEXT = ENABLE_LAYOUT_FORMATTING_CONTEXT; 232 232 233 233 ENABLE_LEGACY_CSS_VENDOR_PREFIXES = ENABLE_LEGACY_CSS_VENDOR_PREFIXES; -
trunk/Source/WebCore/ChangeLog
r238788 r238791 1 2018-12-02 Zalan Bujtas <zalan@apple.com> 2 3 Add a runtime feature flag for LayoutFormattingContext. 4 https://bugs.webkit.org/show_bug.cgi?id=192280 5 6 Reviewed by Simon Fraser. 7 8 * Configurations/FeatureDefines.xcconfig: 9 * page/FrameViewLayoutContext.cpp: 10 (WebCore::layoutUsingFormattingContext): 11 * page/RuntimeEnabledFeatures.h: 12 (WebCore::RuntimeEnabledFeatures::setLayoutFormattingContextEnabled): 13 (WebCore::RuntimeEnabledFeatures::layoutFormattingContextEnabled const): 14 1 15 2018-12-01 Brent Fulgham <bfulgham@apple.com> 2 16 -
trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig
r238754 r238791 229 229 ENABLE_KEYBOARD_KEY_ATTRIBUTE = ENABLE_KEYBOARD_KEY_ATTRIBUTE; 230 230 231 ENABLE_LAYOUT_FORMATTING_CONTEXT = ;231 ENABLE_LAYOUT_FORMATTING_CONTEXT = ENABLE_LAYOUT_FORMATTING_CONTEXT; 232 232 233 233 ENABLE_LEGACY_CSS_VENDOR_PREFIXES = ENABLE_LEGACY_CSS_VENDOR_PREFIXES; -
trunk/Source/WebCore/PAL/ChangeLog
r238785 r238791 1 2018-12-02 Zalan Bujtas <zalan@apple.com> 2 3 Add a runtime feature flag for LayoutFormattingContext. 4 https://bugs.webkit.org/show_bug.cgi?id=192280 5 6 Reviewed by Simon Fraser. 7 8 * Configurations/FeatureDefines.xcconfig: 9 1 10 2018-12-01 Alexey Proskuryakov <ap@apple.com> 2 11 -
trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig
r238754 r238791 229 229 ENABLE_KEYBOARD_KEY_ATTRIBUTE = ENABLE_KEYBOARD_KEY_ATTRIBUTE; 230 230 231 ENABLE_LAYOUT_FORMATTING_CONTEXT = ;231 ENABLE_LAYOUT_FORMATTING_CONTEXT = ENABLE_LAYOUT_FORMATTING_CONTEXT; 232 232 233 233 ENABLE_LEGACY_CSS_VENDOR_PREFIXES = ENABLE_LEGACY_CSS_VENDOR_PREFIXES; -
trunk/Source/WebCore/layout/LayoutUnits.h
r238613 r238791 31 31 #include "LayoutPoint.h" 32 32 #include "LayoutRect.h" 33 #include <wtf/Optional.h> 33 34 34 35 namespace WebCore { -
trunk/Source/WebCore/layout/Verification.cpp
r238460 r238791 47 47 return true; 48 48 49 return ::abs(a - b.toFloat()) <= 4 * LayoutUnit::epsilon();49 return fabs(a - b.toFloat()) <= 4 * LayoutUnit::epsilon(); 50 50 } 51 51 -
trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp
r238479 r238791 182 182 auto startPosition = from; 183 183 auto iterator = inlineContent.find(const_cast<InlineItem*>(&inlineItem)); 184 #if !ASSERT_DISABLED 184 185 auto inlineItemEnd = inlineContent.end(); 186 #endif 185 187 while (length) { 186 188 ASSERT(iterator != inlineItemEnd); -
trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp
r238479 r238791 163 163 LayoutUnit width; 164 164 auto iterator = m_inlineContent.find(const_cast<InlineItem*>(&inlineItem)); 165 #if !ASSERT_DISABLED 165 166 auto inlineItemEnd = m_inlineContent.end(); 167 #endif 166 168 while (length) { 167 169 ASSERT(iterator != inlineItemEnd); -
trunk/Source/WebCore/page/FrameViewLayoutContext.cpp
r238431 r238791 37 37 #include "RenderElement.h" 38 38 #include "RenderView.h" 39 #include "RuntimeEnabledFeatures.h" 39 40 #include "ScriptDisallowedScope.h" 40 41 #include "Settings.h" … … 56 57 static void layoutUsingFormattingContext(const RenderView& renderView) 57 58 { 59 if (!RuntimeEnabledFeatures::sharedFeatures().layoutFormattingContextEnabled()) 60 return; 58 61 auto initialContainingBlock = Layout::TreeBuilder::createLayoutTree(renderView); 59 62 auto layoutState = std::make_unique<Layout::LayoutState>(*initialContainingBlock, renderView.size()); … … 209 212 layoutRoot->layout(); 210 213 #if ENABLE(LAYOUT_FORMATTING_CONTEXT) 211 layoutUsingFormattingContext(*renderView());214 layoutUsingFormattingContext(*renderView()); 212 215 #endif 213 216 ++m_layoutCount; -
trunk/Source/WebCore/page/RuntimeEnabledFeatures.h
r238262 r238791 178 178 void setPointerEventsEnabled(bool isEnabled) { m_pointerEventsEnabled = isEnabled; } 179 179 bool pointerEventsEnabled() const { return m_pointerEventsEnabled; } 180 181 #if ENABLE(LAYOUT_FORMATTING_CONTEXT) 182 void setLayoutFormattingContextEnabled(bool isEnabled) { m_layoutFormattingContextEnabled = isEnabled; } 183 bool layoutFormattingContextEnabled() const { return m_layoutFormattingContextEnabled; } 184 #endif 180 185 181 186 #if ENABLE(CSS_PAINTING_API) … … 373 378 bool m_webSQLEnabled { true }; 374 379 380 #if ENABLE(LAYOUT_FORMATTING_CONTEXT) 381 bool m_layoutFormattingContextEnabled { false }; 382 #endif 383 375 384 #if ENABLE(CSS_PAINTING_API) 376 385 bool m_CSSPaintingAPIEnabled { false }; -
trunk/Source/WebKit/ChangeLog
r238787 r238791 1 2018-12-02 Zalan Bujtas <zalan@apple.com> 2 3 Add a runtime feature flag for LayoutFormattingContext. 4 https://bugs.webkit.org/show_bug.cgi?id=192280 5 6 Reviewed by Simon Fraser. 7 8 * Configurations/FeatureDefines.xcconfig: 9 * Shared/WebPreferences.yaml: 10 * WebProcess/InjectedBundle/InjectedBundle.cpp: 11 (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): 12 1 13 2018-12-01 Chris Dumez <cdumez@apple.com> 2 14 -
trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig
r238754 r238791 229 229 ENABLE_KEYBOARD_KEY_ATTRIBUTE = ENABLE_KEYBOARD_KEY_ATTRIBUTE; 230 230 231 ENABLE_LAYOUT_FORMATTING_CONTEXT = ;231 ENABLE_LAYOUT_FORMATTING_CONTEXT = ENABLE_LAYOUT_FORMATTING_CONTEXT; 232 232 233 233 ENABLE_LEGACY_CSS_VENDOR_PREFIXES = ENABLE_LEGACY_CSS_VENDOR_PREFIXES; -
trunk/Source/WebKit/Shared/WebPreferences.yaml
r238715 r238791 1465 1465 webcoreBinding: RuntimeEnabledFeatures 1466 1466 condition: ENABLE(DATALIST_ELEMENT) 1467 1468 LayoutFormattingContextEnabled: 1469 type: bool 1470 defaultValue: false 1471 humanReadableName: "Next-gen layout" 1472 humanReadableDescription: "Enable next-gen layout" 1473 category: internal 1474 webcoreBinding: RuntimeEnabledFeatures 1475 condition: ENABLE(LAYOUT_FORMATTING_CONTEXT) 1476 -
trunk/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp
r237905 r238791 257 257 RuntimeEnabledFeatures::sharedFeatures().setCSSCustomPropertiesAndValuesEnabled(enabled); 258 258 259 #if ENABLE(LAYOUT_FORMATTING_CONTEXT) 260 if (preference == "LayoutFormattingContextEnabled") 261 RuntimeEnabledFeatures::sharedFeatures().setLayoutFormattingContextEnabled(enabled); 262 #endif 263 259 264 #if ENABLE(CSS_PAINTING_API) 260 265 if (preference == "CSSPaintingAPIEnabled") -
trunk/Source/WebKitLegacy/mac/ChangeLog
r238771 r238791 1 2018-12-02 Zalan Bujtas <zalan@apple.com> 2 3 Add a runtime feature flag for LayoutFormattingContext. 4 https://bugs.webkit.org/show_bug.cgi?id=192280 5 6 Reviewed by Simon Fraser. 7 8 * Configurations/FeatureDefines.xcconfig: 9 1 10 2018-11-30 Alex Christensen <achristensen@webkit.org> 2 11 -
trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig
r238754 r238791 229 229 ENABLE_KEYBOARD_KEY_ATTRIBUTE = ENABLE_KEYBOARD_KEY_ATTRIBUTE; 230 230 231 ENABLE_LAYOUT_FORMATTING_CONTEXT = ;231 ENABLE_LAYOUT_FORMATTING_CONTEXT = ENABLE_LAYOUT_FORMATTING_CONTEXT; 232 232 233 233 ENABLE_LEGACY_CSS_VENDOR_PREFIXES = ENABLE_LEGACY_CSS_VENDOR_PREFIXES; -
trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig
r238754 r238791 229 229 ENABLE_KEYBOARD_KEY_ATTRIBUTE = ENABLE_KEYBOARD_KEY_ATTRIBUTE; 230 230 231 ENABLE_LAYOUT_FORMATTING_CONTEXT = ;231 ENABLE_LAYOUT_FORMATTING_CONTEXT = ENABLE_LAYOUT_FORMATTING_CONTEXT; 232 232 233 233 ENABLE_LEGACY_CSS_VENDOR_PREFIXES = ENABLE_LEGACY_CSS_VENDOR_PREFIXES;
Note: See TracChangeset
for help on using the changeset viewer.