Changeset 238864 in webkit
- Timestamp:
- Dec 4, 2018 11:07:57 AM (5 years ago)
- Location:
- trunk/Source/WebInspectorUI
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebInspectorUI/ChangeLog
r238859 r238864 1 2018-12-04 Joseph Pecoraro <pecoraro@apple.com> 2 3 Web Inspector: REGRESSION(r238330): Timeline auto-capture does not work after page transition 4 https://bugs.webkit.org/show_bug.cgi?id=192248 5 <rdar://problem/46390199> 6 7 Reviewed by Devin Rousso. 8 9 * UserInterface/Base/Main.js: 10 (WI.transitionPageTarget): 11 Let the TimelineManager perform work on page transitions. 12 13 * UserInterface/Controllers/TimelineManager.js: 14 (WI.TimelineManager.prototype.initializeTarget): 15 Initialize the autocapture state of the target. 16 17 (WI.TimelineManager.prototype.transitionPageTarget): 18 When transitioning pages perform a legacy (frontend based) timeline capture. 19 1 20 2018-12-04 Matt Baker <mattbaker@apple.com> 2 21 -
trunk/Source/WebInspectorUI/UserInterface/Base/Main.js
r238660 r238864 215 215 WI.domManager.transitionPageTarget(); 216 216 WI.networkManager.transitionPageTarget(); 217 WI.timelineManager.transitionPageTarget(); 217 218 }; 218 219 -
trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js
r238484 r238864 50 50 this._mainResourceForAutoCapturing = null; 51 51 this._shouldSetAutoCapturingMainResource = false; 52 this._transitioningPageTarget = false; 52 53 this._boundStopCapturing = this.stopCapturing.bind(this); 53 54 … … 66 67 initializeTarget(target) 67 68 { 68 this._updateAutoCaptureInstruments([target]); 69 if (target.TimelineAgent) { 70 this._updateAutoCaptureInstruments([target]); 71 72 // COMPATIBILITY (iOS 9): Timeline.setAutoCaptureEnabled did not exist. 73 if (target.TimelineAgent.setAutoCaptureEnabled) 74 target.TimelineAgent.setAutoCaptureEnabled(this._autoCaptureOnPageLoad); 75 } 76 } 77 78 transitionPageTarget() 79 { 80 this._transitioningPageTarget = true; 69 81 } 70 82 … … 831 843 832 844 let frame = event.target; 845 846 // When performing a page transition start a recording once the main resource changes. 847 // We start a legacy capture because the backend wasn't available to automatically 848 // initiate the capture, so the frontend must start the capture. 849 if (this._transitioningPageTarget) { 850 this._transitioningPageTarget = false; 851 if (this._autoCaptureOnPageLoad) 852 this._legacyAttemptStartAutoCapturingForFrame(frame); 853 return; 854 } 855 833 856 if (this._attemptAutoCapturingForFrame(frame)) 834 857 return;
Note: See TracChangeset
for help on using the changeset viewer.