Changeset 238871 in webkit

Timestamp:

Dec 4, 2018 12:07:09 PM (5 years ago)

Author:

Matt Baker

Message:

Web Inspector: REGRESSION(r238602): Elements: changing selection no longer highlights the selected node
​https://bugs.webkit.org/show_bug.cgi?id=192354
<rdar://problem/46444438>

Reviewed by Joseph Pecoraro.

• UserInterface/Views/TreeOutline.js:

(WI.TreeOutline.prototype._treeKeyDown):
(WI.TreeOutline.prototype._handleMouseDown):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/TreeOutline.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2018-12-04  Matt Baker  <mattbaker@apple.com>
+
+        Web Inspector: REGRESSION(r238602): Elements: changing selection no longer highlights the selected node
+        https://bugs.webkit.org/show_bug.cgi?id=192354
+        <rdar://problem/46444438>
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/TreeOutline.js:
+        (WI.TreeOutline.prototype._treeKeyDown):
+        (WI.TreeOutline.prototype._handleMouseDown):
+
 2018-12-04  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js

@@ -610 +610 @@
         }
 
-        if (!handled)
+        if (!handled) {
+            this._itemWasSelectedByUser = true;
             handled = this._selectionController.handleKeyDown(event);
+            this._itemWasSelectedByUser = false;
+        }
 
         if (nextSelectedElement) {
@@ -1001 +1004 @@
             return;
 
+        this._itemWasSelectedByUser = true;
         this._selectionController.handleItemMouseDown(index, event);
+        this._itemWasSelectedByUser = false;
     }