Changeset 238919 in webkit

Timestamp:

Dec 5, 2018 6:28:23 PM (5 years ago)

Author:

jiewen_tan@apple.com

Message:

[Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
​https://bugs.webkit.org/show_bug.cgi?id=192061

Reviewed by Dewei Zhu.

Part 1.

Add some loggings to determine possible causes for the flakiness.

• UIProcess/WebAuthentication/Cocoa/HidService.mm:

(WebKit::HidService::continueAddDeviceAfterGetInfo):

• UIProcess/WebAuthentication/Mock/MockHidService.cpp:

(WebKit::MockHidService::platformStartDiscovery):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebAuthentication/Cocoa/HidService.mm (modified) (1 diff)
• UIProcess/WebAuthentication/Mock/MockHidService.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-12-05  Jiewen Tan  <jiewen_tan@apple.com>
+
+        [Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
+        https://bugs.webkit.org/show_bug.cgi?id=192061
+
+        Reviewed by Dewei Zhu.
+
+        Part 1.
+
+        Add some loggings to determine possible causes for the flakiness.
+
+        * UIProcess/WebAuthentication/Cocoa/HidService.mm:
+        (WebKit::HidService::continueAddDeviceAfterGetInfo):
+        * UIProcess/WebAuthentication/Mock/MockHidService.cpp:
+        (WebKit::MockHidService::platformStartDiscovery):
+
 2018-12-05  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidService.mm

@@ -116 +116 @@
     }
     // FIXME(191535): Support U2F authenticators.
+    LOG_ERROR("Couldn't parse a ctap get info response.");
 }
 

trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidService.cpp

@@ -44 +44 @@
     if (!!m_configuration.hid)
         deviceAdded(nullptr);
+    LOG_ERROR("No hid authenticators is available.");
 }