Changeset 238938 in webkit

Timestamp:

Dec 6, 2018 12:37:55 PM (5 years ago)

Author:

Matt Baker

Message:

Web Inspector: REGRESSION(r238602): Elements: collapsing a DOM node with the left arrow doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=192353
<rdar://problem/46455019>

Reviewed by Devin Rousso.

• UserInterface/Views/TreeElement.js:

(WI.TreeElement.prototype.deselect):
Don't early return when the element is not the selected tree element.
This condition no longer holds now that TreeOutline supports multiple selection.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/TreeElement.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2018-12-06  Matt Baker  <mattbaker@apple.com>
+
+        Web Inspector: REGRESSION(r238602): Elements: collapsing a DOM node with the left arrow doesn't work
+        https://bugs.webkit.org/show_bug.cgi?id=192353
+        <rdar://problem/46455019>
+
+        Reviewed by Devin Rousso.
+
+        * UserInterface/Views/TreeElement.js:
+        (WI.TreeElement.prototype.deselect):
+        Don't early return when the element is not the selected tree element.
+        This condition no longer holds now that TreeOutline supports multiple selection.
+
 2018-12-05  Matt Baker  <mattbaker@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/TreeElement.js

@@ -533 +533 @@
     deselect(suppressNotification)
     {
-        if (!this.treeOutline || this.treeOutline.selectedTreeElement !== this || !this.selected)
+        if (!this.treeOutline || !this.selected)
             return false;
+
+        console.assert(this.treeOutline.selectedTreeElements.includes(this));
 
         this.selected = false;