Changeset 239059 in webkit

Timestamp:

Dec 10, 2018 4:32:38 PM (5 years ago)

Author:

timothy_horton@apple.com

Message:

Animated scrolling on Google Maps scrolls the page in addition to moving the map
​https://bugs.webkit.org/show_bug.cgi?id=192521
<rdar://problem/46382007>

Reviewed by Sam Weinig.

• Platform/spi/ios/UIKitSPI.h:
• UIProcess/ios/WKKeyboardScrollingAnimator.mm:

(-[WKKeyboardScrollViewAnimator rubberbandableDirections]):
Only do keyboard-based rubber-banding in directions that we can actually
scroll, not directions we can only finger-rubber-band in. This effectively
means keyboard scrolling will ignore "alwaysBounce{Vertical, Horizontal}".

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Platform/spi/ios/UIKitSPI.h (modified) (1 diff)
• UIProcess/ios/WKKeyboardScrollingAnimator.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-12-10  Tim Horton  <timothy_horton@apple.com>
+
+        Animated scrolling on Google Maps scrolls the page in addition to moving the map
+        https://bugs.webkit.org/show_bug.cgi?id=192521
+        <rdar://problem/46382007>
+
+        Reviewed by Sam Weinig.
+
+        * Platform/spi/ios/UIKitSPI.h:
+        * UIProcess/ios/WKKeyboardScrollingAnimator.mm:
+        (-[WKKeyboardScrollViewAnimator rubberbandableDirections]):
+        Only do keyboard-based rubber-banding in directions that we can actually
+        scroll, not directions we can only finger-rubber-band in. This effectively
+        means keyboard scrolling will ignore "alwaysBounce{Vertical, Horizontal}".
+
 2018-12-10  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h

@@ -1055 +1055 @@
 - (BOOL)_isScrollingToTop;
 - (CGPoint)_animatedTargetOffset;
-- (BOOL)_canScrollX;
-- (BOOL)_canScrollY;
+- (BOOL)_canScrollWithoutBouncingX;
+- (BOOL)_canScrollWithoutBouncingY;
 - (void)_setContentOffsetWithDecelerationAnimation:(CGPoint)contentOffset;
 - (CGPoint)_adjustedContentOffsetForContentOffset:(CGPoint)contentOffset;

trunk/Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm

@@ -679 +679 @@
     WebCore::RectEdges<bool> edges;
 
-    edges.setTop(scrollView._canScrollY);
+    edges.setTop(scrollView._canScrollWithoutBouncingY);
     edges.setBottom(edges.top());
-    edges.setLeft(scrollView._canScrollX);
+    edges.setLeft(scrollView._canScrollWithoutBouncingX);
     edges.setRight(edges.left());