Changeset 239151 in webkit


Ignore:
Timestamp:
Dec 12, 2018 10:44:39 PM (5 years ago)
Author:
Fujii Hironori
Message:

[Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
https://bugs.webkit.org/show_bug.cgi?id=192618

Reviewed by Alex Christensen.

Source/WebCore:

No new tests, no behavior changes.

  • platform/win/PopupMenuWin.h:
  • platform/win/WCDataObject.cpp:
  • platform/win/WCDataObject.h:

Source/WebKitLegacy/win:

Classes which implement COM interface usually doesn't need the
virtual destructor because it has Release() virtual method to
destruct itself.

Marked 'final' such classes to suppress clang-cl's compilation
warnings.

  • COMEnumVariant.h:
  • COMPropertyBag.h:
  • DefaultDownloadDelegate.h:
  • DefaultPolicyDelegate.h:
  • MemoryStream.h:
  • WebActionPropertyBag.h:
  • WebApplicationCache.h:
  • WebArchive.h:
  • WebBackForwardList.h:
  • WebCache.h:
  • WebCoreStatistics.h:
  • WebCoreSupport/WebEditorClient.cpp:
  • WebCoreSupport/WebInspectorDelegate.h:
  • WebDataSource.h:
  • WebDatabaseManager.cpp:
  • WebDatabaseManager.h:
  • WebDownload.h:
  • WebDropSource.h:
  • WebElementPropertyBag.h:
  • WebError.h:
  • WebFrame.cpp:
  • WebFrame.h:
  • WebFramePolicyListener.h:
  • WebGeolocationPolicyListener.h:
  • WebGeolocationPosition.h:
  • WebHTMLRepresentation.h:
  • WebHistory.h:
  • WebHistoryItem.h:
  • WebInspector.h:
  • WebJavaScriptCollector.h:
  • WebKitClassFactory.h:
  • WebKitMessageLoop.h:
  • WebKitStatistics.h:
  • WebMutableURLRequest.h:
  • WebNavigationData.h:
  • WebNotification.h:
  • WebNotificationCenter.h:
  • WebPreferences.h:
  • WebResource.h:
  • WebScriptWorld.h:
  • WebSecurityOrigin.h:
  • WebSerializedJSValue.h:
  • WebTextRenderer.h:
  • WebURLAuthenticationChallenge.h:
  • WebURLAuthenticationChallengeSender.h:
  • WebURLCredential.h:
  • WebURLProtectionSpace.h:
  • WebURLResponse.h:
  • WebUserContentURLPattern.h:
  • WebView.cpp:
  • WebView.h:
  • WebWorkersPrivate.h:

Tools:

  • DumpRenderTree/win/DRTDataObject.cpp:
  • DumpRenderTree/win/DRTDataObject.h:
  • DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
  • DumpRenderTree/win/DRTDropSource.h:
  • DumpRenderTree/win/EditingDelegate.h:
  • DumpRenderTree/win/PolicyDelegate.h:
  • DumpRenderTree/win/UIDelegate.h:
Location:
trunk
Files:
65 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r239150 r239151  
     12018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
     2
     3        [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
     4        https://bugs.webkit.org/show_bug.cgi?id=192618
     5
     6        Reviewed by Alex Christensen.
     7
     8        No new tests, no behavior changes.
     9
     10        * platform/win/PopupMenuWin.h:
     11        * platform/win/WCDataObject.cpp:
     12        * platform/win/WCDataObject.h:
     13
    1142018-12-12  Simon Fraser  <simon.fraser@apple.com>
    215
  • trunk/Source/WebCore/platform/win/PopupMenuWin.h

    r213211 r239151  
    141141};
    142142
    143 class AccessiblePopupMenu : public IAccessible {
     143class AccessiblePopupMenu final : public IAccessible {
    144144public:
    145145    AccessiblePopupMenu(const PopupMenuWin&);
  • trunk/Source/WebCore/platform/win/WCDataObject.cpp

    r194535 r239151  
    3333namespace WebCore {
    3434
    35 class WCEnumFormatEtc : public IEnumFORMATETC
     35class WCEnumFormatEtc final : public IEnumFORMATETC
    3636{
    3737public:
  • trunk/Source/WebCore/platform/win/WCDataObject.h

    r194535 r239151  
    4242};
    4343
    44 class WCDataObject : public IDataObject {
     44class WCDataObject final : public IDataObject {
    4545public:
    4646    void CopyMedium(STGMEDIUM* pMedDest, STGMEDIUM* pMedSrc, FORMATETC* pFmtSrc);
  • trunk/Source/WebKitLegacy/win/COMEnumVariant.h

    r216227 r239151  
    3232
    3333template<typename ContainerType>
    34 class COMEnumVariant : public IEnumVARIANT {
     34class COMEnumVariant final : public IEnumVARIANT {
    3535    WTF_MAKE_NONCOPYABLE(COMEnumVariant);
    3636public:
  • trunk/Source/WebKitLegacy/win/COMPropertyBag.h

    r216227 r239151  
    3636
    3737template<typename ValueType, typename KeyType = typename WTF::String, typename HashType = typename WTF::StringHash>
    38 class COMPropertyBag : public IPropertyBag, public IPropertyBag2 {
     38class COMPropertyBag final : public IPropertyBag, public IPropertyBag2 {
    3939    WTF_MAKE_NONCOPYABLE(COMPropertyBag);
    4040public:
  • trunk/Source/WebKitLegacy/win/ChangeLog

    r239092 r239151  
     12018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
     2
     3        [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
     4        https://bugs.webkit.org/show_bug.cgi?id=192618
     5
     6        Reviewed by Alex Christensen.
     7
     8        Classes which implement COM interface usually doesn't need the
     9        virtual destructor because it has Release() virtual method to
     10        destruct itself.
     11
     12        Marked 'final' such classes to suppress clang-cl's compilation
     13        warnings.
     14
     15        * COMEnumVariant.h:
     16        * COMPropertyBag.h:
     17        * DefaultDownloadDelegate.h:
     18        * DefaultPolicyDelegate.h:
     19        * MemoryStream.h:
     20        * WebActionPropertyBag.h:
     21        * WebApplicationCache.h:
     22        * WebArchive.h:
     23        * WebBackForwardList.h:
     24        * WebCache.h:
     25        * WebCoreStatistics.h:
     26        * WebCoreSupport/WebEditorClient.cpp:
     27        * WebCoreSupport/WebInspectorDelegate.h:
     28        * WebDataSource.h:
     29        * WebDatabaseManager.cpp:
     30        * WebDatabaseManager.h:
     31        * WebDownload.h:
     32        * WebDropSource.h:
     33        * WebElementPropertyBag.h:
     34        * WebError.h:
     35        * WebFrame.cpp:
     36        * WebFrame.h:
     37        * WebFramePolicyListener.h:
     38        * WebGeolocationPolicyListener.h:
     39        * WebGeolocationPosition.h:
     40        * WebHTMLRepresentation.h:
     41        * WebHistory.h:
     42        * WebHistoryItem.h:
     43        * WebInspector.h:
     44        * WebJavaScriptCollector.h:
     45        * WebKitClassFactory.h:
     46        * WebKitMessageLoop.h:
     47        * WebKitStatistics.h:
     48        * WebMutableURLRequest.h:
     49        * WebNavigationData.h:
     50        * WebNotification.h:
     51        * WebNotificationCenter.h:
     52        * WebPreferences.h:
     53        * WebResource.h:
     54        * WebScriptWorld.h:
     55        * WebSecurityOrigin.h:
     56        * WebSerializedJSValue.h:
     57        * WebTextRenderer.h:
     58        * WebURLAuthenticationChallenge.h:
     59        * WebURLAuthenticationChallengeSender.h:
     60        * WebURLCredential.h:
     61        * WebURLProtectionSpace.h:
     62        * WebURLResponse.h:
     63        * WebUserContentURLPattern.h:
     64        * WebView.cpp:
     65        * WebView.h:
     66        * WebWorkersPrivate.h:
     67
    1682018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
    269
  • trunk/Source/WebKitLegacy/win/DefaultDownloadDelegate.h

    r207151 r239151  
    3333#endif
    3434
    35 class DefaultDownloadDelegate : public IWebDownloadDelegate
     35class DefaultDownloadDelegate final : public IWebDownloadDelegate
    3636{
    3737public:
  • trunk/Source/WebKitLegacy/win/DefaultPolicyDelegate.h

    r188662 r239151  
    2929#include "WebKit.h"
    3030
    31 class DefaultPolicyDelegate : public IWebPolicyDelegate {
     31class DefaultPolicyDelegate final : public IWebPolicyDelegate {
    3232public:
    3333    static DefaultPolicyDelegate* sharedInstance();
  • trunk/Source/WebKitLegacy/win/MemoryStream.h

    r216823 r239151  
    3333#include <WTF/RefPtr.h>
    3434
    35 class MemoryStream : public IStream
     35class MemoryStream final : public IStream
    3636{
    3737public:
  • trunk/Source/WebKitLegacy/win/WebActionPropertyBag.h

    r216823 r239151  
    3232#include <WebCore/NavigationAction.h>
    3333
    34 class WebActionPropertyBag : public IPropertyBag {
     34class WebActionPropertyBag final : public IPropertyBag {
    3535public:
    3636    static WebActionPropertyBag* createInstance(const WebCore::NavigationAction&, RefPtr<WebCore::HTMLFormElement>&&, RefPtr<WebCore::Frame>&&);
  • trunk/Source/WebKitLegacy/win/WebApplicationCache.h

    r199836 r239151  
    3333}
    3434
    35 class DECLSPEC_UUID("1119E970-4B13-4B9A-A049-41096104B689") WebApplicationCache : public IWebApplicationCache {
     35class DECLSPEC_UUID("1119E970-4B13-4B9A-A049-41096104B689") WebApplicationCache final : public IWebApplicationCache {
    3636public:
    3737    static WebApplicationCache* createInstance();
  • trunk/Source/WebKitLegacy/win/WebArchive.h

    r216823 r239151  
    3535}
    3636
    37 class WebArchive : public IWebArchive
     37class WebArchive final : public IWebArchive
    3838{
    3939public:
  • trunk/Source/WebKitLegacy/win/WebBackForwardList.h

    r216823 r239151  
    3434class BackForwardList;
    3535
    36 class WebBackForwardList : public IWebBackForwardList, IWebBackForwardListPrivate
     36class WebBackForwardList final : public IWebBackForwardList, IWebBackForwardListPrivate
    3737{
    3838public:
  • trunk/Source/WebKitLegacy/win/WebCache.h

    r188662 r239151  
    2929#include "WebKit.h"
    3030
    31 class WebCache : public IWebCache
     31class WebCache final : public IWebCache
    3232{
    3333public:
  • trunk/Source/WebKitLegacy/win/WebCoreStatistics.h

    r188662 r239151  
    2929#include "WebKit.h"
    3030
    31 class WebCoreStatistics : public IWebCoreStatistics {
     31class WebCoreStatistics final : public IWebCoreStatistics {
    3232public:
    3333    static WebCoreStatistics* createInstance();
  • trunk/Source/WebKitLegacy/win/WebCoreSupport/WebEditorClient.cpp

    r235775 r239151  
    6464// WebEditorUndoTarget -------------------------------------------------------------
    6565
    66 class WebEditorUndoTarget : public IWebUndoTarget
     66class WebEditorUndoTarget final : public IWebUndoTarget
    6767{
    6868public:
     
    509509}
    510510
    511 class WebEditorUndoCommand : public IWebUndoCommand
     511class WebEditorUndoCommand final : public IWebUndoCommand
    512512{
    513513public:
  • trunk/Source/WebKitLegacy/win/WebCoreSupport/WebInspectorDelegate.h

    r188662 r239151  
    3333#include "WebKit.h"
    3434
    35 class WebInspectorDelegate : public IWebUIDelegate {
     35class WebInspectorDelegate final : public IWebUIDelegate {
    3636public:
    3737    static WebInspectorDelegate* createInstance();
  • trunk/Source/WebKitLegacy/win/WebDataSource.h

    r188662 r239151  
    3636extern const GUID IID_WebDataSource;
    3737
    38 class WebDataSource : public IWebDataSource, public IWebDataSourcePrivate
     38class WebDataSource final : public IWebDataSource, public IWebDataSourcePrivate
    3939{
    4040public:
  • trunk/Source/WebKitLegacy/win/WebDatabaseManager.cpp

    r237700 r239151  
    5858}
    5959
    60 class DatabaseDetailsPropertyBag : public IPropertyBag {
     60class DatabaseDetailsPropertyBag final : public IPropertyBag {
    6161    WTF_MAKE_NONCOPYABLE(DatabaseDetailsPropertyBag);
    6262public:
  • trunk/Source/WebKitLegacy/win/WebDatabaseManager.h

    r237700 r239151  
    3636}
    3737
    38 class WebDatabaseManager : public IWebDatabaseManager2, private WebCore::DatabaseManagerClient {
     38class WebDatabaseManager final : public IWebDatabaseManager2, private WebCore::DatabaseManagerClient {
    3939public:
    4040    static WebDatabaseManager* createInstance();
  • trunk/Source/WebKitLegacy/win/WebDownload.h

    r238771 r239151  
    4444}
    4545
    46 class WebDownload
     46class WebDownload final
    4747: public IWebDownload
    4848, public IWebURLAuthenticationChallengeSender
  • trunk/Source/WebKitLegacy/win/WebDropSource.h

    r188662 r239151  
    3939WebCore::PlatformMouseEvent generateMouseEvent(WebView*, bool isDrag);
    4040
    41 class WebDropSource : public IDropSource
     41class WebDropSource final : public IDropSource
    4242{
    4343public:
  • trunk/Source/WebKitLegacy/win/WebElementPropertyBag.h

    r188662 r239151  
    3333}
    3434
    35 class WebElementPropertyBag : public IPropertyBag
     35class WebElementPropertyBag final : public IPropertyBag
    3636{
    3737public:
  • trunk/Source/WebKitLegacy/win/WebError.h

    r207151 r239151  
    3131#include <wtf/RetainPtr.h>
    3232
    33 class WebError : public IWebError, IWebErrorPrivate {
     33class WebError final : public IWebError, IWebErrorPrivate {
    3434public:
    3535    static WebError* createInstance(const WebCore::ResourceError&, IPropertyBag* userInfo = 0);
  • trunk/Source/WebKitLegacy/win/WebFrame.cpp

    r238894 r239151  
    759759}
    760760
    761 class EnumChildFrames : public IEnumVARIANT
     761class EnumChildFrames final : public IEnumVARIANT
    762762{
    763763public:
  • trunk/Source/WebKitLegacy/win/WebFrame.h

    r238771 r239151  
    7676WEBKIT_API WebCore::Frame* core(WebFrame*);
    7777
    78 class DECLSPEC_UUID("{A3676398-4485-4a9d-87DC-CB5A40E6351D}") WebFrame : public IWebFrame2, IWebFramePrivate, IWebDocumentText
     78class DECLSPEC_UUID("{A3676398-4485-4a9d-87DC-CB5A40E6351D}") WebFrame final : public IWebFrame2, IWebFramePrivate, IWebDocumentText
    7979{
    8080public:
  • trunk/Source/WebKitLegacy/win/WebFramePolicyListener.h

    r216823 r239151  
    3636}
    3737
    38 class WebFramePolicyListener : public IWebPolicyDecisionListener, public IWebFormSubmissionListener {
     38class WebFramePolicyListener final : public IWebPolicyDecisionListener, public IWebFormSubmissionListener {
    3939public:
    4040    static WebFramePolicyListener* createInstance(RefPtr<WebCore::Frame>&&);
  • trunk/Source/WebKitLegacy/win/WebGeolocationPolicyListener.h

    r221743 r239151  
    3434}
    3535
    36 class WebGeolocationPolicyListener : public IWebGeolocationPolicyListener {
     36class WebGeolocationPolicyListener final : public IWebGeolocationPolicyListener {
    3737public:
    3838    static COMPtr<WebGeolocationPolicyListener> createInstance(RefPtr<WebCore::Geolocation>&&);
  • trunk/Source/WebKitLegacy/win/WebGeolocationPosition.h

    r223192 r239151  
    3030#include <WebCore/GeolocationPosition.h>
    3131
    32 class WebGeolocationPosition : public IWebGeolocationPosition {
     32class WebGeolocationPosition final : public IWebGeolocationPosition {
    3333public:
    3434    static COMPtr<WebGeolocationPosition> createInstance();
  • trunk/Source/WebKitLegacy/win/WebHTMLRepresentation.h

    r188662 r239151  
    3131class WebFrame;
    3232
    33 class WebHTMLRepresentation : public IWebHTMLRepresentation, IWebDocumentRepresentation
     33class WebHTMLRepresentation final : public IWebHTMLRepresentation, IWebDocumentRepresentation
    3434{
    3535public:
  • trunk/Source/WebKitLegacy/win/WebHistory.h

    r238771 r239151  
    4242class WebVisitedLinkStore;
    4343
    44 class WebHistory : public IWebHistory, public IWebHistoryPrivate {
     44class WebHistory final : public IWebHistory, public IWebHistoryPrivate {
    4545public:
    4646    static WebHistory* createInstance();
  • trunk/Source/WebKitLegacy/win/WebHistoryItem.h

    r216823 r239151  
    3939//-----------------------------------------------------------------------------
    4040
    41 class WebHistoryItem : public IWebHistoryItem, IWebHistoryItemPrivate
     41class WebHistoryItem final : public IWebHistoryItem, IWebHistoryItemPrivate
    4242{
    4343public:
  • trunk/Source/WebKitLegacy/win/WebInspector.h

    r201237 r239151  
    3737class WebView;
    3838
    39 class WebInspector : public IWebInspector, public IWebInspectorPrivate {
     39class WebInspector final : public IWebInspector, public IWebInspectorPrivate {
    4040    WTF_MAKE_NONCOPYABLE(WebInspector);
    4141public:
  • trunk/Source/WebKitLegacy/win/WebJavaScriptCollector.h

    r188662 r239151  
    2929#include "WebKit.h"
    3030
    31 class WebJavaScriptCollector : public IWebJavaScriptCollector
     31class WebJavaScriptCollector final : public IWebJavaScriptCollector
    3232{
    3333public:
  • trunk/Source/WebKitLegacy/win/WebKitClassFactory.h

    r188662 r239151  
    2929#include <unknwn.h>
    3030
    31 class WebKitClassFactory : public IClassFactory
     31class WebKitClassFactory final : public IClassFactory
    3232{
    3333public:
  • trunk/Source/WebKitLegacy/win/WebKitMessageLoop.h

    r197563 r239151  
    2929#include "WebKit.h"
    3030
    31 class WebKitMessageLoop : public IWebKitMessageLoop {
     31class WebKitMessageLoop final : public IWebKitMessageLoop {
    3232public:
    3333    WebKitMessageLoop();
  • trunk/Source/WebKitLegacy/win/WebKitStatistics.h

    r188662 r239151  
    3232#include "WebKit.h"
    3333
    34 class WebKitStatistics : public IWebKitStatistics {
     34class WebKitStatistics final : public IWebKitStatistics {
    3535public:
    3636    static WebKitStatistics* createInstance();
  • trunk/Source/WebKitLegacy/win/WebMutableURLRequest.h

    r216823 r239151  
    4545}
    4646
    47 class WebMutableURLRequest : public IWebMutableURLRequest, IWebMutableURLRequestPrivate
     47class WebMutableURLRequest final : public IWebMutableURLRequest, IWebMutableURLRequestPrivate
    4848{
    4949public:
  • trunk/Source/WebKitLegacy/win/WebNavigationData.h

    r188662 r239151  
    3232#include <WebCore/COMPtr.h>
    3333
    34 class WebNavigationData : public IWebNavigationData {
     34class WebNavigationData final : public IWebNavigationData {
    3535public:
    3636    static WebNavigationData* createInstance(const WTF::String& url, const WTF::String& title, IWebURLRequest*, IWebURLResponse*, bool hasSubstituteData, const WTF::String& clientRedirectSource);
  • trunk/Source/WebKitLegacy/win/WebNotification.h

    r188662 r239151  
    2929#include "WebKit.h"
    3030
    31 class WebNotification : public IWebNotification
     31class WebNotification final : public IWebNotification
    3232{
    3333public:
  • trunk/Source/WebKitLegacy/win/WebNotificationCenter.h

    r188662 r239151  
    3131struct WebNotificationCenterPrivate;
    3232
    33 class WebNotificationCenter : public IWebNotificationCenter {
     33class WebNotificationCenter final : public IWebNotificationCenter {
    3434public:
    3535    static WebNotificationCenter* createInstance();
  • trunk/Source/WebKitLegacy/win/WebPreferences.h

    r235539 r239151  
    3131#include <wtf/RetainPtr.h>
    3232
    33 class WebPreferences : public IWebPreferences, public IWebPreferencesPrivate7 {
     33class WebPreferences final : public IWebPreferences, public IWebPreferencesPrivate7 {
    3434public:
    3535    static WebPreferences* createInstance();
  • trunk/Source/WebKitLegacy/win/WebResource.h

    r238771 r239151  
    3535#include <wtf/text/WTFString.h>
    3636
    37 class WebResource : public IWebResource {
     37class WebResource final : public IWebResource {
    3838public:
    3939    static WebResource* createInstance(RefPtr<WebCore::SharedBuffer>&&, const WebCore::ResourceResponse&);
  • trunk/Source/WebKitLegacy/win/WebScriptWorld.h

    r216823 r239151  
    3333}
    3434
    35 class WebScriptWorld : public IWebScriptWorld {
     35class WebScriptWorld final : public IWebScriptWorld {
    3636    WTF_MAKE_NONCOPYABLE(WebScriptWorld);
    3737public:
  • trunk/Source/WebKitLegacy/win/WebSecurityOrigin.h

    r207769 r239151  
    3232#include <WebCore/SecurityOrigin.h>
    3333
    34 class DECLSPEC_UUID("6EB8D98F-2723-4472-88D3-5936F9D6E631") WebSecurityOrigin : public IWebSecurityOrigin2 {
     34class DECLSPEC_UUID("6EB8D98F-2723-4472-88D3-5936F9D6E631") WebSecurityOrigin final : public IWebSecurityOrigin2 {
    3535public:
    3636    // WebSecurityOrigin
  • trunk/Source/WebKitLegacy/win/WebSerializedJSValue.h

    r188662 r239151  
    3636}
    3737
    38 class WebSerializedJSValue : public IWebSerializedJSValue, public IWebSerializedJSValuePrivate {
     38class WebSerializedJSValue final : public IWebSerializedJSValue, public IWebSerializedJSValuePrivate {
    3939    WTF_MAKE_NONCOPYABLE(WebSerializedJSValue);
    4040public:
  • trunk/Source/WebKitLegacy/win/WebTextRenderer.h

    r188662 r239151  
    3232#include "WebKit.h"
    3333
    34 class WebTextRenderer : public IWebTextRenderer {
     34class WebTextRenderer final : public IWebTextRenderer {
    3535public:
    3636    static WebTextRenderer* createInstance();
  • trunk/Source/WebKitLegacy/win/WebURLAuthenticationChallenge.h

    r188662 r239151  
    3131#include <WebCore/COMPtr.h>
    3232
    33 class DECLSPEC_UUID("FD3B2381-0BB6-4B59-AF09-0E599C8901CF") WebURLAuthenticationChallenge : public IWebURLAuthenticationChallenge {
     33class DECLSPEC_UUID("FD3B2381-0BB6-4B59-AF09-0E599C8901CF") WebURLAuthenticationChallenge final : public IWebURLAuthenticationChallenge {
    3434public:
    3535    static WebURLAuthenticationChallenge* createInstance(const WebCore::AuthenticationChallenge&);
  • trunk/Source/WebKitLegacy/win/WebURLAuthenticationChallengeSender.h

    r216823 r239151  
    3636}
    3737
    38 class DECLSPEC_UUID("5CACD637-F82F-491F-947A-5DCA38AA0FEA") WebURLAuthenticationChallengeSender
     38class DECLSPEC_UUID("5CACD637-F82F-491F-947A-5DCA38AA0FEA") WebURLAuthenticationChallengeSender final
    3939    : public IWebURLAuthenticationChallengeSender
    4040{
  • trunk/Source/WebKitLegacy/win/WebURLCredential.h

    r188662 r239151  
    3030#include <WebCore/Credential.h>
    3131
    32 class WebURLCredential : public IWebURLCredential
     32class WebURLCredential final : public IWebURLCredential
    3333{
    3434public:
  • trunk/Source/WebKitLegacy/win/WebURLProtectionSpace.h

    r188662 r239151  
    3030#include <WebCore/ProtectionSpace.h>
    3131
    32 class WebURLProtectionSpace : public IWebURLProtectionSpace
     32class WebURLProtectionSpace final : public IWebURLProtectionSpace
    3333{
    3434public:
  • trunk/Source/WebKitLegacy/win/WebURLResponse.h

    r207151 r239151  
    2929#include <WebCore/ResourceResponse.h>
    3030
    31 class WebURLResponse : public IWebHTTPURLResponse, IWebURLResponsePrivate
     31class WebURLResponse final : public IWebHTTPURLResponse, IWebURLResponsePrivate
    3232{
    3333public:
  • trunk/Source/WebKitLegacy/win/WebUserContentURLPattern.h

    r188662 r239151  
    3434}
    3535
    36 class WebUserContentURLPattern : public IWebUserContentURLPattern {
     36class WebUserContentURLPattern final : public IWebUserContentURLPattern {
    3737    WTF_MAKE_NONCOPYABLE(WebUserContentURLPattern);
    3838public:
  • trunk/Source/WebKitLegacy/win/WebView.cpp

    r239092 r239151  
    283283}
    284284
    285 class PreferencesChangedOrRemovedObserver : public IWebNotificationObserver {
     285class PreferencesChangedOrRemovedObserver final : public IWebNotificationObserver {
    286286public:
    287287    static PreferencesChangedOrRemovedObserver* sharedInstance();
     
    73867386#endif
    73877387
    7388 class EnumTextMatches : public IEnumTextMatches
     7388class EnumTextMatches final : public IEnumTextMatches
    73897389{
    73907390    long m_ref;
  • trunk/Source/WebKitLegacy/win/WebView.h

    r238771 r239151  
    8686#endif
    8787
    88 class WebView
     88class WebView final
    8989    : public IWebView
    9090    , public IWebViewPrivate5
  • trunk/Source/WebKitLegacy/win/WebWorkersPrivate.h

    r188662 r239151  
    3434#include "WebKit.h"
    3535
    36 class WebWorkersPrivate : public IWebWorkersPrivate {
     36class WebWorkersPrivate final : public IWebWorkersPrivate {
    3737public:
    3838    static WebWorkersPrivate* createInstance();
  • trunk/Tools/ChangeLog

    r239149 r239151  
     12018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
     2
     3        [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
     4        https://bugs.webkit.org/show_bug.cgi?id=192618
     5
     6        Reviewed by Alex Christensen.
     7
     8        * DumpRenderTree/win/DRTDataObject.cpp:
     9        * DumpRenderTree/win/DRTDataObject.h:
     10        * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
     11        * DumpRenderTree/win/DRTDropSource.h:
     12        * DumpRenderTree/win/EditingDelegate.h:
     13        * DumpRenderTree/win/PolicyDelegate.h:
     14        * DumpRenderTree/win/UIDelegate.h:
     15
    1162018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
    217
  • trunk/Tools/DumpRenderTree/win/DRTDataObject.cpp

    r205118 r239151  
    4848}
    4949
    50 class WCEnumFormatEtc : public IEnumFORMATETC {
     50class WCEnumFormatEtc final : public IEnumFORMATETC {
    5151public:
    5252    explicit WCEnumFormatEtc(const Vector<FORMATETC>& formats);
  • trunk/Tools/DumpRenderTree/win/DRTDataObject.h

    r188709 r239151  
    4545};
    4646
    47 class DRTDataObject : public IDataObject {
     47class DRTDataObject final : public IDataObject {
    4848public:
    4949    void CopyMedium(STGMEDIUM* pMedDest, STGMEDIUM* pMedSrc, FORMATETC* pFmtSrc);
  • trunk/Tools/DumpRenderTree/win/DRTDesktopNotificationPresenter.h

    r222194 r239151  
    3333#include <windef.h>
    3434
    35 class DRTDesktopNotificationPresenter : public IWebDesktopNotificationsDelegate {
     35class DRTDesktopNotificationPresenter final : public IWebDesktopNotificationsDelegate {
    3636public:
    3737    DRTDesktopNotificationPresenter();
  • trunk/Tools/DumpRenderTree/win/DRTDropSource.h

    r188709 r239151  
    3131#include <windows.h>
    3232
    33 class DRTDropSource : public IDropSource {
     33class DRTDropSource final : public IDropSource {
    3434public:
    3535    virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);       
  • trunk/Tools/DumpRenderTree/win/EditingDelegate.h

    r222194 r239151  
    3232#include <WebKitLegacy/WebKit.h>
    3333
    34 class __declspec(uuid("265DCD4B-79C3-44a2-84BC-511C3EDABD6F")) EditingDelegate : public IWebEditingDelegate2, public IWebNotificationObserver {
     34class __declspec(uuid("265DCD4B-79C3-44a2-84BC-511C3EDABD6F")) EditingDelegate final : public IWebEditingDelegate2, public IWebNotificationObserver {
    3535public:
    3636    EditingDelegate();
  • trunk/Tools/DumpRenderTree/win/PolicyDelegate.h

    r222194 r239151  
    3434class TestRunner;
    3535
    36 class PolicyDelegate : public IWebPolicyDelegate {
     36class PolicyDelegate final : public IWebPolicyDelegate {
    3737public:
    3838    PolicyDelegate();
  • trunk/Tools/DumpRenderTree/win/UIDelegate.h

    r222194 r239151  
    3737class DRTDesktopNotificationPresenter;
    3838
    39 class UIDelegate : public IWebUIDelegate2, IWebUIDelegatePrivate3 {
     39class UIDelegate final : public IWebUIDelegate2, IWebUIDelegatePrivate3 {
    4040public:
    4141    UIDelegate();
Note: See TracChangeset for help on using the changeset viewer.