Changeset 239292 in webkit


Ignore:
Timestamp:
Dec 17, 2018 3:01:44 PM (5 years ago)
Author:
commit-queue@webkit.org
Message:

Import FeedbackServer only if "-f/--feedback-in-browser" option is enabled.
https://bugs.webkit.org/show_bug.cgi?id=192378

Patch by Suresh Koppisetty <skoppisetty@apple.com> on 2018-12-17
Reviewed by Ryosuke Niwa.

FeedbackServer currently depends on Tornado-5.1, which further adds
dependency of "singledispatch", "backports-abc" and "futures" python libraries.
Importing FeedbackServer only if "-f/--feedback-in-browser" option is enabled
will let us run the benchmark scripts without installing any new python libraries.

  • LaunchTime/launch_time.py:
  • LaunchTime/new_tab.py:
Location:
trunk/PerformanceTests
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/PerformanceTests/ChangeLog

    r239158 r239292  
     12018-12-17  Suresh Koppisetty  <skoppisetty@apple.com>
     2
     3        Import FeedbackServer only if "-f/--feedback-in-browser" option is enabled.
     4        https://bugs.webkit.org/show_bug.cgi?id=192378
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        FeedbackServer currently depends on Tornado-5.1, which further adds
     9        dependency of "singledispatch", "backports-abc" and "futures" python libraries.
     10        Importing FeedbackServer only if "-f/--feedback-in-browser" option is enabled
     11        will let us run the benchmark scripts without installing any new python libraries.
     12
     13        * LaunchTime/launch_time.py:
     14        * LaunchTime/new_tab.py:
     15
    1162018-12-13  Caio Lima  <ticaiolima@gmail.com>
    217
  • trunk/PerformanceTests/LaunchTime/launch_time.py

    r234764 r239292  
    1111import time
    1212
    13 from feedback_server import FeedbackServer
    1413
    1514
     
    147146
    148147        if self._feedback_in_browser:
     148            from feedback_server import FeedbackServer
    149149            self._feedback_server = FeedbackServer()
    150150            self._feedback_port = self._feedback_server.start()
  • trunk/PerformanceTests/LaunchTime/new_tab.py

    r234764 r239292  
    55
    66from launch_time import LaunchTimeBenchmark, DefaultLaunchTimeHandler
    7 import feedback_server
    8 
    97
    108class NewTabBenchmark(LaunchTimeBenchmark):
Note: See TracChangeset for help on using the changeset viewer.