Changeset 239321 in webkit

Timestamp:

Dec 17, 2018 10:30:34 PM (5 years ago)

Author:

Wenson Hsieh

Message:

Tap highlights should not be shown on iOSMac
​https://bugs.webkit.org/show_bug.cgi?id=192797
<rdar://problem/46793995>

Reviewed by Tim Horton.

WKWebViews in iOSMac should avoid painting tap highlights, since tap highlights are not present in the rest of
the macOS platform. Simply disable this functionality by bailing in -[WKContentView _showTapHighlight].

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _showTapHighlight]):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/ios/WKContentViewInteraction.mm (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Tap highlights should not be shown on iOSMac
+        https://bugs.webkit.org/show_bug.cgi?id=192797
+        <rdar://problem/46793995>
+
+        Reviewed by Tim Horton.
+
+        WKWebViews in iOSMac should avoid painting tap highlights, since tap highlights are not present in the rest of
+        the macOS platform. Simply disable this functionality by bailing in `-[WKContentView _showTapHighlight]`.
+
+        * UIProcess/ios/WKContentViewInteraction.mm:
+        (-[WKContentView _showTapHighlight]):
+
 2018-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

@@ -1257 +1257 @@
 {
     auto shouldPaintTapHighlight = [&](const WebCore::FloatRect& rect) {
+#if PLATFORM(IOSMAC)
+        UNUSED_PARAM(rect);
+        return NO;
+#else
         static const float highlightPaintThreshold = 0.3; // 30%
         float highlightArea = 0;
@@ -1266 +1270 @@
         }
         return highlightArea < rect.area() * highlightPaintThreshold;
+#endif
     };