Changeset 239370 in webkit

Timestamp:

Dec 18, 2018 10:37:46 PM (5 years ago)

Author:

Ross Kirsling

Message:

Error message for -x ** y contains a typo.
​https://bugs.webkit.org/show_bug.cgi?id=192832

Reviewed by Saam Barati.

JSTests:

• ChakraCore/test/UnitTestFramework/UnitTestFramework.js:

(assert.assert.return.throws):

• stress/pow-expects-update-expression-on-lhs.js:

(throw.new.Error):
Update test expectations which match against the exact error message.

Source/JavaScriptCore:

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseBinaryExpression):
Make corrections to error message: "amiguous" -> "ambiguous", "parenthesis" -> "parentheses"

Location:

trunk

Files:

• JSTests/ChakraCore/test/UnitTestFramework/UnitTestFramework.js (modified) (1 diff)
• JSTests/ChangeLog (modified) (1 diff)
• JSTests/stress/pow-expects-update-expression-on-lhs.js (modified) (1 diff)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/parser/Parser.cpp (modified) (1 diff)

trunk/JSTests/ChakraCore/test/UnitTestFramework/UnitTestFramework.js

@@ -367 +367 @@
                 {
                     regexp: /Invalid unary operator on the left hand side of exponentiation \(\*\*\) operator/,
-                    replStr: "Unexpected token '**'. Amiguous unary expression in the left hand side of the exponentiation expression; parenthesis must be used to disambiguate the expression."
+                    replStr: "Unexpected token '**'. Ambiguous unary expression in the left hand side of the exponentiation expression; parentheses must be used to disambiguate the expression."
                 },
                 {

trunk/JSTests/ChangeLog

@@ +1 @@
+2018-12-18  Ross Kirsling  <ross.kirsling@sony.com>
+
+        Error message for `-x ** y` contains a typo.
+        https://bugs.webkit.org/show_bug.cgi?id=192832
+
+        Reviewed by Saam Barati.
+
+        * ChakraCore/test/UnitTestFramework/UnitTestFramework.js:
+        (assert.assert.return.throws):
+        * stress/pow-expects-update-expression-on-lhs.js:
+        (throw.new.Error):
+        Update test expectations which match against the exact error message.
+
 2018-12-18  Mark Lam  <mark.lam@apple.com>
 

trunk/JSTests/stress/pow-expects-update-expression-on-lhs.js

@@ -39 +39 @@
             return ${token} a ** b;
         }
-        `, `SyntaxError: Unexpected token '**'. Amiguous unary expression in the left hand side of the exponentiation expression; parenthesis must be used to disambiguate the expression.`);
+        `, `SyntaxError: Unexpected token '**'. Ambiguous unary expression in the left hand side of the exponentiation expression; parentheses must be used to disambiguate the expression.`);
     }
 }

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2018-12-18  Ross Kirsling  <ross.kirsling@sony.com>
+
+        Error message for `-x ** y` contains a typo.
+        https://bugs.webkit.org/show_bug.cgi?id=192832
+
+        Reviewed by Saam Barati.
+
+        * parser/Parser.cpp:
+        (JSC::Parser<LexerType>::parseBinaryExpression):
+        Make corrections to error message: "amiguous" -> "ambiguous", "parenthesis" -> "parentheses"
+
 2018-12-18  Saam Barati  <sbarati@apple.com>
 

trunk/Source/JavaScriptCore/parser/Parser.cpp

@@ -3887 +3887 @@
         // If the binary operator <> has higher precedence than one of "**", this check does not work.
         // But it's OK for ** because the operator "**" has the highest operator precedence in the binary operators.
-        failIfTrue(match(POW) && isUnaryOpExcludingUpdateOp(leadingTokenTypeForUnaryExpression), "Amiguous unary expression in the left hand side of the exponentiation expression; parenthesis must be used to disambiguate the expression");
+        failIfTrue(match(POW) && isUnaryOpExcludingUpdateOp(leadingTokenTypeForUnaryExpression), "Ambiguous unary expression in the left hand side of the exponentiation expression; parentheses must be used to disambiguate the expression");
 
         int precedence = isBinaryOperator(m_token.m_type);