Changeset 239464 in webkit

Timestamp:

Dec 20, 2018 1:39:11 PM (5 years ago)

Author:

keith_miller@apple.com

Message:

Add support for globalThis
​https://bugs.webkit.org/show_bug.cgi?id=165171

Reviewed by Mark Lam.

JSTests:

• test262/config.yaml:

Source/JavaScriptCore:

This patch adds support for the globalThis property on the global
object. The globalThis property spec is in stage three and is
quite simple. For reference: ​http://tc39.github.io/proposal-global/

• runtime/JSGlobalObject.cpp:

Location:

trunk

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/test262/config.yaml (modified) (1 diff)
• LayoutTests/js/globalThis-is-window-expected.txt (added)
• LayoutTests/js/globalThis-is-window.html (added)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/runtime/JSGlobalObject.cpp (modified) (1 diff)

trunk/JSTests/ChangeLog

@@ +1 @@
+2018-12-20  Keith Miller  <keith_miller@apple.com>
+
+        Add support for globalThis
+        https://bugs.webkit.org/show_bug.cgi?id=165171
+
+        Reviewed by Mark Lam.
+
+        * test262/config.yaml:
+
 2018-12-19  Keith Miller  <keith_miller@apple.com>
 

trunk/JSTests/test262/config.yaml

@@ -49 +49 @@
     - test/built-ins/Reflect/ownKeys/return-on-corresponding-order-large-index.js
 
-    # https://bugs.webkit.org/show_bug.cgi?id=186785
-    - test/built-ins/global/global-object.js
-    - test/built-ins/global/property-descriptor.js
-
     # https://bugs.webkit.org/show_bug.cgi?id=192920
     - test/intl402/PluralRules/prototype/resolvedOptions/order.js

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2018-12-20  Keith Miller  <keith_miller@apple.com>
+
+        Add support for globalThis
+        https://bugs.webkit.org/show_bug.cgi?id=165171
+
+        Reviewed by Mark Lam.
+
+        This patch adds support for the globalThis property on the global
+        object. The globalThis property spec is in stage three and is
+        quite simple. For reference: http://tc39.github.io/proposal-global/
+
+        * runtime/JSGlobalObject.cpp:
+
 2018-12-20  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/JavaScriptCore/runtime/JSGlobalObject.cpp

@@ -303 +303 @@
   encodeURIComponent    globalFuncEncodeURIComponent                 DontEnum|Function 1
   EvalError             JSGlobalObject::m_evalErrorConstructor       DontEnum|CellProperty
+  globalThis            JSGlobalObject::m_globalThis                 DontEnum|CellProperty
   ReferenceError        JSGlobalObject::m_referenceErrorConstructor  DontEnum|CellProperty
   SyntaxError           JSGlobalObject::m_syntaxErrorConstructor     DontEnum|CellProperty