Changeset 239526 in webkit

Timestamp:

Dec 21, 2018 4:02:19 PM (5 years ago)

Author:

Alan Bujtas

Message:

[iOS] Using file upload can trigger a crash under RenderThemeIOS::paintFileUploadIconDecorations()
​https://bugs.webkit.org/show_bug.cgi?id=192357
<rdar://problem/42852260>

Reviewed by Simon Fraser.

Do not try to paint the file picker when painting is disabled.

• rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::paintObject):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderFileUploadControl.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-12-21  Zalan Bujtas  <zalan@apple.com>
+
+        [iOS] Using file upload can trigger a crash under RenderThemeIOS::paintFileUploadIconDecorations()
+        https://bugs.webkit.org/show_bug.cgi?id=192357
+        <rdar://problem/42852260>
+
+        Reviewed by Simon Fraser.
+
+        Do not try to paint the file picker when painting is disabled.
+
+        * rendering/RenderFileUploadControl.cpp:
+        (WebCore::RenderFileUploadControl::paintObject):
+
 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
 

trunk/Source/WebCore/rendering/RenderFileUploadControl.cpp

@@ -118 +118 @@
         return;
     
+    if (paintInfo.context().paintingDisabled())
+        return;
+
     // Push a clip.
     GraphicsContextStateSaver stateSaver(paintInfo.context(), false);