Changeset 239646 in webkit

Timestamp:

Jan 4, 2019 4:28:57 PM (5 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Audit: disable breakpoints when running Audit
​https://bugs.webkit.org/show_bug.cgi?id=193158
<rdar://problem/47057083>

Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

• UserInterface/Controllers/DebuggerManager.js:

(WI.DebuggerManager):
(WI.DebuggerManager.prototype._startDisablingBreakpointsTemporarily):
(WI.DebuggerManager.prototype._stopDisablingBreakpointsTemporarily):
(WI.DebuggerManager.prototype._handleAuditManagerTestScheduled): Added.
(WI.DebuggerManager.prototype._handleAuditManagerTestCompleted): Added.

• UserInterface/Views/DebuggerSidebarPanel.js:

(WI.DebuggerSidebarPanel.prototype._timelineCapturingWillStart):
(WI.DebuggerSidebarPanel.prototype._timelineCapturingStopped):
(WI.DebuggerSidebarPanel.prototype._handleAuditManagerTestScheduled): Added.
(WI.DebuggerSidebarPanel.prototype._handleAuditManagerTestCompleted): Added.
(WI.DebuggerSidebarPanel.prototype._updateBreakpointsDisabledBanner):

• UserInterface/Views/DebuggerSidebarPanel.css:

(.sidebar > .panel.navigation.debugger .warning-banner + .warning-banner): Added.

• UserInterface/Base/Main.js:

(WI.loaded):

• UserInterface/Test/Test.js:

(WI.loaded):
Move WI.auditManager higher in the managers list so that it can be used in
WI.DebuggerManager's constructor.

• Localizations/en.lproj/localizedStrings.js:

LayoutTests:

• inspector/audit/basic.html:
• inspector/audit/basic-expected.txt:

• inspector/audit/resources/audit-utilities.js:

(TestPage.registerInitializer.InspectorTest.Audit.addTest):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/inspector/audit/basic-expected.txt (modified) (1 diff)
• LayoutTests/inspector/audit/basic.html (modified) (1 diff)
• LayoutTests/inspector/audit/resources/audit-utilities.js (modified) (1 diff)
• Source/WebInspectorUI/ChangeLog (modified) (1 diff)
• Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (modified) (2 diffs)
• Source/WebInspectorUI/UserInterface/Base/Main.js (modified) (2 diffs)
• Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js (modified) (5 diffs)
• Source/WebInspectorUI/UserInterface/Test/Test.js (modified) (2 diffs)
• Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.css (modified) (1 diff)
• Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js (modified) (5 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-01-04  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Audit: disable breakpoints when running Audit
+        https://bugs.webkit.org/show_bug.cgi?id=193158
+        <rdar://problem/47057083>
+
+        Reviewed by Joseph Pecoraro.
+
+        * inspector/audit/basic.html:
+        * inspector/audit/basic-expected.txt:
+
+        * inspector/audit/resources/audit-utilities.js:
+        (TestPage.registerInitializer.InspectorTest.Audit.addTest):
+
 2019-01-04  Youenn Fablet  <youenn@apple.com>
 

trunk/LayoutTests/inspector/audit/basic-expected.txt

@@ -127 +127 @@
    - rejected
 
+-- Running test case: Audit.Basic.Debugger
+Testing `debugger`...
+PASS: Should not pause on the debugger statement.
+PASS: Result should be "pass".
+

trunk/LayoutTests/inspector/audit/basic.html

@@ -46 +46 @@
     InspectorTest.Audit.addPromiseTest("Audit.Basic.Error.Promise.Rejected", `setTimeout(reject, 0, "rejected")`, WI.AuditTestCaseResult.Level.Error);
 
+    suite.addTestCase({
+        name: "Audit.Basic.Debugger",
+        description: "Test that a debugger statement doesn't pause when running an audit.",
+        test(resolve, reject) {
+            const level = "pass";
+            let audit = new WI.AuditTestCase("Audit.Basic.Debugger", `function() { debugger; return "${level}"; }`);
+
+            let paused = false;
+            let pausedListener = WI.debuggerManager.singleFireEventListener(WI.DebuggerManager.Event.Paused, (event) => {
+                paused = true;
+
+                WI.debuggerManager.resume();
+            });
+
+            WI.auditManager.awaitEvent(WI.AuditManager.Event.TestCompleted).then((event) => {
+                InspectorTest.expectFalse(paused, "Should not pause on the debugger statement.");
+
+                let results = WI.auditManager.results.lastValue;
+                InspectorTest.assert(results.length === 1, "There should be 1 result.");
+
+                let result = results[0];
+                InspectorTest.assert(result instanceof WI.AuditTestCaseResult, "Result should be a WI.AuditTestCaseResult.");
+                if (!result)
+                    return;
+
+                InspectorTest.expectEqual(result.level, level, `Result should be "${level}".`);
+
+                WI.debuggerManager.removeEventListener(WI.DebuggerManager.Event.Paused, pausedListener);
+            });
+
+            InspectorTest.log("Testing `debugger`...");
+
+            WI.auditManager.start([audit])
+            .then(resolve, reject);
+        },
+    });
+
     suite.runTestCasesAndFinish();
 }

trunk/LayoutTests/inspector/audit/resources/audit-utilities.js

@@ -59 +59 @@
                     if (data.errors)
                         logArray("errors", data.errors);
-                })
-                .then(resolve, reject);
+                });
 
                 InspectorTest.log("Testing" + (logs.beforeStart || "") + "...");

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-01-04  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Audit: disable breakpoints when running Audit
+        https://bugs.webkit.org/show_bug.cgi?id=193158
+        <rdar://problem/47057083>
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Controllers/DebuggerManager.js:
+        (WI.DebuggerManager):
+        (WI.DebuggerManager.prototype._startDisablingBreakpointsTemporarily):
+        (WI.DebuggerManager.prototype._stopDisablingBreakpointsTemporarily):
+        (WI.DebuggerManager.prototype._handleAuditManagerTestScheduled): Added.
+        (WI.DebuggerManager.prototype._handleAuditManagerTestCompleted): Added.
+
+        * UserInterface/Views/DebuggerSidebarPanel.js:
+        (WI.DebuggerSidebarPanel.prototype._timelineCapturingWillStart):
+        (WI.DebuggerSidebarPanel.prototype._timelineCapturingStopped):
+        (WI.DebuggerSidebarPanel.prototype._handleAuditManagerTestScheduled): Added.
+        (WI.DebuggerSidebarPanel.prototype._handleAuditManagerTestCompleted): Added.
+        (WI.DebuggerSidebarPanel.prototype._updateBreakpointsDisabledBanner):
+        * UserInterface/Views/DebuggerSidebarPanel.css:
+        (.sidebar > .panel.navigation.debugger .warning-banner + .warning-banner): Added.
+
+        * UserInterface/Base/Main.js:
+        (WI.loaded):
+        * UserInterface/Test/Test.js:
+        (WI.loaded):
+        Move `WI.auditManager` higher in the managers list so that it can be used in
+        `WI.DebuggerManager`'s constructor.
+
+        * Localizations/en.lproj/localizedStrings.js:
+
 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js

@@ -277 +277 @@
 localizedStrings["Debugger Paused"] = "Debugger Paused";
 localizedStrings["Debugger Statement"] = "Debugger Statement";
+localizedStrings["Debugger disabled during Audit"] = "Debugger disabled during Audit";
 localizedStrings["Debugger disabled during Timeline recording"] = "Debugger disabled during Timeline recording";
 localizedStrings["Debugger:"] = "Debugger:";
@@ -897 +898 @@
 localizedStrings["Stiffness"] = "Stiffness";
 localizedStrings["Stop"] = "Stop";
+localizedStrings["Stop Audit"] = "Stop Audit";
 localizedStrings["Stop Recording"] = "Stop Recording";
 localizedStrings["Stop element selection (%s)"] = "Stop element selection (%s)";

trunk/Source/WebInspectorUI/UserInterface/Base/Main.js

@@ -115 +115 @@
         WI.applicationCacheManager = new WI.ApplicationCacheManager,
         WI.timelineManager = new WI.TimelineManager,
+        WI.auditManager = new WI.AuditManager,
         WI.debuggerManager = new WI.DebuggerManager,
         WI.layerTreeManager = new WI.LayerTreeManager,
@@ -120 +121 @@
         WI.domDebuggerManager = new WI.DOMDebuggerManager,
         WI.canvasManager = new WI.CanvasManager,
-        WI.auditManager = new WI.AuditManager,
     ];
 

trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js

@@ -42 +42 @@
         WI.timelineManager.addEventListener(WI.TimelineManager.Event.CapturingStopped, this._timelineCapturingStopped, this);
 
+        WI.auditManager.addEventListener(WI.AuditManager.Event.TestScheduled, this._handleAuditManagerTestScheduled, this);
+        WI.auditManager.addEventListener(WI.AuditManager.Event.TestCompleted, this._handleAuditManagerTestCompleted, this);
+
         WI.targetManager.addEventListener(WI.TargetManager.Event.TargetRemoved, this._targetRemoved, this);
 
@@ -94 +97 @@
             this._temporarilyDisabledBreakpointsRestoreSetting.value = null;
         }
+        this._temporarilyDisableBreakpointsRequestCount = 0;
 
         this._ignoreBreakpointDisplayLocationDidChangeEvent = false;
@@ -1111 +1115 @@
     _startDisablingBreakpointsTemporarily()
     {
+        if (++this._temporarilyDisableBreakpointsRequestCount > 1)
+            return;
+
         console.assert(!this.breakpointsDisabledTemporarily, "Already temporarily disabling breakpoints.");
         if (this.breakpointsDisabledTemporarily)
             return;
 
+
         this._temporarilyDisabledBreakpointsRestoreSetting.value = this._breakpointsEnabledSetting.value;
 
@@ -1122 +1130 @@
     _stopDisablingBreakpointsTemporarily()
     {
+        this._temporarilyDisableBreakpointsRequestCount = Math.max(0, this._temporarilyDisableBreakpointsRequestCount - 1);
+        if (this._temporarilyDisableBreakpointsRequestCount > 0)
+            return;
+
         console.assert(this.breakpointsDisabledTemporarily, "Was not temporarily disabling breakpoints.");
         if (!this.breakpointsDisabledTemporarily)
@@ -1141 +1153 @@
 
     _timelineCapturingStopped(event)
+    {
+        this._stopDisablingBreakpointsTemporarily();
+    }
+
+    _handleAuditManagerTestScheduled(event)
+    {
+        this._startDisablingBreakpointsTemporarily();
+
+        if (this.paused)
+            this.resume();
+    }
+
+    _handleAuditManagerTestCompleted(event)
     {
         this._stopDisablingBreakpointsTemporarily();

trunk/Source/WebInspectorUI/UserInterface/Test/Test.js

@@ -58 +58 @@
         WI.memoryManager = new WI.MemoryManager,
         WI.timelineManager = new WI.TimelineManager,
+        WI.auditManager = new WI.AuditManager,
         WI.debuggerManager = new WI.DebuggerManager,
         WI.layerTreeManager = new WI.LayerTreeManager,
@@ -63 +64 @@
         WI.domDebuggerManager = new WI.DOMDebuggerManager,
         WI.canvasManager = new WI.CanvasManager,
-        WI.auditManager = new WI.AuditManager,
     ];
 

trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.css

@@ -63 +63 @@
 }
 
+.sidebar > .panel.navigation.debugger .warning-banner + .warning-banner {
+    display: none;
+}
+
 .sidebar > .panel.navigation.debugger .tree-outline.single-thread > .item.thread {
     display: none;

trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js

@@ -59 +59 @@
         WI.timelineManager.addEventListener(WI.TimelineManager.Event.CapturingStopped, this._timelineCapturingStopped, this);
 
+        WI.auditManager.addEventListener(WI.AuditManager.Event.TestScheduled, this._handleAuditManagerTestScheduled, this);
+        WI.auditManager.addEventListener(WI.AuditManager.Event.TestCompleted, this._handleAuditManagerTestCompleted, this);
+
         WI.targetManager.addEventListener(WI.TargetManager.Event.TargetAdded, this._targetAdded, this);
         WI.targetManager.addEventListener(WI.TargetManager.Event.TargetRemoved, this._targetRemoved, this);
@@ -64 +67 @@
         this._timelineRecordingWarningElement = document.createElement("div");
         this._timelineRecordingWarningElement.classList.add("warning-banner");
-        this._timelineRecordingWarningElement.append(WI.UIString("Debugger disabled during Timeline recording"), " ");
-        let stopRecordingLink = this._timelineRecordingWarningElement.appendChild(document.createElement("a"));
-        stopRecordingLink.textContent = WI.UIString("Stop recording");
-        stopRecordingLink.addEventListener("click", () => { WI.timelineManager.stopCapturing(); });
+        this._timelineRecordingWarningElement.append(WI.UIString("Debugger disabled during Timeline recording"), document.createElement("br"));
+        let timelineStopRecordingLink = this._timelineRecordingWarningElement.appendChild(document.createElement("a"));
+        timelineStopRecordingLink.textContent = WI.UIString("Stop recording");
+        timelineStopRecordingLink.addEventListener("click", () => { WI.timelineManager.stopCapturing(); });
+
+        this._auditTestWarningElement = document.createElement("div");
+        this._auditTestWarningElement.classList.add("warning-banner");
+        this._auditTestWarningElement.append(WI.UIString("Debugger disabled during Audit"), document.createElement("br"));
+        let auditStopRecordingLink = this._auditTestWarningElement.appendChild(document.createElement("a"));
+        auditStopRecordingLink.textContent = WI.UIString("Stop Audit");
+        auditStopRecordingLink.addEventListener("click", () => { WI.auditManager.stop(); });
 
         this._breakpointsDisabledWarningElement = document.createElement("div");
@@ -623 +633 @@
     _timelineCapturingWillStart(event)
     {
-        this._debuggerBreakpointsButtonItem.enabled = false;
-        this._debuggerPauseResumeButtonItem.enabled = false;
+        this._updateTemporarilyDisabledBreakpointsButtons();
 
         this.contentView.element.insertBefore(this._timelineRecordingWarningElement, this.contentView.element.firstChild);
@@ -632 +641 @@
     _timelineCapturingStopped(event)
     {
-        this._debuggerBreakpointsButtonItem.enabled = true;
-        this._debuggerPauseResumeButtonItem.enabled = true;
+        this._updateTemporarilyDisabledBreakpointsButtons();
 
         this._timelineRecordingWarningElement.remove();
@@ -639 +647 @@
     }
 
+    _handleAuditManagerTestScheduled(event)
+    {
+        this._updateTemporarilyDisabledBreakpointsButtons();
+
+        this.contentView.element.insertBefore(this._auditTestWarningElement, this.contentView.element.firstChild);
+        this._updateBreakpointsDisabledBanner();
+    }
+
+    _handleAuditManagerTestCompleted(event)
+    {
+        this._updateTemporarilyDisabledBreakpointsButtons();
+
+        this._auditTestWarningElement.remove();
+        this._updateBreakpointsDisabledBanner();
+    }
+
+    _updateTemporarilyDisabledBreakpointsButtons()
+    {
+        let breakpointsDisabledTemporarily = WI.debuggerManager.breakpointsDisabledTemporarily;
+        this._debuggerBreakpointsButtonItem.enabled = !breakpointsDisabledTemporarily;
+        this._debuggerPauseResumeButtonItem.enabled = !breakpointsDisabledTemporarily;
+    }
+
     _updateBreakpointsDisabledBanner()
     {
         let breakpointsEnabled = WI.debuggerManager.breakpointsEnabled;
         let timelineWarningShowing = !!this._timelineRecordingWarningElement.parentElement;
-
-        if (!breakpointsEnabled && !timelineWarningShowing)
+        let auditWarningShowing = !!this._auditTestWarningElement.parentElement;
+
+        if (!breakpointsEnabled && !timelineWarningShowing && !auditWarningShowing)
             this.contentView.element.insertBefore(this._breakpointsDisabledWarningElement, this.contentView.element.firstChild);
         else