Changeset 239649 in webkit

Timestamp:

Jan 4, 2019 5:23:52 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: subclasses of WI.ClusterContentView don't save/restore content views after the initial view
​https://bugs.webkit.org/show_bug.cgi?id=192451
<rdar://problem/46800958>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-01-04
Reviewed by Devin Rousso.

• UserInterface/Models/BackForwardEntry.js:

(WI.BackForwardEntry.prototype.prepareToHide):

• UserInterface/Views/ClusterContentView.js:

(WI.ClusterContentView.prototype.get shouldSaveStateOnHide):

• UserInterface/Views/ContentView.js:

(WI.ContentView.prototype.get shouldSaveStateOnHide):
Allow ClusterContentViews to save its state whenever its hidden,
this means it can be properly restored to the last state it had
instead of the initial state it was shown with.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Models/BackForwardEntry.js (modified) (1 diff)
• UserInterface/Views/ClusterContentView.js (modified) (1 diff)
• UserInterface/Views/ContentView.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: subclasses of WI.ClusterContentView don't save/restore content views after the initial view
+        https://bugs.webkit.org/show_bug.cgi?id=192451
+        <rdar://problem/46800958>
+
+        Reviewed by Devin Rousso.
+
+        * UserInterface/Models/BackForwardEntry.js:
+        (WI.BackForwardEntry.prototype.prepareToHide):
+        * UserInterface/Views/ClusterContentView.js:
+        (WI.ClusterContentView.prototype.get shouldSaveStateOnHide):
+        * UserInterface/Views/ContentView.js:
+        (WI.ContentView.prototype.get shouldSaveStateOnHide):
+        Allow ClusterContentViews to save its state whenever its hidden,
+        this means it can be properly restored to the last state it had
+        instead of the initial state it was shown with.
+
 2019-01-04  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Models/BackForwardEntry.js

@@ -94 +94 @@
 
         this._saveScrollPositions();
+
+        if (this._contentView.shouldSaveStateWhenHidden) {
+            this._cookie = {};
+            this._contentView.saveToCookie(this._cookie);
+        }
     }
 

trunk/Source/WebInspectorUI/UserInterface/Views/ClusterContentView.js

@@ -62 +62 @@
     }
 
+    get shouldSaveStateWhenHidden()
+    {
+        return true;
+    }
+
     shown()
     {

trunk/Source/WebInspectorUI/UserInterface/Views/ContentView.js

@@ -356 +356 @@
     }
 
+    get shouldSaveStateWhenHidden()
+    {
+        return false;
+    }
+
     get selectionPathComponents()
     {