Changeset 239757 in webkit
- Timestamp:
- Jan 8, 2019 5:11:08 PM (5 years ago)
- Location:
- trunk/Source/WebKit
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/ChangeLog
r239752 r239757 1 2019-01-08 Jiewen Tan <jiewen_tan@apple.com> 2 3 [Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky 4 https://bugs.webkit.org/show_bug.cgi?id=192061 5 6 Reviewed by Dewei Zhu. 7 8 Part 6. 9 10 Add some additional temporary logging info to determine if data is actually sent. 11 Once the bug is determined and fixed, we should remove all logging added in this patch. 12 13 * UIProcess/WebAuthentication/Mock/MockHidConnection.cpp: 14 (WebKit::MockHidConnection::send): 15 1 16 2019-01-08 Jiewen Tan <jiewen_tan@apple.com> 2 17 -
trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidConnection.cpp
r239752 r239757 71 71 void MockHidConnection::send(Vector<uint8_t>&& data, DataSentCallback&& callback) 72 72 { 73 // FIXME(192061): Remove all LOG_ERRORs. 74 LOG_ERROR("Sending data: Phase 1. Current time: %f.", MonotonicTime::now().secondsSinceEpoch().value()); 73 75 ASSERT(m_initialized); 74 76 auto task = makeBlockPtr([weakThis = makeWeakPtr(*this), data = WTFMove(data), callback = WTFMove(callback)]() mutable { 75 77 ASSERT(!RunLoop::isMain()); 78 LOG_ERROR("Sending data: Phase 2. Current time: %f.", MonotonicTime::now().secondsSinceEpoch().value()); 76 79 RunLoop::main().dispatch([weakThis, data = WTFMove(data), callback = WTFMove(callback)]() mutable { 80 LOG_ERROR("Sending data: Phase 3. Current time: %f.", MonotonicTime::now().secondsSinceEpoch().value()); 77 81 if (!weakThis) { 78 82 callback(DataSent::No); … … 80 84 } 81 85 86 LOG_ERROR("Sending data: Phase 4. Current time: %f.", MonotonicTime::now().secondsSinceEpoch().value()); 82 87 weakThis->assembleRequest(WTFMove(data)); 83 88 89 LOG_ERROR("Sending data: Phase 5. Current time: %f.", MonotonicTime::now().secondsSinceEpoch().value()); 84 90 auto sent = DataSent::Yes; 85 91 if (weakThis->stagesMatch() && weakThis->m_configuration.hid->error == Mock::Error::DataNotSent)
Note: See TracChangeset
for help on using the changeset viewer.