Changeset 239757 in webkit


Ignore:
Timestamp:
Jan 8, 2019 5:11:08 PM (5 years ago)
Author:
jiewen_tan@apple.com
Message:

[Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=192061

Reviewed by Dewei Zhu.

Part 6.

Add some additional temporary logging info to determine if data is actually sent.
Once the bug is determined and fixed, we should remove all logging added in this patch.

  • UIProcess/WebAuthentication/Mock/MockHidConnection.cpp:

(WebKit::MockHidConnection::send):

Location:
trunk/Source/WebKit
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/ChangeLog

    r239752 r239757  
     12019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
     2
     3        [Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
     4        https://bugs.webkit.org/show_bug.cgi?id=192061
     5
     6        Reviewed by Dewei Zhu.
     7
     8        Part 6.
     9
     10        Add some additional temporary logging info to determine if data is actually sent.
     11        Once the bug is determined and fixed, we should remove all logging added in this patch.
     12
     13        * UIProcess/WebAuthentication/Mock/MockHidConnection.cpp:
     14        (WebKit::MockHidConnection::send):
     15
    1162019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
    217
  • trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidConnection.cpp

    r239752 r239757  
    7171void MockHidConnection::send(Vector<uint8_t>&& data, DataSentCallback&& callback)
    7272{
     73    // FIXME(192061): Remove all LOG_ERRORs.
     74    LOG_ERROR("Sending data: Phase 1. Current time: %f.", MonotonicTime::now().secondsSinceEpoch().value());
    7375    ASSERT(m_initialized);
    7476    auto task = makeBlockPtr([weakThis = makeWeakPtr(*this), data = WTFMove(data), callback = WTFMove(callback)]() mutable {
    7577        ASSERT(!RunLoop::isMain());
     78        LOG_ERROR("Sending data: Phase 2. Current time: %f.", MonotonicTime::now().secondsSinceEpoch().value());
    7679        RunLoop::main().dispatch([weakThis, data = WTFMove(data), callback = WTFMove(callback)]() mutable {
     80            LOG_ERROR("Sending data: Phase 3. Current time: %f.", MonotonicTime::now().secondsSinceEpoch().value());
    7781            if (!weakThis) {
    7882                callback(DataSent::No);
     
    8084            }
    8185
     86            LOG_ERROR("Sending data: Phase 4. Current time: %f.", MonotonicTime::now().secondsSinceEpoch().value());
    8287            weakThis->assembleRequest(WTFMove(data));
    8388
     89            LOG_ERROR("Sending data: Phase 5. Current time: %f.", MonotonicTime::now().secondsSinceEpoch().value());
    8490            auto sent = DataSent::Yes;
    8591            if (weakThis->stagesMatch() && weakThis->m_configuration.hid->error == Mock::Error::DataNotSent)
Note: See TracChangeset for help on using the changeset viewer.