Changeset 240027 in webkit

Timestamp:

Jan 15, 2019, 7:35:59 PM (7 years ago)

Author:

rniwa@webkit.org

Message:

VisualViewport API should be updated upon opening of keyboard
​https://bugs.webkit.org/show_bug.cgi?id=193475

Reviewed by Simon Fraser.

Source/WebCore:

Added a function to update the visual viewport API and schedule a resize event to FrameView.

Test: fast/visual-viewport/ios/resize-event-for-keyboard.html

• page/FrameView.cpp:

(WebCore::FrameView::didUpdateViewportOverrideRects):

• page/FrameView.h:

Source/WebKit:

The bug was caused by the changes to unobscuredContentRectRespectingInputViewBounds not updating the visual viewport
unless it caused a layout to happen. Added a code to update the visual viewport in WebPage::updateVisibleContentRects.

Also fixed the bug that VisibleContentRectUpdateInfo::operator== was not checking differences in
unobscuredContentRectRespectingInputViewBounds which resulted in the visual viewport override not getting updated
while the keyboard is getting brought up.

• Shared/VisibleContentRectUpdateInfo.h:

(WebKit::operator==):

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::updateVisibleContentRects):

LayoutTests:

Added a regression test.

• fast/visual-viewport/ios/resize-event-for-keyboard-expected.txt: Added.
• fast/visual-viewport/ios/resize-event-for-keyboard.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/visual-viewport/ios/resize-event-for-keyboard-expected.txt (added)
• LayoutTests/fast/visual-viewport/ios/resize-event-for-keyboard.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/FrameView.cpp (modified) (1 diff)
• Source/WebCore/page/FrameView.h (modified) (1 diff)
• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/Shared/VisibleContentRectUpdateInfo.h (modified) (1 diff)
• Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-01-15  Ryosuke Niwa  <rniwa@webkit.org>
+
+        VisualViewport API should be updated upon opening of keyboard
+        https://bugs.webkit.org/show_bug.cgi?id=193475
+
+        Reviewed by Simon Fraser.
+
+        Added a regression test.
+
+        * fast/visual-viewport/ios/resize-event-for-keyboard-expected.txt: Added.
+        * fast/visual-viewport/ios/resize-event-for-keyboard.html: Added.
+
 2019-01-15  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-01-15  Ryosuke Niwa  <rniwa@webkit.org>
+
+        VisualViewport API should be updated upon opening of keyboard
+        https://bugs.webkit.org/show_bug.cgi?id=193475
+
+        Reviewed by Simon Fraser.
+
+        Added a function to update the visual viewport API and schedule a resize event to FrameView.
+
+        Test: fast/visual-viewport/ios/resize-event-for-keyboard.html
+
+        * page/FrameView.cpp:
+        (WebCore::FrameView::didUpdateViewportOverrideRects):
+        * page/FrameView.h:
+
 2019-01-15  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Source/WebCore/page/FrameView.cpp

@@ -2798 +2798 @@
 #if PLATFORM(IOS_FAMILY)
 
+void FrameView::didUpdateViewportOverrideRects()
+{
+    if (!frame().settings().visualViewportAPIEnabled())
+        return;
+
+    if (auto* window = frame().window())
+        window->visualViewport().update();
+}
+
 void FrameView::unobscuredContentSizeChanged()
 {

trunk/Source/WebCore/page/FrameView.h

@@ -591 +591 @@
     TiledBacking::Scrollability computeScrollability() const;
 
+#if PLATFORM(IOS_FAMILY)
+    WEBCORE_EXPORT void didUpdateViewportOverrideRects();
+#endif
+
     void addPaintPendingMilestones(OptionSet<LayoutMilestone>);
     void firePaintRelatedMilestonesIfNeeded();

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-01-15  Ryosuke Niwa  <rniwa@webkit.org>
+
+        VisualViewport API should be updated upon opening of keyboard
+        https://bugs.webkit.org/show_bug.cgi?id=193475
+
+        Reviewed by Simon Fraser.
+
+        The bug was caused by the changes to unobscuredContentRectRespectingInputViewBounds not updating the visual viewport
+        unless it caused a layout to happen. Added a code to update the visual viewport in WebPage::updateVisibleContentRects.
+
+        Also fixed the bug that VisibleContentRectUpdateInfo::operator== was not checking differences in
+        unobscuredContentRectRespectingInputViewBounds which resulted in the visual viewport override not getting updated
+        while the keyboard is getting brought up.
+
+        * Shared/VisibleContentRectUpdateInfo.h:
+        (WebKit::operator==):
+        * WebProcess/WebPage/ios/WebPageIOS.mm:
+        (WebKit::WebPage::updateVisibleContentRects):
+
 2019-01-15  Megan Gardner  <megan_gardner@apple.com>
 

trunk/Source/WebKit/Shared/VisibleContentRectUpdateInfo.h

@@ -122 +122 @@
         && a.exposedContentRect() == b.exposedContentRect()
         && a.unobscuredContentRect() == b.unobscuredContentRect()
+        && a.unobscuredContentRectRespectingInputViewBounds() == b.unobscuredContentRectRespectingInputViewBounds()
         && a.customFixedPositionRect() == b.customFixedPositionRect()
         && a.obscuredInsets() == b.obscuredInsets()

trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm

@@ -3042 +3042 @@
                 sendPartialEditorStateAndSchedulePostLayoutUpdate();
             }
+
+            frameView.didUpdateViewportOverrideRects();
         } else
             frameView.setCustomFixedPositionLayoutRect(enclosingIntRect(visibleContentRectUpdateInfo.customFixedPositionRect()));