Changeset 24004 in webkit


Ignore:
Timestamp:
Jul 4, 2007 11:08:56 PM (17 years ago)
Author:
bdash
Message:

2007-07-04 Matt Perry <mpComplete@gmail.com>

Fix for http://bugs.webkit.org/show_bug.cgi?id=13400
Bug 13400: REGRESSION (r20809-20814): No back entry created for navigations created by assigning to document.location
<rdar://problem/5153025>

Treat userGesture as always true for setLocation, forcing a back/forward
entry to be created.

  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::setLocation):

2007-07-04 Matt Perry <mpComplete@gmail.com>

Test for http://bugs.webkit.org/show_bug.cgi?id=13400
Bug 13400: REGRESSION (r20809-20814): No back entry created for navigations created by assigning to document.location
<rdar://problem/5153025>

Test that assigning to document.location in various ways adds an
item to the back/forward list.

  • http/tests/navigation/document-location-click-expected.txt: Added.
  • http/tests/navigation/document-location-click-timeout-expected.txt: Added.
  • http/tests/navigation/document-location-click-timeout.html: Added.
  • http/tests/navigation/document-location-click.html: Added.
  • http/tests/navigation/document-location-mouseover-expected.txt: Added.
  • http/tests/navigation/document-location-mouseover.html: Added.
  • http/tests/navigation/document-location-onload-expected.txt: Added.
  • http/tests/navigation/document-location-onload.html: Added.
  • http/tests/navigation/resources/document-location.js: Added.
Location:
trunk
Files:
9 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r23993 r24004  
     12007-07-04  Matt Perry  <mpComplete@gmail.com>
     2
     3        Test for http://bugs.webkit.org/show_bug.cgi?id=13400
     4        Bug 13400: REGRESSION (r20809-20814): No back entry created for navigations created by assigning to document.location
     5        <rdar://problem/5153025>
     6
     7        Test that assigning to document.location in various ways adds an
     8        item to the back/forward list.
     9
     10        * http/tests/navigation/document-location-click-expected.txt: Added.
     11        * http/tests/navigation/document-location-click-timeout-expected.txt: Added.
     12        * http/tests/navigation/document-location-click-timeout.html: Added.
     13        * http/tests/navigation/document-location-click.html: Added.
     14        * http/tests/navigation/document-location-mouseover-expected.txt: Added.
     15        * http/tests/navigation/document-location-mouseover.html: Added.
     16        * http/tests/navigation/document-location-onload-expected.txt: Added.
     17        * http/tests/navigation/document-location-onload.html: Added.
     18        * http/tests/navigation/resources/document-location.js: Added.
     19
    1202007-07-04  Darin Adler  <darin@apple.com>
    221
  • trunk/WebCore/ChangeLog

    r24003 r24004  
     12007-07-04  Matt Perry  <mpComplete@gmail.com>
     2
     3        Fix for http://bugs.webkit.org/show_bug.cgi?id=13400
     4        Bug 13400: REGRESSION (r20809-20814): No back entry created for navigations created by assigning to document.location
     5        <rdar://problem/5153025>
     6
     7        Treat userGesture as always true for setLocation, forcing a back/forward
     8        entry to be created.
     9
     10        * bindings/js/JSHTMLDocumentCustom.cpp:
     11        (WebCore::JSHTMLDocument::setLocation):
     12
    1132007-07-04  Adam Roben  <aroben@apple.com>
    214
  • trunk/WebCore/bindings/js/JSHTMLDocumentCustom.cpp

    r22080 r24004  
    116116        str = activeFrame->document()->completeURL(str);
    117117
    118     // We want a new history item if this JS was called via a user gesture
    119     bool userGesture = static_cast<ScriptInterpreter*>(exec->dynamicInterpreter())->wasRunByUserGesture();
    120     frame->loader()->scheduleLocationChange(str, activeFrame->loader()->outgoingReferrer(), !userGesture);
     118    // We always want a new history item when assigning to document.location.
     119    frame->loader()->scheduleLocationChange(str, activeFrame->loader()->outgoingReferrer(), false, true);
    121120}
    122121
Note: See TracChangeset for help on using the changeset viewer.