Changeset 24014 in webkit

Timestamp:

Jul 5, 2007 6:43:44 AM (17 years ago)

Author:

bdash

Message:

2007-07-05 Alp Toker <​alp.toker@collabora.co.uk>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=14513
Cairo animated GIF support is broken

Implement ImageSource::frameIsCompleteAtIndex() to enable animated GIFs.

• platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::frameIsCompleteAtIndex):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/cairo/ImageSourceCairo.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-07-05  Alp Toker  <alp.toker@collabora.co.uk>
+
+        Reviewed by Mark Rowe.
+
+        http://bugs.webkit.org/show_bug.cgi?id=14513
+        Cairo animated GIF support is broken
+
+        Implement ImageSource::frameIsCompleteAtIndex() to enable animated GIFs.
+
+        * platform/graphics/cairo/ImageSourceCairo.cpp:
+        (WebCore::ImageSource::frameIsCompleteAtIndex):
+
 2007-07-04  Matt Perry  <mpComplete@gmail.com>
 

trunk/WebCore/platform/graphics/cairo/ImageSourceCairo.cpp

@@ -1 +1 @@
 /*
  * Copyright (C) 2006 Apple Computer, Inc.  All rights reserved.
+ * Copyright (C) 2007 Alp Toker <alp.toker@collabora.co.uk>
  *
  * Redistribution and use in source and binary forms, with or without
@@ -164 +165 @@
 }
 
-bool ImageSource::frameIsCompleteAtIndex(size_t)
-{
-    // FIXME: write me. Returning false makes the animation not run
-    return false;
+bool ImageSource::frameIsCompleteAtIndex(size_t index)
+{
+    if (!m_decoder)
+        return false;
+
+    RGBA32Buffer* buffer = m_decoder->frameBufferAtIndex(index);
+    return buffer && buffer->status() == RGBA32Buffer::FrameComplete;
 }