Changeset 24022 in webkit

Timestamp:

Jul 5, 2007 1:16:06 PM (17 years ago)

Author:

aroben

Message:

Fix Bug 14143: Tooltips not displayed on Windows
​http://bugs.webkit.org/show_bug.cgi?id=14143
<rdar://problem/4719799>

Reviewed by Oliver.

• WebChromeClient.cpp:

(WebChromeClient::setToolTip): Call up to WebView.

• WebView.cpp:

(WebView::WebView): Initialize m_toolTipHwnd member.
(WebView::initWithFrame): Set up the tool tip window.
(initCommonControls): Added.
(WebView::initializeToolTipWindow): Added.
(WebView::setToolTip): Set the tool tip text and enable/disable the
tool tip.

• WebView.h: Added/updated declarations.

Location:

trunk/WebKit/win

Files:

• ChangeLog (modified) (1 diff)
• WebChromeClient.cpp (modified) (1 diff)
• WebView.cpp (modified) (4 diffs)
• WebView.h (modified) (3 diffs)

trunk/WebKit/win/ChangeLog

@@ +1 @@
+2007-07-05  Adam Roben  <aroben@apple.com>
+
+        Fix Bug 14143: Tooltips not displayed on Windows
+        http://bugs.webkit.org/show_bug.cgi?id=14143
+        <rdar://problem/4719799>
+
+        Reviewed by Oliver.
+
+        * WebChromeClient.cpp:
+        (WebChromeClient::setToolTip): Call up to WebView.
+        * WebView.cpp:
+        (WebView::WebView): Initialize m_toolTipHwnd member.
+        (WebView::initWithFrame): Set up the tool tip window.
+        (initCommonControls): Added.
+        (WebView::initializeToolTipWindow): Added.
+        (WebView::setToolTip): Set the tool tip text and enable/disable the
+        tool tip.
+        * WebView.h: Added/updated declarations.
+
 2007-07-04  Adam Roben  <aroben@apple.com>
 

trunk/WebKit/win/WebChromeClient.cpp

@@ -439 +439 @@
 }
 
-void WebChromeClient::setToolTip(const String&)
-{
-}
+void WebChromeClient::setToolTip(const String& toolTip)
+{
+    m_webView->setToolTip(toolTip);
+}

trunk/WebKit/win/WebView.cpp

@@ -102 +102 @@
 const int WM_VISTA_MOUSEHWHEEL = 0x020E;
 
+static const int maxToolTipWidth = 250;
+
 static ATOM registerWebView();
 static LRESULT CALLBACK WebViewWndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam);
@@ -133 +135 @@
 , m_smartInsertDeleteEnabled(false)
 , m_didClose(false)
+, m_toolTipHwnd(0)
 {
     KJS::Collector::registerAsMainThread();
@@ -1734 +1737 @@
 
     initializeCacheSizesIfNecessary();
+    initializeToolTipWindow();
 
     // Update WebCore with preferences.  These values will either come from an archived WebPreferences,
@@ -1762 +1766 @@
 }
 
+static bool initCommonControls()
+{
+    static bool haveInitialized = false;
+    if (haveInitialized)
+        return true;
+
+    INITCOMMONCONTROLSEX init;
+    init.dwSize = sizeof(init);
+    init.dwICC = ICC_TREEVIEW_CLASSES;
+    haveInitialized = !!::InitCommonControlsEx(&init);
+    return haveInitialized;
+}
+
+void WebView::initializeToolTipWindow()
+{
+    if (!initCommonControls())
+        return;
+
+    m_toolTipHwnd = CreateWindowEx(0, TOOLTIPS_CLASS, 0, WS_POPUP | TTS_NOPREFIX | TTS_ALWAYSTIP,
+                                   CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT,
+                                   m_viewWindow, 0, 0, 0);
+    if (!m_toolTipHwnd)
+        return;
+
+    TOOLINFO info = {0};
+    info.cbSize = sizeof(info);
+    info.uFlags = TTF_IDISHWND | TTF_SUBCLASS ;
+    info.uId = reinterpret_cast<UINT_PTR>(m_viewWindow);
+
+    ::SendMessage(m_toolTipHwnd, TTM_ADDTOOL, 0, reinterpret_cast<LPARAM>(&info));
+    ::SendMessage(m_toolTipHwnd, TTM_SETMAXTIPWIDTH, 0, maxToolTipWidth);
+
+    ::SetWindowPos(m_toolTipHwnd, HWND_TOPMOST, 0, 0, 0, 0, SWP_NOMOVE | SWP_NOSIZE | SWP_NOACTIVATE);
+}
+
+void WebView::setToolTip(const String& toolTip)
+{
+    if (!m_toolTipHwnd)
+        return;
+
+    if (toolTip == m_toolTip)
+        return;
+
+    m_toolTip = toolTip;
+
+    if (!m_toolTip.isEmpty()) {
+        TOOLINFO info = {0};
+        info.cbSize = sizeof(info);
+        info.uFlags = TTF_IDISHWND;
+        info.uId = reinterpret_cast<UINT_PTR>(m_viewWindow);
+        info.lpszText = _wcsdup(m_toolTip.charactersWithNullTermination());
+        ::SendMessage(m_toolTipHwnd, TTM_UPDATETIPTEXT, 0, reinterpret_cast<LPARAM>(&info));
+    }
+
+    ::SendMessage(m_toolTipHwnd, TTM_ACTIVATE, !m_toolTip.isEmpty(), 0);
+}
 
 HRESULT STDMETHODCALLTYPE WebView::setUIDelegate( 

trunk/WebKit/win/WebView.h

@@ -653 +653 @@
     bool isPainting() const { return m_paintCount > 0; }
 
+    void setToolTip(const WebCore::String&);
+
 protected:
     static bool allowSiteSpecificHacks() { return s_allowSiteSpecificHacks; }
@@ -658 +660 @@
     bool continuousCheckingAllowed();
     void initializeCacheSizesIfNecessary();
+    void initializeToolTipWindow();
 
     ULONG m_refCount;
@@ -699 +702 @@
     bool m_didClose;
 
+    HWND m_toolTipHwnd;
+    WebCore::String m_toolTip;
+
     static bool s_allowSiteSpecificHacks;
 };