Changeset 240351 in webkit

Timestamp:

Jan 23, 2019 11:29:18 AM (5 years ago)

Author:

Devin Rousso

Message:

WebInspector: Confusingly nested events in the timeline for Mutation Observers
​https://bugs.webkit.org/show_bug.cgi?id=192884
<rdar://problem/46854178>

Reviewed by Joseph Pecoraro.

If a microtask event (e.g. ObserverCallback) is contained within a EvaluatedScript
event, move that microtask event to be a sibling of the EvaluateScript, subtracting the
microtask's time taken from the EvaluateScript's time. If there are no other children
after this move, then remove the EvaluateScript altogether.

• UserInterface/Controllers/TimelineManager.js:

(WI.TimelineManager.prototype.eventRecorded.fixMicrotaskPlacement): Added.
(WI.TimelineManager.prototype.eventRecorded):
(WI.TimelineManager.prototype._mergeScriptProfileRecords):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Controllers/TimelineManager.js (modified) (4 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-01-23  Devin Rousso  <drousso@apple.com>
+
+        WebInspector: Confusingly nested events in the timeline for Mutation Observers
+        https://bugs.webkit.org/show_bug.cgi?id=192884
+        <rdar://problem/46854178>
+
+        Reviewed by Joseph Pecoraro.
+
+        If a microtask event (e.g. `ObserverCallback`) is contained within a `EvaluatedScript`
+        event, move that microtask event to be a sibling of the `EvaluateScript`, subtracting the
+        microtask's time taken from the `EvaluateScript`'s time. If there are no other children
+        after this move, then remove the `EvaluateScript` altogether.
+
+        * UserInterface/Controllers/TimelineManager.js:
+        (WI.TimelineManager.prototype.eventRecorded.fixMicrotaskPlacement): Added.
+        (WI.TimelineManager.prototype.eventRecorded):
+        (WI.TimelineManager.prototype._mergeScriptProfileRecords):
+
 2019-01-23  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js

@@ -357 +357 @@
             return;
 
+        function fixMicrotaskPlacement(children)
+        {
+            let newChildren = [];
+            for (let child of children) {
+                if (child.type === TimelineAgent.EventType.EvaluateScript) {
+                    let [microtasks, events] = child.children.partition((grandchild) => {
+                        return grandchild.type === TimelineAgent.EventType.ObserverCallback;
+                    });
+
+                    if (events.length) {
+                        child.children = events;
+                        child.endTime = events.lastValue.endTime;
+                        newChildren.push(child);
+                    }
+
+                    newChildren = newChildren.concat(microtasks);
+                } else
+                    newChildren.push(child);
+            }
+            return newChildren;
+        }
+
         var records = [];
 
@@ -377 +399 @@
 
                 if (recordPayload.children && recordPayload.children.length)
-                    stack.push({array: recordPayload.children, parent: recordPayload, parentRecord: record || entry.parentRecord, index: 0});
+                    stack.push({array: fixMicrotaskPlacement(recordPayload.children), parent: recordPayload, parentRecord: record || entry.parentRecord, index: 0});
                 ++entry.index;
             } else
@@ -1056 +1078 @@
                 profilerRecord = nextScriptProfilerRecord();
 
+                let firstProfilerRecordForWebRecord = null;
+
                 // If there are more script profile records in the same time interval, add them
                 // as individual script evaluated records with profiles. This can happen with
@@ -1061 +1085 @@
                 // FIXME: <https://webkit.org/b/152903> Web Inspector: Timeline Cleanup: Better Timeline Record for Microtask Checkpoints
                 while (profilerRecord && recordEnclosesRecord(webRecord, profilerRecord)) {
+                    if (!firstProfilerRecordForWebRecord)
+                        firstProfilerRecordForWebRecord = profilerRecord;
+
                     this._addRecord(profilerRecord);
                     profilerRecord = nextScriptProfilerRecord();
                 }
+
+                if (firstProfilerRecordForWebRecord)
+                    webRecord.endTime = firstProfilerRecordForWebRecord.startTime;
 
                 webRecord = nextWebTimelineRecord();