Changeset 240438 in webkit

Timestamp:

Jan 24, 2019 9:30:10 AM (5 years ago)

Author:

Michael Catanzaro

Message:

test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
​https://bugs.webkit.org/show_bug.cgi?id=193746

Reviewed by Youenn Fablet.

It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
so we'd best just not call it.

• Scripts/webkitpy/w3c/test_exporter.py:

(WebPlatformTestExporter.create_branch_with_patch):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/w3c/test_exporter.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
+        https://bugs.webkit.org/show_bug.cgi?id=193746
+
+        Reviewed by Youenn Fablet.
+
+        It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
+        so we'd best just not call it.
+
+        * Scripts/webkitpy/w3c/test_exporter.py:
+        (WebPlatformTestExporter.create_branch_with_patch):
+
 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
 

trunk/Tools/Scripts/webkitpy/w3c/test_exporter.py

@@ -294 +294 @@
         except Exception as e:
             _log.warning(e)
-            self._git.apply_mail_patch(['--abort'])
             return False
         self._git.commit(['-a', '-m', self._commit_message])