Changeset 240440 in webkit

Timestamp:

Jan 24, 2019 10:26:05 AM (5 years ago)

Author:

Jonathan Bedard

Message:

webkitpy: Missing PID in crashlog name should not be fatal
​https://bugs.webkit.org/show_bug.cgi?id=193771

If we can't determine the PID of a crashlog, just ignore the crashlog instead
of raising an exception.

Reviewed by Lucas Forschler.

• Scripts/webkitpy/port/darwin.py:

(DarwinPort._merge_crash_logs):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/port/darwin.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-01-24  Jonathan Bedard  <jbedard@apple.com>
+
+        webkitpy: Missing PID in crashlog name should not be fatal
+        https://bugs.webkit.org/show_bug.cgi?id=193771
+
+        If we can't determine the PID of a crashlog, just ignore the crashlog instead
+        of raising an exception.
+
+        Reviewed by Lucas Forschler.
+
+        * Scripts/webkitpy/port/darwin.py:
+        (DarwinPort._merge_crash_logs):
+
 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
 

trunk/Tools/Scripts/webkitpy/port/darwin.py

@@ -105 +105 @@
                     process_name = test.split('-')[0]
                     pid = int(test.split('-')[1])
-            except IndexError:
+            except IndexError, ValueError:
                 continue
             if not any(entry[1] == process_name and entry[2] == pid for entry in crashed_processes):