Changeset 240489 in webkit

Timestamp:

Jan 25, 2019 11:39:38 AM (5 years ago)

Author:

Devin Rousso

Message:

Web Inspector: REGRESSION (r237808): offscreen path warning doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=193830

Reviewed by Matt Baker.

• UserInterface/Models/RecordingAction.js:

(WI.RecordingAction.prototype.process):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Models/RecordingAction.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-01-25  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: REGRESSION (r237808): offscreen path warning doesn't work
+        https://bugs.webkit.org/show_bug.cgi?id=193830
+
+        Reviewed by Matt Baker.
+
+        * UserInterface/Models/RecordingAction.js:
+        (WI.RecordingAction.prototype.process):
+
 2019-01-25  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Models/RecordingAction.js

@@ -261 +261 @@
 
             if (WI.ImageUtilities.supportsCanvasPathDebugging()) {
-                let currentX = currentState.currentX;
-                let invalidX = (currentX < 0 || currentX >= context.canvas.width) && (!lastState || currentX !== lastState.currentX);
-
-                let currentY = currentState.currentY;
-                let invalidY = (currentY < 0 || currentY >= context.canvas.height) && (!lastState || currentY !== lastState.currentY);
+                let currentX = currentState.get("currentX");
+                let invalidX = (currentX < 0 || currentX >= context.canvas.width) && (!lastState || currentX !== lastState.get("currentX"));
+
+                let currentY = currentState.get("currentY");
+                let invalidY = (currentY < 0 || currentY >= context.canvas.height) && (!lastState || currentY !== lastState.get("currentY"));
 
                 if (invalidX || invalidY)