Changeset 240525 in webkit


Ignore:
Timestamp:
Jan 25, 2019 3:52:51 PM (5 years ago)
Author:
Keith Rollin
Message:

Update Xcode projects with "Check .xcfilelists" build phase
https://bugs.webkit.org/show_bug.cgi?id=193790
<rdar://problem/47201374>

Reviewed by Alex Christensen.

Support for XCBuild includes specifying inputs and outputs to various
Run Script build phases. These inputs and outputs are specified as
.xcfilelist files. Once created, these .xcfilelist files need to be
kept up-to-date. In order to check that they are up-to-date or not,
add an Xcode build step that invokes an external script that performs
the checking. If the .xcfilelists are found to be out-of-date, update
them, halt the build, and instruct the developer to restart the build
with up-to-date files.

At this time, the checking and regenerating is performed only if the
WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
who want to use this facility can set this variable and test out the
checking/regenerating. Once it seems like there are no egregious
issues that upset a developer's workflow, we'll unconditionally enable
this facility.

Source/JavaScriptCore:

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Scripts/check-xcfilelists.sh: Added.

Source/WebCore:

No new tests since there should be no observable behavior difference.

  • Scripts/check-xcfilelists.sh: Added.
  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit:

  • Scripts/check-xcfilelists.sh: Added.
  • WebKit.xcodeproj/project.pbxproj:

Tools:

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
  • WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
Location:
trunk
Files:
5 added
9 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r240522 r240525  
     12019-01-25  Keith Rollin  <krollin@apple.com>
     2
     3        Update Xcode projects with "Check .xcfilelists" build phase
     4        https://bugs.webkit.org/show_bug.cgi?id=193790
     5        <rdar://problem/47201374>
     6
     7        Reviewed by Alex Christensen.
     8
     9        Support for XCBuild includes specifying inputs and outputs to various
     10        Run Script build phases. These inputs and outputs are specified as
     11        .xcfilelist files. Once created, these .xcfilelist files need to be
     12        kept up-to-date. In order to check that they are up-to-date or not,
     13        add an Xcode build step that invokes an external script that performs
     14        the checking. If the .xcfilelists are found to be out-of-date, update
     15        them, halt the build, and instruct the developer to restart the build
     16        with up-to-date files.
     17
     18        At this time, the checking and regenerating is performed only if the
     19        WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
     20        who want to use this facility can set this variable and test out the
     21        checking/regenerating. Once it seems like there are no egregious
     22        issues that upset a developer's workflow, we'll unconditionally enable
     23        this facility.
     24
     25        * JavaScriptCore.xcodeproj/project.pbxproj:
     26        * Scripts/check-xcfilelists.sh: Added.
     27
    1282019-01-25  Joseph Pecoraro  <pecoraro@apple.com>
    229
  • trunk/Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

    r240517 r240525  
    1002310023                                A55DEAA416703DF7003DB841 /* Check For Inappropriate Macros in External Headers */,
    1002410024                                1A02D9A81B34A882000D1522 /* Add Symlink in /System/Library/PrivateFrameworks */,
     10025                                53609F9021DFFA9C008FA60A /* Check .xcfilelists */,
    1002510026                        );
    1002610027                        buildRules = (
     
    1023810239                        shellPath = /bin/sh;
    1023910240                        shellScript = "eval \"${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}\"\n";
     10241                };
     10242                53609F9021DFFA9C008FA60A /* Check .xcfilelists */ = {
     10243                        isa = PBXShellScriptBuildPhase;
     10244                        buildActionMask = 2147483647;
     10245                        files = (
     10246                        );
     10247                        inputFileListPaths = (
     10248                        );
     10249                        inputPaths = (
     10250                        );
     10251                        name = "Check .xcfilelists";
     10252                        outputFileListPaths = (
     10253                        );
     10254                        outputPaths = (
     10255                        );
     10256                        runOnlyForDeploymentPostprocessing = 0;
     10257                        shellPath = /bin/sh;
     10258                        shellScript = "Scripts/check-xcfilelists.sh\n";
    1024010259                };
    1024110260                53B4BD091F68AF8900D2BEA3 /* Generate Unified Sources */ = {
  • trunk/Source/WebCore/ChangeLog

    r240522 r240525  
     12019-01-25  Keith Rollin  <krollin@apple.com>
     2
     3        Update Xcode projects with "Check .xcfilelists" build phase
     4        https://bugs.webkit.org/show_bug.cgi?id=193790
     5        <rdar://problem/47201374>
     6
     7        Reviewed by Alex Christensen.
     8
     9        Support for XCBuild includes specifying inputs and outputs to various
     10        Run Script build phases. These inputs and outputs are specified as
     11        .xcfilelist files. Once created, these .xcfilelist files need to be
     12        kept up-to-date. In order to check that they are up-to-date or not,
     13        add an Xcode build step that invokes an external script that performs
     14        the checking. If the .xcfilelists are found to be out-of-date, update
     15        them, halt the build, and instruct the developer to restart the build
     16        with up-to-date files.
     17
     18        At this time, the checking and regenerating is performed only if the
     19        WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
     20        who want to use this facility can set this variable and test out the
     21        checking/regenerating. Once it seems like there are no egregious
     22        issues that upset a developer's workflow, we'll unconditionally enable
     23        this facility.
     24
     25        No new tests since there should be no observable behavior difference.
     26
     27        * Scripts/check-xcfilelists.sh: Added.
     28        * WebCore.xcodeproj/project.pbxproj:
     29
    1302019-01-25  Joseph Pecoraro  <pecoraro@apple.com>
    231
  • trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

    r240517 r240525  
    3242432424                                5DF50887116F3077005202AB /* Check For Inappropriate Files In Framework */,
    3242532425                                71D6AA381DA4E69400B23969 /* Copy modern media controls code and assets */,
     32426                                5379C7AA21E5287100E4A8F6 /* Check .xcfilelists */,
    3242632427                        );
    3242732428                        buildRules = (
     
    3260232603                        shellPath = /bin/sh;
    3260332604                        shellScript = "Scripts/generate-unified-sources.sh\n";
     32605                };
     32606                5379C7AA21E5287100E4A8F6 /* Check .xcfilelists */ = {
     32607                        isa = PBXShellScriptBuildPhase;
     32608                        buildActionMask = 2147483647;
     32609                        files = (
     32610                        );
     32611                        inputFileListPaths = (
     32612                        );
     32613                        inputPaths = (
     32614                        );
     32615                        name = "Check .xcfilelists";
     32616                        outputFileListPaths = (
     32617                        );
     32618                        outputPaths = (
     32619                        );
     32620                        runOnlyForDeploymentPostprocessing = 0;
     32621                        shellPath = /bin/sh;
     32622                        shellScript = "Scripts/check-xcfilelists.sh\n";
    3260432623                };
    3260532624                5D0D540D0E9862F60029E223 /* Check For Weak VTables and Externals */ = {
  • trunk/Source/WebKit/ChangeLog

    r240520 r240525  
     12019-01-25  Keith Rollin  <krollin@apple.com>
     2
     3        Update Xcode projects with "Check .xcfilelists" build phase
     4        https://bugs.webkit.org/show_bug.cgi?id=193790
     5        <rdar://problem/47201374>
     6
     7        Reviewed by Alex Christensen.
     8
     9        Support for XCBuild includes specifying inputs and outputs to various
     10        Run Script build phases. These inputs and outputs are specified as
     11        .xcfilelist files. Once created, these .xcfilelist files need to be
     12        kept up-to-date. In order to check that they are up-to-date or not,
     13        add an Xcode build step that invokes an external script that performs
     14        the checking. If the .xcfilelists are found to be out-of-date, update
     15        them, halt the build, and instruct the developer to restart the build
     16        with up-to-date files.
     17
     18        At this time, the checking and regenerating is performed only if the
     19        WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
     20        who want to use this facility can set this variable and test out the
     21        checking/regenerating. Once it seems like there are no egregious
     22        issues that upset a developer's workflow, we'll unconditionally enable
     23        this facility.
     24
     25        * Scripts/check-xcfilelists.sh: Added.
     26        * WebKit.xcodeproj/project.pbxproj:
     27
    1282019-01-25  Alex Christensen  <achristensen@webkit.org>
    229
  • trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj

    r240517 r240525  
    1004910049                                A55DEAA61670402E003DB841 /* Check For Inappropriate Macros in External Headers */,
    1005010050                                1A2180161B5454620046AEC4 /* Add Symlink in /System/Library/PrivateFrameworks */,
     10051                                5379C7AC21E5288500E4A8F6 /* Check .xcfilelists */,
    1005110052                        );
    1005210053                        buildRules = (
     
    1048310484                        shellPath = /bin/sh;
    1048410485                        shellScript = "eval \"${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}\"\n";
     10486                };
     10487                5379C7AC21E5288500E4A8F6 /* Check .xcfilelists */ = {
     10488                        isa = PBXShellScriptBuildPhase;
     10489                        buildActionMask = 2147483647;
     10490                        files = (
     10491                        );
     10492                        inputFileListPaths = (
     10493                        );
     10494                        inputPaths = (
     10495                        );
     10496                        name = "Check .xcfilelists";
     10497                        outputFileListPaths = (
     10498                        );
     10499                        outputPaths = (
     10500                        );
     10501                        runOnlyForDeploymentPostprocessing = 0;
     10502                        shellPath = /bin/sh;
     10503                        shellScript = "Scripts/check-xcfilelists.sh\n";
    1048510504                };
    1048610505                5DF408C5131DD46700130071 /* Check For Weak VTables and Externals */ = {
  • trunk/Tools/ChangeLog

    r240517 r240525  
     12019-01-25  Keith Rollin  <krollin@apple.com>
     2
     3        Update Xcode projects with "Check .xcfilelists" build phase
     4        https://bugs.webkit.org/show_bug.cgi?id=193790
     5        <rdar://problem/47201374>
     6
     7        Reviewed by Alex Christensen.
     8
     9        Support for XCBuild includes specifying inputs and outputs to various
     10        Run Script build phases. These inputs and outputs are specified as
     11        .xcfilelist files. Once created, these .xcfilelist files need to be
     12        kept up-to-date. In order to check that they are up-to-date or not,
     13        add an Xcode build step that invokes an external script that performs
     14        the checking. If the .xcfilelists are found to be out-of-date, update
     15        them, halt the build, and instruct the developer to restart the build
     16        with up-to-date files.
     17
     18        At this time, the checking and regenerating is performed only if the
     19        WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
     20        who want to use this facility can set this variable and test out the
     21        checking/regenerating. Once it seems like there are no egregious
     22        issues that upset a developer's workflow, we'll unconditionally enable
     23        this facility.
     24
     25        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
     26        * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
     27        * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
     28        * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
     29
    1302019-01-25  Keith Rollin  <krollin@apple.com>
    231
  • trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj

    r240517 r240525  
    954954                        buildPhases = (
    955955                                9340994D08540CAE007F3BC8 /* Sources */,
     956                                53A8193B21E52997000B93AB /* Check .xcfilelists */,
    956957                        );
    957958                        buildRules = (
     
    10541055                        shellPath = /bin/sh;
    10551056                        shellScript = "eval \"${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}\"\n";
     1057                };
     1058                53A8193B21E52997000B93AB /* Check .xcfilelists */ = {
     1059                        isa = PBXShellScriptBuildPhase;
     1060                        buildActionMask = 2147483647;
     1061                        files = (
     1062                        );
     1063                        inputFileListPaths = (
     1064                        );
     1065                        inputPaths = (
     1066                        );
     1067                        name = "Check .xcfilelists";
     1068                        outputFileListPaths = (
     1069                        );
     1070                        outputPaths = (
     1071                        );
     1072                        runOnlyForDeploymentPostprocessing = 0;
     1073                        shellPath = /bin/sh;
     1074                        shellScript = "Scripts/check-xcfilelists.sh\n";
    10561075                };
    10571076/* End PBXShellScriptBuildPhase section */
  • trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj

    r240517 r240525  
    953953                                BC25185F11D15D54002EBC01 /* Sources */,
    954954                                BC25186011D15D54002EBC01 /* Frameworks */,
     955                                53A8193A21E52973000B93AB /* Check .xcfilelists */,
    955956                        );
    956957                        buildRules = (
     
    10591060                        shellPath = /bin/sh;
    10601061                        shellScript = "eval \"${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}\"\n";
     1062                };
     1063                53A8193A21E52973000B93AB /* Check .xcfilelists */ = {
     1064                        isa = PBXShellScriptBuildPhase;
     1065                        buildActionMask = 2147483647;
     1066                        files = (
     1067                        );
     1068                        inputFileListPaths = (
     1069                        );
     1070                        inputPaths = (
     1071                        );
     1072                        name = "Check .xcfilelists";
     1073                        outputFileListPaths = (
     1074                        );
     1075                        outputPaths = (
     1076                        );
     1077                        runOnlyForDeploymentPostprocessing = 0;
     1078                        shellPath = /bin/sh;
     1079                        shellScript = "Scripts/check-xcfilelists.sh\n";
    10611080                };
    10621081                BC952D8211F3BF78003398B4 /* Generate Derived Sources */ = {
Note: See TracChangeset for help on using the changeset viewer.