Changeset 240536 in webkit

Timestamp:

Jan 25, 2019 5:40:24 PM (5 years ago)

Author:

Simon Fraser

Message:

Fix failing scrollingcoordinator/scrolling-tree/remove-scrolling-role.html

Test needed different macOS and iOS results. Added window.internals.settings.setAsyncOverflowScrollingEnabled(true)
so the test uses async overflow scrolling in the macOS result.

• platform/ios-wk2/scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt: Copied from LayoutTests/scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt.
• scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt:
• scrollingcoordinator/scrolling-tree/remove-scrolling-role.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt (copied) (copied from trunk/LayoutTests/scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt)
• scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt (modified) (2 diffs)
• scrollingcoordinator/scrolling-tree/remove-scrolling-role.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-01-25  Simon Fraser  <simon.fraser@apple.com>
+
+        Fix failing scrollingcoordinator/scrolling-tree/remove-scrolling-role.html
+
+        Test needed different macOS and iOS results. Added window.internals.settings.setAsyncOverflowScrollingEnabled(true)
+        so the test uses async overflow scrolling in the macOS result.
+
+        * platform/ios-wk2/scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt: Copied from LayoutTests/scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt.
+        * scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt:
+        * scrollingcoordinator/scrolling-tree/remove-scrolling-role.html:
+
 2019-01-25  Simon Fraser  <simon.fraser@apple.com>
 

trunk/LayoutTests/scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt

@@ -1 +1 @@
 
 (Frame scrolling node
-  (scrollable area size 800 600)
-  (contents size 800 2513)
+  (scrollable area size 785 600)
+  (contents size 785 2513)
   (scrollable area parameters 
-    (horizontal scroll elasticity 1)
-    (vertical scroll elasticity 1)
+    (horizontal scroll elasticity 2)
+    (vertical scroll elasticity 2)
     (horizontal scrollbar mode 0)
-    (vertical scrollbar mode 0))
+    (vertical scrollbar mode 0)
+    (has enabled vertical scrollbar 1))
   (visual viewport enabled 1)
-  (layout viewport at (0,0) size 800x600)
+  (layout viewport at (0,0) size 785x600)
   (min layout viewport origin (0,0))
   (max layout viewport origin (0,1913))
@@ -15 +16 @@
   (children 1
     (Overflow scrolling node
-      (scrollable area size 300 400)
-      (contents size 300 2000)
+      (scrollable area size 285 400)
+      (contents size 285 2000)
       (scrollable area parameters 
         (horizontal scroll elasticity 1)

trunk/LayoutTests/scrollingcoordinator/scrolling-tree/remove-scrolling-role.html

@@ -37 +37 @@
         }
 
+        if (window.internals)
+            window.internals.settings.setAsyncOverflowScrollingEnabled(true);
+
         function doTest()
         {