Changeset 240686 in webkit

Timestamp:

Jan 29, 2019 3:10:46 PM (5 years ago)

Author:

Ross Kirsling

Message:

Remove FIXME for Annex B.3.5's "for-of var" subcase.

Rubber-stamped by Yusuke Suzuki.

This subcase is removed from the spec in ​https://github.com/tc39/ecma262/pull/1393.

• parser/Parser.h:

(JSC::Parser::declareHoistedVariable):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• parser/Parser.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-01-29  Ross Kirsling  <ross.kirsling@sony.com>
+
+        Remove FIXME for Annex B.3.5's "for-of var" subcase.
+
+        Rubber-stamped by Yusuke Suzuki.
+
+        This subcase is removed from the spec in https://github.com/tc39/ecma262/pull/1393.
+
+        * parser/Parser.h:
+        (JSC::Parser::declareHoistedVariable):
+
 2019-01-29  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/JavaScriptCore/parser/Parser.h

@@ -1231 +1231 @@
         while (true) {
             // Annex B.3.5 exempts `try {} catch (e) { var e; }` from being a syntax error.
-            // FIXME: This exemption should not apply if the var declaration is a for-of initializer.
             if (m_scopeStack[i].hasLexicallyDeclaredVariable(*ident) && !m_scopeStack[i].isSimpleCatchParameterScope())
                 return DeclarationResult::InvalidDuplicateDeclaration;