Changeset 240709 in webkit


Ignore:
Timestamp:
Jan 30, 2019 7:07:05 AM (5 years ago)
Author:
Chris Fleizach
Message:

AX: Role=switch not returning correct accessibilityValue
​https://bugs.webkit.org/show_bug.cgi?id=194006

Reviewed by Joanmarie Diggs.

Source/WebCore:

Return the toggle state of a role=switch element.

Test: accessibility/ios-simulator/role-switch.html

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityValue]):

LayoutTests:

  • accessibility/ios-simulator/role-switch-expected.txt: Added.
  • accessibility/ios-simulator/role-switch.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r240707 r240709  
     12019-01-30  Chris Fleizach  <cfleizach@apple.com>
     2
     3        AX: Role=switch not returning correct accessibilityValue
     4        https://bugs.webkit.org/show_bug.cgi?id=194006
     5
     6        Reviewed by Joanmarie Diggs.
     7
     8        * accessibility/ios-simulator/role-switch-expected.txt: Added.
     9        * accessibility/ios-simulator/role-switch.html: Added.
     10
    1112019-01-30  Zan Dobersek  <zdobersek@igalia.com>
    212

  • trunk/Source/WebCore/ChangeLog

    r240706 r240709  
     12019-01-30  Chris Fleizach  <cfleizach@apple.com>
     2
     3        AX: Role=switch not returning correct accessibilityValue
     4        https://bugs.webkit.org/show_bug.cgi?id=194006
     5
     6        Reviewed by Joanmarie Diggs.
     7
     8        Return the toggle state of a role=switch element.       
     9
     10        Test: accessibility/ios-simulator/role-switch.html
     11
     12        * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
     13        (-[WebAccessibilityObjectWrapper accessibilityValue]):
     14
    1152019-01-29  Rob Buis  <rbuis@igalia.com>
    216

  • trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm

    r240219 r240709  
    14051405   
    14061406    AccessibilityRole role = m_object->roleValue();
    1407     if (m_object->isCheckboxOrRadio() || role == AccessibilityRole::MenuItemCheckbox || role == AccessibilityRole::MenuItemRadio) {
     1407    if (m_object->isCheckboxOrRadio() || role == AccessibilityRole::MenuItemCheckbox || role == AccessibilityRole::MenuItemRadio || role == AccessibilityRole::Switch) {
    14081408        switch (m_object->checkboxOrRadioValue()) {
    14091409        case AccessibilityButtonState::Off:
Note: See TracChangeset for help on using the changeset viewer.