Changeset 240939 in webkit

Timestamp:

Feb 4, 2019 1:03:20 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Source/WebCore:
When performing Increment or Decrement on sliders, check to see if the slider is disabled.
​https://bugs.webkit.org/show_bug.cgi?id=173497

Patch by Eric Liang <​ericliang@apple.com> on 2019-02-04
Reviewed by Chris Fleizach.

Test: accessibility/set-value-not-work-for-disabled-sliders.html

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::alterSliderValue):

LayoutTests:
Check if slider value changed after calling AX Increment or Decrement on disabled sliders.
​https://bugs.webkit.org/show_bug.cgi?id=193497

Patch by Eric Liang <​ericliang@apple.com> on 2019-02-04
Reviewed by Chris Fleizach.

• accessibility/set-value-not-work-for-disabled-sliders.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/set-value-not-work-for-disabled-sliders-expected.txt (added)
• LayoutTests/accessibility/set-value-not-work-for-disabled-sliders.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/AccessibilityNodeObject.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-02-04  Eric Liang  <ericliang@apple.com>
+
+        Check if slider value changed after calling AX Increment or Decrement on disabled sliders.
+        https://bugs.webkit.org/show_bug.cgi?id=193497
+
+        Reviewed by Chris Fleizach.
+
+        * accessibility/set-value-not-work-for-disabled-sliders.html: Added.
+
 2019-02-04  Frederic Wang  <fwang@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-02-04  Eric Liang  <ericliang@apple.com>
+
+        When performing Increment or Decrement on sliders, check to see if the slider is disabled.
+        https://bugs.webkit.org/show_bug.cgi?id=173497
+
+        Reviewed by Chris Fleizach.
+
+        Test: accessibility/set-value-not-work-for-disabled-sliders.html
+
+        * accessibility/AccessibilityNodeObject.cpp:
+        (WebCore::AccessibilityNodeObject::alterSliderValue):
+
 2019-02-04  Sihui Liu  <sihui_liu@apple.com>
 

trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp

@@ -1064 +1064 @@
     if (roleValue() != AccessibilityRole::Slider)
         return;
+    
+    auto element = this->element();
+    if (!element || element->isDisabledFormControl())
+        return;
 
     if (!getAttribute(stepAttr).isEmpty())