Changeset 240989 in webkit

Timestamp:

Feb 5, 2019 12:35:10 PM (5 years ago)

Author:

Nikita Vasilyev

Message:

Web Inspector: Fix modify-css-property-race.html test failures
​https://bugs.webkit.org/show_bug.cgi?id=194282

Reviewed by Matt Baker.

Fix test failures introduced by r240946 by providing a message for expectGreaterThan assert,
so it doesn't log the actual values.

• inspector/css/modify-css-property-race-expected.txt:
• inspector/css/modify-css-property-race.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• inspector/css/modify-css-property-race-expected.txt (modified) (1 diff)
• inspector/css/modify-css-property-race.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-02-05  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        Web Inspector: Fix modify-css-property-race.html test failures
+        https://bugs.webkit.org/show_bug.cgi?id=194282
+
+        Reviewed by Matt Baker.
+
+        Fix test failures introduced by r240946 by providing a message for expectGreaterThan assert,
+        so it doesn't log the actual values.
+
+        * inspector/css/modify-css-property-race-expected.txt:
+        * inspector/css/modify-css-property-race.html:
+
 2019-02-05  Andy VanWagoner  <andy@vanwagoner.family>
 

trunk/LayoutTests/inspector/css/modify-css-property-race-expected.txt

@@ -4 +4 @@
 == Running test suite: ModifyCSSProperty
 -- Running test case: ModifyCSSPropertyRace.ChangeInlineStyle
-PASS: expectGreaterThan(43, 42)
-PASS: expectGreaterThan(43, 42)
-PASS: Value updated to "10px".
+PASS: Height should be greater than 42px.
+PASS: Height should be greater than 42px.
+PASS: Height should be 10px.
 PASS: CSSStyleDeclaration text should update.
-PASS: expectGreaterThanOrEqual(10, 10)
+PASS: Height should be greater or equal 10px.
 

trunk/LayoutTests/inspector/css/modify-css-property-race.html

@@ -67 +67 @@
                 if (!updateCount) {
                     let valueNumber = parseInt(getProperty("height").rawValue);
-                    InspectorTest.expectGreaterThan(valueNumber, 42);
+                    InspectorTest.expectGreaterThan(valueNumber, 42, "Height should be greater than 42px.");
                 } else if (updateCount === 1) {
                     let valueNumber = parseInt(getProperty("height").rawValue);
-                    InspectorTest.expectGreaterThan(valueNumber, 42);
+                    InspectorTest.expectGreaterThan(valueNumber, 42, "Height should be greater than 42px.");
                     getProperty("height").rawValue = "10px";
                 } else if (updateCount === 2) {
-                    InspectorTest.expectEqual(getProperty("height").rawValue, "10px", `Value updated to "10px".`);
+                    InspectorTest.expectEqual(getProperty("height").rawValue, "10px", "Height should be 10px.");
                     InspectorTest.expectEqual(getInlineStyleDeclaration().text, "height: 10px;", "CSSStyleDeclaration text should update.");
                 } else {
                     let valueNumber = parseInt(getProperty("height").rawValue);
-                    InspectorTest.expectGreaterThanOrEqual(valueNumber, 10);
+                    InspectorTest.expectGreaterThanOrEqual(valueNumber, 10, "Height should be greater or equal 10px.");
 
                     InspectorTest.evaluateInPage("stopExpanding()");