Changeset 241431 in webkit

Timestamp:

Feb 13, 2019 4:21:00 AM (5 years ago)

Author:

Tadeu Zagallo

Message:

SourceCode should be copied when generating bytecode for functions
​https://bugs.webkit.org/show_bug.cgi?id=194536

Reviewed by Saam Barati.

The FunctionExecutable might be collected while generating the bytecode
for nested functions, in which case the SourceCode reference would no
longer be valid.

• runtime/CodeCache.cpp:

(JSC::generateUnlinkedCodeBlockForFunctions):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/CodeCache.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-02-13  Tadeu Zagallo  <tzagallo@apple.com>
+
+        SourceCode should be copied when generating bytecode for functions
+        https://bugs.webkit.org/show_bug.cgi?id=194536
+
+        Reviewed by Saam Barati.
+
+        The FunctionExecutable might be collected while generating the bytecode
+        for nested functions, in which case the SourceCode reference would no
+        longer be valid.
+
+        * runtime/CodeCache.cpp:
+        (JSC::generateUnlinkedCodeBlockForFunctions):
+
 2019-02-12  Saam barati  <sbarati@apple.com>
 

trunk/Source/JavaScriptCore/runtime/CodeCache.cpp

@@ -171 +171 @@
 
         FunctionExecutable* executable = unlinkedExecutable->link(vm, parentSource);
-        const SourceCode& source = executable->source();
+        // FIXME: We shouldn't need to create a FunctionExecutable just to get its source code
+        // https://bugs.webkit.org/show_bug.cgi?id=194576
+        SourceCode source = executable->source();
         UnlinkedFunctionCodeBlock* unlinkedFunctionCodeBlock = unlinkedExecutable->unlinkedCodeBlockFor(vm, source, constructorKind, debuggerMode, error, unlinkedExecutable->parseMode());
         if (unlinkedFunctionCodeBlock)