Changeset 241436 in webkit


Ignore:
Timestamp:
Feb 13, 2019 9:12:57 AM (5 years ago)
Author:
sihui_liu@apple.com
Message:

Add two regression tests for reference cycle in IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=194527

Reviewed by Geoffrey Garen.

  • fast/dom/reference-cycle-leaks.html:
  • platform/win/TestExpectations:

The added tests are failing on win bots for unknown reasons, propably related to webkit.org/b/193540. Skip them
on win.

  • storage/indexeddb/resources/result-request-cycle.js: Added.

(prepareDatabase):

  • storage/indexeddb/resources/value-cursor-cycle.js: Added.

(prepareDatabase):
(onOpen.cursorRequest.onsuccess):

  • storage/indexeddb/result-request-cycle-expected.txt: Added.
  • storage/indexeddb/result-request-cycle.html: Added.
  • storage/indexeddb/value-cursor-cycle-expected.txt: Added.
  • storage/indexeddb/value-cursor-cycle.html: Added.
Location:
trunk/LayoutTests
Files:
6 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r241432 r241436  
     12019-02-13  Sihui Liu  <sihui_liu@apple.com>
     2
     3        Add two regression tests for reference cycle in IndexedDB
     4        https://bugs.webkit.org/show_bug.cgi?id=194527
     5
     6        Reviewed by Geoffrey Garen.
     7
     8        * fast/dom/reference-cycle-leaks.html:
     9        * platform/win/TestExpectations:
     10        The added tests are failing on win bots for unknown reasons, propably related to webkit.org/b/193540. Skip them
     11        on win.
     12
     13        * storage/indexeddb/resources/result-request-cycle.js: Added.
     14        (prepareDatabase):
     15        * storage/indexeddb/resources/value-cursor-cycle.js: Added.
     16        (prepareDatabase):
     17        (onOpen.cursorRequest.onsuccess):
     18        * storage/indexeddb/result-request-cycle-expected.txt: Added.
     19        * storage/indexeddb/result-request-cycle.html: Added.
     20        * storage/indexeddb/value-cursor-cycle-expected.txt: Added.
     21        * storage/indexeddb/value-cursor-cycle.html: Added.
     22
    1232019-02-13  Antoine Quint  <graouts@apple.com>
    224

  • trunk/LayoutTests/fast/dom/reference-cycle-leaks.html

    r235856 r241436  
    118118}
    119119
    120 function createIDBRequestResultCycle()
    121 {
    122     // FIXME: Need to write this test and reorganize so it can be asynchronous.
    123     // Get an IDBRequest with a result that is a structured clone (see IDBTransaction::didGetRecordOnServer).
    124     // Add a property to the result object that references the request.
    125     // Add another property to the result object that references a leak detection node.
    126 }
     120// Reference cycle of IDBRequest and IDBCursor is tested in
     121// storage/indexeddb/value-cursor-cycle.html and LayoutTests/storage/indexeddb/result-request-cycle.html.
    127122
    128123// PaymentResponse details reference cycle is tested in

  • trunk/LayoutTests/platform/win/TestExpectations

    r241322 r241436  
    42714271
    42724272webkit.org/b/194451 accessibility/set-value-not-work-for-disabled-sliders.html [ Failure ]
     4273
     4274storage/indexeddb/result-request-cycle.html [ Skip ]
     4275storage/indexeddb/value-cursor-cycle.html [ Skip ]
Note: See TracChangeset for help on using the changeset viewer.