Changeset 241492 in webkit

Timestamp:

Feb 13, 2019 6:28:48 PM (5 years ago)

Author:

jer.noble@apple.com

Message:

[Mac] PiP window can get "stuck" if PiP is closed while Safari window is minimized.
​https://bugs.webkit.org/show_bug.cgi?id=194621
<rdar://problem/48002560>

Reviewed by Eric Carlson.

When Safari is minimized, no rAF() requests are executed. Don't gate responding to presentation
change events in the media-controller.js on rAF().

• Modules/modern-media-controls/media/media-controller.js:

(MediaController.prototype._returnMediaLayerToInlineIfNeeded):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/modern-media-controls/media/media-controller.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-02-13  Jer Noble  <jer.noble@apple.com>
+
+        [Mac] PiP window can get "stuck" if PiP is closed while Safari window is minimized.
+        https://bugs.webkit.org/show_bug.cgi?id=194621
+        <rdar://problem/48002560>
+
+        Reviewed by Eric Carlson.
+
+        When Safari is minimized, no rAF() requests are executed. Don't gate responding to presentation
+        change events in the media-controller.js on rAF().
+
+        * Modules/modern-media-controls/media/media-controller.js:
+        (MediaController.prototype._returnMediaLayerToInlineIfNeeded):
+
 2019-02-13  John Wilander  <wilander@apple.com>
 

trunk/Source/WebCore/Modules/modern-media-controls/media/media-controller.js

@@ -285 +285 @@
     {
         if (this.host)
-            window.requestAnimationFrame(() => this.host.setPreparedToReturnVideoLayerToInline(this.media.webkitPresentationMode !== PiPMode));
+            this.host.setPreparedToReturnVideoLayerToInline(this.media.webkitPresentationMode !== PiPMode);
     }