Changeset 241656 in webkit
- Timestamp:
- Feb 17, 2019 6:15:37 PM (5 years ago)
- Location:
- trunk
- Files:
-
- 19 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r241652 r241656 1 2019-02-17 Fujii Hironori <Hironori.Fujii@sony.com> 2 3 Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations 4 https://bugs.webkit.org/show_bug.cgi?id=194586 5 6 Reviewed by Ross Kirsling. 7 8 DumpJSConsoleLogInStdErr expectation is considered a bad idea. 9 And, we have dumpJSConsoleLogInStdErr test option now (Bug 177027). 10 11 Added dumpJSConsoleLogInStdErr=true webkit-test-runner option to all non-imported tests. 12 13 * TestExpectations: Removed DumpJSConsoleLogInStdErr expectations of non-imported tests. 14 * http/tests/appcache/404-resource-with-slow-main-resource.php: Added dumpJSConsoleLogInStdErr=true webkit-test-runner option. 15 * http/tests/appcache/deferred-events-delete-while-raising-timer.html: Ditto. 16 * http/tests/appcache/deferred-events-delete-while-raising.html: Ditto. 17 * http/tests/appcache/fail-on-update-2.html: Ditto. 18 * http/tests/appcache/fail-on-update.html: Ditto. 19 * http/tests/cache/disk-cache/redirect-chain-limits.html: Ditto. 20 * http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-css-in-main-frame.html: Ditto. 21 * http/tests/security/cross-origin-cached-images-parallel.html: Ditto. 22 * http/tests/security/frame-loading-via-document-write-async-delegates.html: Ditto. 23 * http/tests/security/frame-loading-via-document-write.html: Ditto. 24 * http/tests/xmlhttprequest/redirect-cross-origin-sync-double.html: Ditto. 25 * http/wpt/beacon/cors/cors-redirect-failure.html: Ditto. 26 * http/wpt/html/browsers/history/the-location-interface/location-protocol-setter-non-broken-async-delegate.html: Ditto. 27 * media/event-queue-crash.html: Ditto. 28 1 29 2019-02-17 Matt Baker <mattbaker@apple.com> 2 30 -
trunk/LayoutTests/TestExpectations
r241451 r241656 257 257 imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/per-global.window.html [ Skip ] 258 258 259 # Line number in the console logging may change so we silence it to avoid flakiness.260 http/tests/security/frame-loading-via-document-write.html [ DumpJSConsoleLogInStdErr ]261 http/tests/security/frame-loading-via-document-write-async-delegates.html [ DumpJSConsoleLogInStdErr ]262 263 259 imported/w3c/web-platform-tests/fetch/api/basic/mode-same-origin.any.html [ DumpJSConsoleLogInStdErr ] 264 260 imported/w3c/web-platform-tests/fetch/api/basic/scheme-about.any.html [ DumpJSConsoleLogInStdErr ] … … 319 315 imported/w3c/web-platform-tests/xhr/preserve-ua-header-on-redirect.htm [ Failure ] 320 316 imported/w3c/web-platform-tests/xhr/setrequestheader-case-insensitive.htm [ Failure ] 321 http/tests/security/cross-origin-cached-images-parallel.html [ DumpJSConsoleLogInStdErr ]322 317 323 318 # textarea.animate is not supported … … 340 335 imported/w3c/web-platform-tests/payment-request [ Skip ] 341 336 342 http/tests/xmlhttprequest/redirect-cross-origin-sync-double.html [ DumpJSConsoleLogInStdErr ]343 337 imported/w3c/web-platform-tests/xhr/send-redirect-bogus-sync.htm [ DumpJSConsoleLogInStdErr ] 344 338 … … 414 408 # Tests in this directory take > 30 minutes to run on debug bots. 415 409 [ Debug ] imported/w3c/web-platform-tests/encoding 416 417 # redirect-chain.php is generating some random number that appear in console error logging.418 http/tests/cache/disk-cache/redirect-chain-limits.html [ DumpJSConsoleLogInStdErr ]419 410 420 411 # Content encoding sniffing is only supported by CFNetwork. … … 1179 1170 webkit.org/b/141267 http/tests/misc/detached-frame-console.html [ Pass Failure ] 1180 1171 1181 http/tests/appcache/deferred-events-delete-while-raising-timer.html [ DumpJSConsoleLogInStdErr ]1182 http/tests/appcache/deferred-events-delete-while-raising.html [ DumpJSConsoleLogInStdErr ]1183 http/tests/appcache/fail-on-update.html [ DumpJSConsoleLogInStdErr ]1184 http/tests/appcache/fail-on-update-2.html [ DumpJSConsoleLogInStdErr ]1185 http/tests/appcache/404-resource-with-slow-main-resource.php [ DumpJSConsoleLogInStdErr ]1186 1187 1172 webkit.org/b/141370 http/tests/security/appcache-in-private-browsing.html [ Pass Failure ] 1188 1173 … … 1197 1182 http/tests/websocket/tests/hybi/contentextensions [ Skip ] 1198 1183 http/wpt/beacon/contentextensions [ Skip ] 1199 1200 http/wpt/beacon/cors/cors-redirect-failure.html [ DumpJSConsoleLogInStdErr ]1201 1184 1202 1185 webkit.org/b/149072 svg/animations/svgboolean-animation-1.html [ Pass Failure ] … … 2067 2050 imported/w3c/web-platform-tests/workers/worker-performance.worker.html [ Pass Failure ] 2068 2051 2069 webkit.org/b/183390 http/wpt/html/browsers/history/the-location-interface/location-protocol-setter-non-broken-async-delegate.html [ DumpJSConsoleLogInStdErr Pass Failure ] 2070 2071 # We sometimes get 2 console log messages about CSP instead of 1 due to preloading. 2072 http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-css-in-main-frame.html [ DumpJSConsoleLogInStdErr ] 2073 2074 media/event-queue-crash.html [ DumpJSConsoleLogInStdErr ] 2052 webkit.org/b/183390 http/wpt/html/browsers/history/the-location-interface/location-protocol-setter-non-broken-async-delegate.html [ Pass Failure ] 2075 2053 2076 2054 webkit.org/b/172243 imported/w3c/web-platform-tests/IndexedDB/idbdatabase-createObjectStore-exception-order.htm [ Pass Failure ] -
trunk/LayoutTests/http/tests/appcache/404-resource-with-slow-main-resource.php
r178943 r241656 1 <!-- webkit-test-runner [ dumpJSConsoleLogInStdErr=true ] --> 1 2 <html manifest="resources/404-resource.manifest"> 2 3 <div>This tests that a manifest that contains a missing file will not crash the browser even if the main resource keeps loading after the error occurs.</div> -
trunk/LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-timer.html
r120167 r241656 1 <!-- webkit-test-runner [ dumpJSConsoleLogInStdErr=true ] --> 1 2 <html> 2 3 <script> -
trunk/LayoutTests/http/tests/appcache/deferred-events-delete-while-raising.html
r120167 r241656 1 <!-- webkit-test-runner [ dumpJSConsoleLogInStdErr=true ] --> 1 2 <html manifest="THIS_FILE_DOES_NOT_EXIST.manifest"> 2 3 <head> -
trunk/LayoutTests/http/tests/appcache/fail-on-update-2.html
r175841 r241656 1 <!-- webkit-test-runner [ dumpJSConsoleLogInStdErr=true ] --> 1 2 <html manifest="resources/fail-on-update-2.php"> 2 3 <script> -
trunk/LayoutTests/http/tests/appcache/fail-on-update.html
r120167 r241656 1 <!-- webkit-test-runner [ dumpJSConsoleLogInStdErr=true ] --> 1 2 <html manifest="resources/fail-on-update.php"> 2 3 <script> -
trunk/LayoutTests/http/tests/cache/disk-cache/redirect-chain-limits.html
r194337 r241656 1 <!-- webkit-test-runner [ dumpJSConsoleLogInStdErr=true ] --> 1 2 <script src="/js-test-resources/js-test-pre.js"></script> 2 3 <script> -
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-css-in-main-frame.html
r209577 r241656 1 <!DOCTYPE html> 1 <!DOCTYPE html><!-- webkit-test-runner [ dumpJSConsoleLogInStdErr=true ] --> 2 2 <html> 3 3 <head> -
trunk/LayoutTests/http/tests/security/cross-origin-cached-images-parallel.html
r205854 r241656 1 <!-- webkit-test-runner [ dumpJSConsoleLogInStdErr=true ] --> 1 2 <html> 2 3 <body> -
trunk/LayoutTests/http/tests/security/frame-loading-via-document-write-async-delegates.html
r229539 r241656 1 <!-- webkit-test-runner [ dumpJSConsoleLogInStdErr=true ] --> 1 2 <html> 2 3 <head> -
trunk/LayoutTests/http/tests/security/frame-loading-via-document-write.html
r229539 r241656 1 <!-- webkit-test-runner [ dumpJSConsoleLogInStdErr=true ] --> 1 2 <html> 2 3 <head> -
trunk/LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-sync-double.html
r153915 r241656 1 <!-- webkit-test-runner [ dumpJSConsoleLogInStdErr=true ] --> 1 2 <html> 2 3 <body> -
trunk/LayoutTests/http/wpt/beacon/cors/cors-redirect-failure.html
r230495 r241656 1 <!doctype html> 1 <!doctype html><!-- webkit-test-runner [ dumpJSConsoleLogInStdErr=true ] --> 2 2 <html> 3 3 <head> -
trunk/LayoutTests/http/wpt/html/browsers/history/the-location-interface/location-protocol-setter-non-broken-async-delegate.html
r229191 r241656 1 <!doctype html> 1 <!doctype html><!-- webkit-test-runner [ dumpJSConsoleLogInStdErr=true ] --> 2 2 <title>Set location.protocol to a non-broken-non-functioning scheme</title> 3 3 <!-- In particular, valid non-broken schemes that are nevertheless not going to work --> -
trunk/LayoutTests/media/event-queue-crash.html
r226785 r241656 1 <!DOCTYPE html> 1 <!DOCTYPE html><!-- webkit-test-runner [ dumpJSConsoleLogInStdErr=true ] --> 2 2 <html> 3 3 <script src="media-file.js"></script> -
trunk/Tools/ChangeLog
r241654 r241656 1 2019-02-17 Fujii Hironori <Hironori.Fujii@sony.com> 2 3 Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations 4 https://bugs.webkit.org/show_bug.cgi?id=194586 5 6 Reviewed by Ross Kirsling. 7 8 * DumpRenderTree/win/DumpRenderTree.cpp: 9 (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true. 10 * Scripts/webkitpy/port/driver.py: 11 (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path. 12 1 13 2019-02-17 David Kilzer <ddkilzer@apple.com> 2 14 -
trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp
r241654 r241656 1174 1174 ::gTestRunner = TestRunner::create(testURL.data(), command.expectedPixelHash); 1175 1175 ::gTestRunner->setCustomTimeout(command.timeout); 1176 ::gTestRunner->setDumpJSConsoleLogInStdErr(command.dumpJSConsoleLogInStdErr );1176 ::gTestRunner->setDumpJSConsoleLogInStdErr(command.dumpJSConsoleLogInStdErr || options.dumpJSConsoleLogInStdErr); 1177 1177 1178 1178 topLoadingFrame = nullptr; -
trunk/Tools/Scripts/webkitpy/port/driver.py
r239989 r241656 546 546 command = self.test_to_uri(driver_input.test_name) 547 547 command += "'--absolutePath'" 548 command += self._port.abspath_for_test(driver_input.test_name, self._target_host) 548 absPath = self._port.abspath_for_test(driver_input.test_name, self._target_host) 549 if sys.platform == 'cygwin': 550 absPath = path.cygpath(absPath) 551 command += absPath 549 552 else: 550 553 command = self._port.abspath_for_test(driver_input.test_name, self._target_host)
Note: See TracChangeset
for help on using the changeset viewer.