Changeset 241874 in webkit

Timestamp:

Feb 21, 2019 10:56:36 AM (5 years ago)

Author:

Devin Rousso

Message:

Web Inspector: DOM Debugger: node-specific event breakpoints aren't cleared/recalculated on navigation
​https://bugs.webkit.org/show_bug.cgi?id=194874
<rdar://problem/48253415>

Reviewed by Joseph Pecoraro.

• UserInterface/Controllers/DOMManager.js:

(WI.DOMManager.prototype._setDocument):
(WI.DOMManager.prototype.removeBreakpointForEventListener):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Controllers/DOMManager.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-02-21  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: DOM Debugger: node-specific event breakpoints aren't cleared/recalculated on navigation
+        https://bugs.webkit.org/show_bug.cgi?id=194874
+        <rdar://problem/48253415>
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Controllers/DOMManager.js:
+        (WI.DOMManager.prototype._setDocument):
+        (WI.DOMManager.prototype.removeBreakpointForEventListener):
+
 2019-02-21  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js

@@ -280 +280 @@
     {
         this._idToDOMNode = {};
+
+        for (let breakpoint of this._breakpointsForEventListeners.values())
+            WI.domDebuggerManager.dispatchEventToListeners(WI.DOMDebuggerManager.Event.EventBreakpointRemoved, {breakpoint});
         this._breakpointsForEventListeners.clear();
 
@@ -653 +656 @@
             }
 
-            if (breakpoint)
-                WI.domDebuggerManager.dispatchEventToListeners(WI.DOMDebuggerManager.Event.EventBreakpointRemoved, {breakpoint});
+            WI.domDebuggerManager.dispatchEventToListeners(WI.DOMDebuggerManager.Event.EventBreakpointRemoved, {breakpoint});
         });
     }