Changeset 241925 in webkit

Timestamp:

Feb 21, 2019 5:51:32 PM (5 years ago)

Author:

timothy_horton@apple.com

Message:

Turn a high-value UI-side-compositing assertion into a release assert
​https://bugs.webkit.org/show_bug.cgi?id=194887

Reviewed by Simon Fraser.

• WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::recursiveBuildTransaction):
There is absolutely no situation in which this assert should fire
if WebKit is behaving correctly, and it will basically always result
in a UI process crash (or at least confusion), so make it a release assert.
This would have saved us a lot of stress in bug 194845.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-02-21  Tim Horton  <timothy_horton@apple.com>
+
+        Turn a high-value UI-side-compositing assertion into a release assert
+        https://bugs.webkit.org/show_bug.cgi?id=194887
+
+        Reviewed by Simon Fraser.
+
+        * WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:
+        (WebKit::PlatformCALayerRemote::recursiveBuildTransaction):
+        There is absolutely no situation in which this assert should fire
+        if WebKit is behaving correctly, and it will basically always result
+        in a UI process crash (or at least confusion), so make it a release assert.
+        This would have saved us a lot of stress in bug 194845.
+
 2019-02-21  Don Olmstead  <don.olmstead@sony.com>
 

trunk/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp

@@ -169 +169 @@
 {
     ASSERT(!m_properties.backingStore || owner());
-    ASSERT_WITH_SECURITY_IMPLICATION(&context == m_context);
+    RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(&context == m_context);
     
     if (m_properties.backingStore && (!owner() || !owner()->platformCALayerDrawsContent())) {